[lib] Introduce thickThreadTypes and ThickThreadType
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:09 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMM2dd79253cac8: [lib] Introduce thickThreadTypes and ThickThreadType

Summary

These 3 thread types will cover all of the initial thick thread types.

Depends on D12487

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 19 2024, 5:09 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:09 PM

ashoat added a child revision: D12489: [keyserver][lib] Update thread type assertion functions for thick/thread distinction.Jun 19 2024, 5:10 PM

Harbormaster completed remote builds in B29792: Diff 41524.Jun 19 2024, 5:52 PM

ashoat requested review of this revision.Jun 19 2024, 5:52 PM

kamil accepted this revision.Jun 20 2024, 2:19 AM

This revision is now accepted and ready to land.Jun 20 2024, 2:19 AM

inka added a subscriber: inka.Jun 21 2024, 5:56 AM

inka added inline comments.

lib/types/thread-types-enum.js
43–44	This comment should probably not reference `COMMUNITY_SECRET_SUBTHREAD` anymore

ashoat added inline comments.Jun 26 2024, 11:23 AM

lib/types/thread-types-enum.js
43–44	Good catch!!

Closed by commit rCOMM2dd79253cac8: [lib] Introduce thickThreadTypes and ThickThreadType (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2dd79253cac8: [lib] Introduce thickThreadTypes and ThickThreadType.

Revision Contents
Changeset List

Path

Size

lib/

types/

thread-types-enum.js

22 lines

Diff 41524

View Options

lib/types/thread-types-enum.js

[lib] Introduce thickThreadTypes and ThickThreadTypeClosedPublicActions