[lib] Add support for thick threads to baseCreatePendingSidebar
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:11 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMMf4cabe77e2a0: [lib] Add support for thick threads to baseCreatePendingSidebar

Summary

We'll use a different thread type for sidebars in thick threads.

Additional changes will be necessary in createPendingThread, but I'll handle those separately in a later diff.

Depends on D12489

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 19 2024, 5:11 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:11 PM

ashoat added a child revision: D12491: [lib] Introduce usingOlmViaTunnelbrokerForDMs to get DM creation.Jun 19 2024, 5:12 PM

Harbormaster completed remote builds in B29794: Diff 41526.Jun 19 2024, 6:01 PM

ashoat requested review of this revision.Jun 19 2024, 6:01 PM

kamil accepted this revision.Jun 20 2024, 2:54 AM

This revision is now accepted and ready to land.Jun 20 2024, 2:54 AM

Closed by commit rCOMMf4cabe77e2a0: [lib] Add support for thick threads to baseCreatePendingSidebar (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf4cabe77e2a0: [lib] Add support for thick threads to baseCreatePendingSidebar.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-utils.js

12 lines

types/

thread-types-enum.js

5 lines

Diff 41526

View Options

lib/shared/sidebar-utils.js