Page MenuHomePhabricator
Differential D12493

[lib] Simplify threadOtherMembers
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 10:27 PM
Unknown Object (File)
Fri, Feb 28, 11:20 PM
Unknown Object (File)
Feb 26 2025, 3:20 AM
Unknown Object (File)
Feb 21 2025, 3:57 PM
Unknown Object (File)
Feb 20 2025, 10:10 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:34 AM
View All 66 Files
Subscribers
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMMd40d3b4d382c: [lib] Simplify threadOtherMembers
Summary

Instead of enumerating every kind of type we can pass here, we can just spell out exactly what we need in the type.

Depends on D12492

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
17 lines

Diff 41529

View Options

lib/shared/thread-utils.js

Show All 39 Linesimport {
usersWithPersonalThreadSelector, usersWithPersonalThreadSelector,
} from '../selectors/user-selectors.js'; } from '../selectors/user-selectors.js';
import type { import type {
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfoWithPermissions, MemberInfoWithPermissions,
RoleInfo, RoleInfo,
ThreadInfo, ThreadInfo,
MemberInfoSansPermissions,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
decodeMinimallyEncodedRoleInfo, decodeMinimallyEncodedRoleInfo,
minimallyEncodeMemberInfo, minimallyEncodeMemberInfo,
minimallyEncodeRawThreadInfo, minimallyEncodeRawThreadInfo,
minimallyEncodeRoleInfo, minimallyEncodeRoleInfo,
minimallyEncodeThreadCurrentUserInfo, minimallyEncodeThreadCurrentUserInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
▲ Show 20 Lines • Show All 251 Lines • ▼ Show 20 Lines
function threadActualMembers( function threadActualMembers(
memberInfos: $ReadOnlyArray<MemberInfoWithPermissions | RelativeMemberInfo>, memberInfos: $ReadOnlyArray<MemberInfoWithPermissions | RelativeMemberInfo>,
): $ReadOnlyArray<string> { ): $ReadOnlyArray<string> {
return memberInfos return memberInfos
.filter(memberInfo => memberInfo.role) .filter(memberInfo => memberInfo.role)
.map(memberInfo => memberInfo.id); .map(memberInfo => memberInfo.id);
} }
function threadOtherMembers< type MemberIDAndRole = {
T: +id: string,
| LegacyMemberInfo +role: ?string,
| MemberInfoWithPermissions ...
| MemberInfoSansPermissions };
| RelativeMemberInfo, function threadOtherMembers<T: MemberIDAndRole>(
>(memberInfos: $ReadOnlyArray<T>, viewerID: ?string): $ReadOnlyArray<T> { memberInfos: $ReadOnlyArray<T>,
viewerID: ?string,
): $ReadOnlyArray<T> {
return memberInfos.filter( return memberInfos.filter(
memberInfo => memberInfo.role && memberInfo.id !== viewerID, memberInfo => memberInfo.role && memberInfo.id !== viewerID,
); );
} }
function threadMembersWithoutAddedAdmin< function threadMembersWithoutAddedAdmin<
T: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, T: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
>(threadInfo: T): $PropertyType<T, 'members'> { >(threadInfo: T): $PropertyType<T, 'members'> {
▲ Show 20 Lines • Show All 1,406 Lines • Show Last 20 Lines