[lib] Simplify threadOtherMembers
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:13 PM.

Tags

None

Referenced Files

	F3269417: D12493.id41529.diff
	Sat, Nov 16, 3:50 AM

	F3265385: D12493.diff
	Sat, Nov 16, 1:09 AM

	Unknown Object (File)
	Sat, Nov 2, 4:15 PM

	Unknown Object (File)
	Fri, Nov 1, 6:34 PM

	Unknown Object (File)
	Oct 15 2024, 5:36 AM

	Unknown Object (File)
	Oct 13 2024, 11:03 AM

	Unknown Object (File)
	Oct 13 2024, 2:24 AM

	Unknown Object (File)
	Oct 13 2024, 2:24 AM

View All 49 Files

Subscribers

tomek

Details

Reviewers

kamil
marcin

Commits

rCOMMd40d3b4d382c: [lib] Simplify threadOtherMembers

Summary

Instead of enumerating every kind of type we can pass here, we can just spell out exactly what we need in the type.

Depends on D12492

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 19 2024, 5:13 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:13 PM

ashoat added a child revision: D12494: [lib] Factor out defaultSubscription in createPendingThread.Jun 19 2024, 5:14 PM

Harbormaster completed remote builds in B29797: Diff 41529.Jun 19 2024, 6:17 PM

ashoat requested review of this revision.Jun 19 2024, 6:17 PM

kamil accepted this revision.Jun 20 2024, 3:34 AM

This revision is now accepted and ready to land.Jun 20 2024, 3:34 AM

Closed by commit rCOMMd40d3b4d382c: [lib] Simplify threadOtherMembers (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd40d3b4d382c: [lib] Simplify threadOtherMembers.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

17 lines

Diff 41529

View Options

lib/shared/thread-utils.js

[lib] Simplify threadOtherMembersClosedPublicActions