Paths

Table of Contentst

Differential D12427

Move android rescinds and badge updates to lib
ClosedPublic
Actions

Authored by marcin on Jun 13 2024, 8:50 AM.

Tags

None

Referenced Files

	F3258655: D12427.id42028.diff
	Fri, Nov 15, 9:45 PM

	Unknown Object (File)
	Fri, Nov 1, 6:51 PM

	Unknown Object (File)
	Sun, Oct 20, 1:12 AM

	Unknown Object (File)
	Thu, Oct 17, 8:47 AM

	Unknown Object (File)
	Oct 13 2024, 3:55 AM

	Unknown Object (File)
	Oct 13 2024, 3:55 AM

	Unknown Object (File)
	Oct 13 2024, 3:55 AM

	Unknown Object (File)
	Oct 13 2024, 3:55 AM

View All 84 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM5c88cab342ee: Move android rescinds and badge updates to lib

Summary

This differential move Android rescinds and badge updates to lib and makes the keyserver use shared code.

Test Plan

Flow
Test that rescind and badge updates work on Android

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jun 13 2024, 8:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 13 2024, 8:50 AM

marcin added a parent revision: D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.Jun 13 2024, 8:51 AM

marcin added a child revision: D12428: Bump minimal native code version to 149.Jun 13 2024, 8:59 AM

Harbormaster completed remote builds in B29666: Diff 41290.Jun 13 2024, 9:07 AM

marcin requested review of this revision.Jun 13 2024, 9:07 AM

I strongly encourage you to rethink the amount of type spreads you're doing, especially when they're nested within other types

lib/push/notif-creators.js
329 ↗	(On Diff #41290)	In general, I am skeptical of this approach of nesting unions inside a spread. In the past I've seen Flow not handle it well. I usually opt to make the upper type a union, and to include the shared properties in each branch (`senderDeviceID`, `platformDetails`) via a spread
333 ↗	(On Diff #41290)
lib/types/notif-types.js
140 ↗	(On Diff #41290)	What is this spread doing?
165 ↗	(On Diff #41290)	What is this spread doing?

rebase and fix types

marcin added inline comments.Jun 20 2024, 4:36 AM

lib/push/android-notif-creators.js
266	This is logic copy pasted from `keyserver/push/rescind.js` but extended to allow rescinds without notification id (thick thread rescinds).
337	This logic is copy-pasted from `keyserver/src/send.js` but extended to allow thick thread badge updates.

Harbormaster completed remote builds in B29823: Diff 41556.Jun 20 2024, 5:03 AM

You forgot to address @ashoat's comments

lib/types/notif-types.js
168–174	This applies to types above

Address Ashoat requests

Harbormaster completed remote builds in B29868: Diff 41603.Jun 21 2024, 6:04 AM

kamil accepted this revision.Jun 25 2024, 3:26 AM

This revision is now accepted and ready to land.Jun 25 2024, 3:26 AM

Rebase before landing

Harbormaster completed remote builds in B30137: Diff 42014.Jul 4 2024, 6:04 AM

Closed by commit rCOMM5c88cab342ee: Move android rescinds and badge updates to lib (authored by marcin). · Explain WhyJul 4 2024, 7:19 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM5c88cab342ee: Move android rescinds and badge updates to lib.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

24 lines

46 lines

lib/

push/

android-notif-creators.js

155 lines

types/

45 lines

Diff 41556

keyserver/src/push/rescind.js

Loading...

keyserver/src/push/send.js

Loading...

lib/push/android-notif-creators.js

Loading...

lib/types/notif-types.js

Loading...