This differential mimics the keyserver logic for getting from MessageData to MessageInfo on the client
Details
Details
- Flow
- Next diff will enable testing this one more thoruoghly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/push/send-utils.js | ||
|---|---|---|
| 47 ↗ | (On Diff #41450) | This function just replaces enum constant used on identity with relevant string constant used on the client. |
| 74 ↗ | (On Diff #41450) | This loop groups messages by threads. |
| 96 ↗ | (On Diff #41450) | This loop gets information about devices of recipient for each thread. |
| 138 ↗ | (On Diff #41450) | This for loop is a duplication of what we have on the kesyerver. I will make sure to extract it before landing. This loop groups RawMessageInfo objects into those generation rescind (in practice just reaction messages) and those generating notifications. |
Comment Actions
- Fix CI
- Extract generateNotifUserInfoPromise logic and share it between all platforms
| lib/push/send-utils.js | ||
|---|---|---|
| 57 ↗ | (On Diff #41452) | Just copy paste from keyserver modified to support different device array in return type. |
| 150 ↗ | (On Diff #41452) | Get mapping from threadID to related messageInfos. MessageInfos are created from MessageDatas by adding local id or uuid if there is no local id/ @ashoat requested to do so in our 1:1. |
| 172 ↗ | (On Diff #41452) | Here we get mapping from recipient userIDs to related threadIDs and their devices. |
| lib/push/send-utils.js | ||
|---|---|---|
| 56–64 | this is too many params, can you update this to be an object? | |