Page MenuHomePhabricator

[lib] Temporarily switch LOCAL to COMMUNITY_SECRET_SUBTHREAD for pending threads
ClosedPublic

Authored by ashoat on Jun 19 2024, 5:08 PM.
Tags
None
Referenced Files
F3349064: D12487.id41523.diff
Fri, Nov 22, 4:58 PM
F3347610: D12487.diff
Fri, Nov 22, 12:43 PM
Unknown Object (File)
Tue, Nov 12, 8:35 AM
Unknown Object (File)
Sun, Nov 10, 12:13 PM
Unknown Object (File)
Fri, Nov 1, 7:09 PM
Unknown Object (File)
Oct 13 2024, 4:11 AM
Unknown Object (File)
Oct 13 2024, 4:11 AM
Unknown Object (File)
Oct 13 2024, 4:11 AM
Subscribers

Details

Summary

These two constants were hardcoded to be the same value. I used LOCAL instead of COMMUNITY_SECRET_SUBTHREAD in this case as a reminder to the author that we should be created thick threads here instead of thin threads eventually.

I'm ready to introduce a separate constant for LOCAL, but we'll need to do some additional work before we're able to switch to using it for new pending threads. For now I'll move this code to continue to use the same constant (COMMUNITY_SECRET_SUBTHREAD, which will stay as 4), but I'll return it back to using threadTypes.LOCAL once we're ready.

Depends on D12486

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable