Details

Reviewers

tomek
inka

Commits

rCOMM5095574803af: [lib] update `processDMOpsActionType` to handle composable DM messages

Summary

ENG-8424.

Previously it was done using sendDMActionTypes.started - but this code will be removed later in the stack.

Depends on D13323

Test Plan

Tested, that only when sending text message outboundP2PMessageIDs is set, and failed messages are persisted.

Diff Detail

Repository

rCOMM Comm

Branch

publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Sep 13 2024, 10:40 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 10:40 AM

kamil added a child revision: D13325: [lib] update `processOutboundP2PMessages` to return failed message IDs.Sep 13 2024, 10:43 AM

Harbormaster completed remote builds in B31592: Diff 44137.Sep 13 2024, 10:57 AM

kamil published this revision for review.Sep 13 2024, 11:34 AM

kamil added inline comments.

lib/reducers/message-reducer.js
1926

tomek accepted this revision.Sep 13 2024, 1:14 PM

tomek added inline comments.

lib/reducers/message-reducer.js
1908–1909	Do we still need to keep these two conditions?

This revision is now accepted and ready to land.Sep 13 2024, 1:14 PM

kamil added inline comments.Sep 16 2024, 10:00 AM

lib/reducers/message-reducer.js
1908–1909	yeah, otherwise Flow complains

fix comment

Harbormaster completed remote builds in B31634: Diff 44206.Sep 16 2024, 10:16 AM

Closed by commit rCOMM5095574803af: [lib] update `processDMOpsActionType` to handle composable DM messages. · Explain WhySep 16 2024, 11:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5095574803af: [lib] update `processDMOpsActionType` to handle composable DM messages.

[lib] update `processDMOpsActionType` to handle composable DM messages
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44137

lib/reducers/message-reducer.js

[lib] update `processDMOpsActionType` to handle composable DM messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44137

lib/reducers/message-reducer.js

[lib] update `processDMOpsActionType` to handle composable DM messages
ClosedPublic
Actions

Revision Contents
Changeset List