Page MenuHomePhabricator

[native] Handle rendering "No messages" inside MessagePreview
ClosedPublic

Authored by ashoat on Oct 30 2024, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 11:44 PM
Unknown Object (File)
Thu, Nov 28, 11:04 PM
Unknown Object (File)
Thu, Nov 28, 9:11 PM
Unknown Object (File)
Thu, Nov 28, 7:13 PM
Unknown Object (File)
Tue, Nov 26, 3:54 AM
Unknown Object (File)
Sat, Nov 23, 4:48 AM
Unknown Object (File)
Sat, Nov 23, 4:24 AM
Unknown Object (File)
Sat, Nov 23, 2:18 AM
Subscribers
None

Details

Summary

This matches behavior on web and makes a later diff a bit cleaner.

Depends on D13824

Test Plan

Flow, and tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage