Page MenuHomePhabricator
Differential D13932

[backup-client][native_rust_library] refactor uploading files to not ignore User Keys
ClosedPublic
Actions

Authored by kamil on Thu, Nov 14, 8:31 AM.
Tags
None
Referenced Files
F3405190: D13932.id45823.diff
Tue, Dec 3, 7:02 PM
Unknown Object (File)
Mon, Dec 2, 8:22 PM
Unknown Object (File)
Fri, Nov 29, 1:13 AM
Unknown Object (File)
Thu, Nov 28, 6:00 PM
Unknown Object (File)
Mon, Nov 25, 2:51 PM
Unknown Object (File)
Mon, Nov 25, 3:33 AM
Unknown Object (File)
Fri, Nov 22, 8:50 PM
Unknown Object (File)
Thu, Nov 21, 8:38 PM
View All 21 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore…
Summary

ENG-9656.

Previously, it was treating User Keys as additional data and was skipping upload, because User Keys were updated together with User Data Compaction. This diff refactors code to attempt compaction upload for any backup_id for which there is User Data, User Keys, or logs (but we don't generate logs now -> next diff).

Depends on D13931

Test Plan

Tested in D13937

Diff Detail

Repository
rCOMM Comm
Branch
publish-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Nov 14, 8:31 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Nov 14, 8:31 AM
kamil edited the summary of this revision. (Show Details)Thu, Nov 14, 8:32 AM
kamil added a child revision: D13933: [CommCoreModule] remove capturing logs.Thu, Nov 14, 8:34 AM
kamil edited the test plan for this revision. (Show Details)Thu, Nov 14, 9:03 AM
Harbormaster completed remote builds in B32664: Diff 45823.Thu, Nov 14, 11:18 AM
kamil published this revision for review.Fri, Nov 15, 2:23 AM
kamil added inline comments.
native/native_rust_library/src/backup/upload_handler.rs
165–167

not sure what is better, if this should be placed here when adding to Vec, or called only once before this loop

bartek accepted this revision.Tue, Nov 19, 5:45 AM
bartek added inline comments.
native/native_rust_library/src/backup/upload_handler.rs
165–167

I'm not sure if it makes any difference, it can stay here

This revision is now accepted and ready to land.Tue, Nov 19, 5:45 AM
Closed by commit rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore… (authored by kamil). · Explain WhyMon, Nov 25, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0e67143b806d: [backup-client][native_rust_library] refactor uploading files to not ignore….

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
backup/
2 lines
47 lines

Diff 45823

View Options

native/native_rust_library/src/backup/file_info.rs

Loading...
View Options

native/native_rust_library/src/backup/upload_handler.rs

Loading...