Page MenuHomePhabricator
Differential D13966

[native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS`
ClosedPublic
Actions

Authored by kamil on Nov 19 2024, 3:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 3:49 PM
Unknown Object (File)
Thu, Apr 3, 1:29 AM
Unknown Object (File)
Wed, Apr 2, 10:14 PM
Unknown Object (File)
Wed, Apr 2, 10:13 PM
Unknown Object (File)
Wed, Apr 2, 4:43 AM
Unknown Object (File)
Wed, Apr 2, 12:13 AM
Unknown Object (File)
Sun, Mar 23, 12:59 PM
Unknown Object (File)
Sun, Mar 23, 12:57 PM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
varun
Commits
rCOMM384394f111bc: [native][lib] remove `requestBackupKeys` from…
Summary

ENG-9905.

This makes no sense anymore, secondary will send this after registration, so we need to decide earlier based on the device type.

This change is not backward compatible but this flow hasn't been launched yet so we not breaking anything.

NOTE: It's not that easy to slice this into diffs, so it's possible that in the middle of the stack protocol is not working, it needs to be reviewed as a whole.

Depends on D13965

Test Plan

Tested later in the stack - D13968

Diff Detail

Repository
rCOMM Comm
Branch
secondary-auth
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 19 2024, 3:10 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 19 2024, 3:11 AM
kamil updated this revision to Diff 45876.Nov 19 2024, 3:12 AM

Flow

kamil edited the summary of this revision. (Show Details)Nov 19 2024, 3:13 AM
Harbormaster failed remote builds in B32709: Diff 45875!Nov 19 2024, 3:21 AM
Harbormaster completed remote builds in B32710: Diff 45876.Nov 19 2024, 3:31 AM
kamil published this revision for review.Nov 19 2024, 4:12 AM
kamil added a child revision: D13967: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created.Nov 19 2024, 4:17 AM
kamil edited the test plan for this revision. (Show Details)Nov 19 2024, 4:27 AM
bartek accepted this revision.Nov 20 2024, 6:41 AM
This revision is now accepted and ready to land.Nov 20 2024, 6:41 AM
Closed by commit rCOMM384394f111bc: [native][lib] remove `requestBackupKeys` from… (authored by kamil). · Explain WhyNov 25 2024, 4:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM384394f111bc: [native][lib] remove `requestBackupKeys` from….

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
1 line
lib/
components/
1 line
types/
tunnelbroker/
2 lines
native/
profile/
7 lines

Diff 45876

View Options

keyserver/src/socket/tunnelbroker.js

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Linesexport type UpdateConnectionStatusPayload = {
+status: ConnectionStatus, +status: ConnectionStatus,
+keyserverID: string, +keyserverID: string,
}; };
export const setLateResponseActionType = 'SET_LATE_RESPONSE'; export const setLateResponseActionType = 'SET_LATE_RESPONSE';
export type SetLateResponsePayload = { export type SetLateResponsePayload = {
+messageID: number, +messageID: number,
+isLate: boolean, +isLate: boolean,
+keyserverID: string,
}; };
export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR'; export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR';
export type UpdateDisconnectedBarPayload = { +visible: boolean }; export type UpdateDisconnectedBarPayload = {
+visible: boolean,
+keyserverID: string,
};
export type OneTimeKeyGenerator = (inc: number) => string; export type OneTimeKeyGenerator = (inc: number) => string;
export type GRPCStream = { export type GRPCStream = {
readyState: number, readyState: number,
onopen: (ev: any) => mixed, onopen: (ev: any) => mixed,
onmessage: (ev: MessageEvent) => mixed, onmessage: (ev: MessageEvent) => mixed,
onclose: (ev: CloseEvent) => mixed, onclose: (ev: CloseEvent) => mixed,
close(code?: number, reason?: string): void, close(code?: number, reason?: string): void,
send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void, send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void,
}; };
export type CommTransportLayer = GRPCStream | WebSocket; export type CommTransportLayer = GRPCStream | WebSocket;
View Options

lib/components/qr-auth-provider.react.js

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Linesexport type UpdateConnectionStatusPayload = {
+status: ConnectionStatus, +status: ConnectionStatus,
+keyserverID: string, +keyserverID: string,
}; };
export const setLateResponseActionType = 'SET_LATE_RESPONSE'; export const setLateResponseActionType = 'SET_LATE_RESPONSE';
export type SetLateResponsePayload = { export type SetLateResponsePayload = {
+messageID: number, +messageID: number,
+isLate: boolean, +isLate: boolean,
+keyserverID: string,
}; };
export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR'; export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR';
export type UpdateDisconnectedBarPayload = { +visible: boolean }; export type UpdateDisconnectedBarPayload = {
+visible: boolean,
+keyserverID: string,
};
export type OneTimeKeyGenerator = (inc: number) => string; export type OneTimeKeyGenerator = (inc: number) => string;
export type GRPCStream = { export type GRPCStream = {
readyState: number, readyState: number,
onopen: (ev: any) => mixed, onopen: (ev: any) => mixed,
onmessage: (ev: MessageEvent) => mixed, onmessage: (ev: MessageEvent) => mixed,
onclose: (ev: CloseEvent) => mixed, onclose: (ev: CloseEvent) => mixed,
close(code?: number, reason?: string): void, close(code?: number, reason?: string): void,
send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void, send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void,
}; };
export type CommTransportLayer = GRPCStream | WebSocket; export type CommTransportLayer = GRPCStream | WebSocket;
View Options

lib/types/tunnelbroker/qr-code-auth-message-types.js

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Linesexport type UpdateConnectionStatusPayload = {
+status: ConnectionStatus, +status: ConnectionStatus,
+keyserverID: string, +keyserverID: string,
}; };
export const setLateResponseActionType = 'SET_LATE_RESPONSE'; export const setLateResponseActionType = 'SET_LATE_RESPONSE';
export type SetLateResponsePayload = { export type SetLateResponsePayload = {
+messageID: number, +messageID: number,
+isLate: boolean, +isLate: boolean,
+keyserverID: string,
}; };
export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR'; export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR';
export type UpdateDisconnectedBarPayload = { +visible: boolean }; export type UpdateDisconnectedBarPayload = {
+visible: boolean,
+keyserverID: string,
};
export type OneTimeKeyGenerator = (inc: number) => string; export type OneTimeKeyGenerator = (inc: number) => string;
export type GRPCStream = { export type GRPCStream = {
readyState: number, readyState: number,
onopen: (ev: any) => mixed, onopen: (ev: any) => mixed,
onmessage: (ev: MessageEvent) => mixed, onmessage: (ev: MessageEvent) => mixed,
onclose: (ev: CloseEvent) => mixed, onclose: (ev: CloseEvent) => mixed,
close(code?: number, reason?: string): void, close(code?: number, reason?: string): void,
send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void, send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void,
}; };
export type CommTransportLayer = GRPCStream | WebSocket; export type CommTransportLayer = GRPCStream | WebSocket;
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 Linesexport type UpdateConnectionStatusPayload = {
+status: ConnectionStatus, +status: ConnectionStatus,
+keyserverID: string, +keyserverID: string,
}; };
export const setLateResponseActionType = 'SET_LATE_RESPONSE'; export const setLateResponseActionType = 'SET_LATE_RESPONSE';
export type SetLateResponsePayload = { export type SetLateResponsePayload = {
+messageID: number, +messageID: number,
+isLate: boolean, +isLate: boolean,
+keyserverID: string,
}; };
export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR'; export const updateDisconnectedBarActionType = 'UPDATE_DISCONNECTED_BAR';
export type UpdateDisconnectedBarPayload = { +visible: boolean }; export type UpdateDisconnectedBarPayload = {
+visible: boolean,
+keyserverID: string,
};
export type OneTimeKeyGenerator = (inc: number) => string; export type OneTimeKeyGenerator = (inc: number) => string;
export type GRPCStream = { export type GRPCStream = {
readyState: number, readyState: number,
onopen: (ev: any) => mixed, onopen: (ev: any) => mixed,
onmessage: (ev: MessageEvent) => mixed, onmessage: (ev: MessageEvent) => mixed,
onclose: (ev: CloseEvent) => mixed, onclose: (ev: CloseEvent) => mixed,
close(code?: number, reason?: string): void, close(code?: number, reason?: string): void,
send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void, send(data: string | Blob | ArrayBuffer | $ArrayBufferView): void,
}; };
export type CommTransportLayer = GRPCStream | WebSocket; export type CommTransportLayer = GRPCStream | WebSocket;