Page MenuHomePhabricator
Differential D14002

[CommCoreModule] avoid calling Backup Service to get backup secrets
ClosedPublic
Actions

Authored by kamil on Nov 22 2024, 2:23 AM.
Tags
None
Referenced Files
F3521251: D14002.id.diff
Mon, Dec 23, 2:46 AM
Unknown Object (File)
Tue, Dec 17, 10:39 PM
Unknown Object (File)
Sat, Dec 14, 2:25 PM
Unknown Object (File)
Fri, Dec 13, 8:39 PM
Unknown Object (File)
Fri, Dec 13, 1:47 AM
Unknown Object (File)
Mon, Dec 9, 10:40 PM
Unknown Object (File)
Sat, Dec 7, 9:26 PM
Unknown Object (File)
Sat, Dec 7, 3:10 PM
View All 22 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMf209543987d5: [CommCoreModule] avoid calling Backup Service to get backup secrets
Summary

Part of ENG-9656

It was identified in https://phab.comm.dev/D13849#387643.

We don't need to call the Backup Service, we have the data locally.

retrieveBackupKeys will be refactored later in the stack and used in the Restore protocol to fetch the User Keys from the backup service.

Depends on D14001

Test Plan

Tested creating backup and secondary device login

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 22 2024, 2:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 22 2024, 2:23 AM
kamil updated this revision to Diff 45942.Nov 22 2024, 2:48 AM

rebase

kamil added a child revision: D14003: [native] remove `BackupKeys` and use `QRAuthBackupData`.Nov 22 2024, 2:52 AM
Harbormaster failed remote builds in B32763: Diff 45939!Nov 22 2024, 3:01 AM
Harbormaster completed remote builds in B32766: Diff 45942.Nov 22 2024, 3:22 AM
kamil edited the summary of this revision. (Show Details)Nov 22 2024, 3:56 AM
kamil added inline comments.Nov 22 2024, 3:59 AM
native/profile/secondary-device-qr-code-scanner.react.js
180–182

Previously we had validation because we received a string, which was downloaded from the Blob service and decrypted. Right now we have a JSI object so there is need to validate this.

kamil published this revision for review.Nov 22 2024, 4:00 AM
bartek accepted this revision.Tue, Nov 26, 1:30 AM
This revision is now accepted and ready to land.Tue, Nov 26, 1:30 AM
Closed by commit rCOMMf209543987d5: [CommCoreModule] avoid calling Backup Service to get backup secrets (authored by kamil). · Explain WhyTue, Dec 3, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf209543987d5: [CommCoreModule] avoid calling Backup Service to get backup secrets.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
5 lines
68 lines
_generated/
profile/
24 lines
schema/
7 lines

Diff 45942

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...