Differential D13967

[lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created
ClosedPublic
Actions

Authored by kamil on Nov 19 2024, 4:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 7, 10:44 PM

	Unknown Object (File)
	Thu, Apr 3, 8:45 AM

	Unknown Object (File)
	Wed, Apr 2, 11:13 PM

	Unknown Object (File)
	Wed, Apr 2, 2:58 PM

	Unknown Object (File)
	Sat, Mar 29, 8:01 PM

	Unknown Object (File)
	Fri, Mar 28, 1:42 AM

	Unknown Object (File)
	Sun, Mar 23, 1:00 PM

	Unknown Object (File)
	Sat, Mar 22, 6:54 PM

View All 55 Files

Subscribers

Details

Reviewers

bartek
tomek
varun

Commits

rCOMM9c6874a3c9f5: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created

Summary

This a fix for ENG-9844, why this is an issue is explained here.

Depends on D13966

Test Plan

Make sure secondary device auth is not glitchy anymore

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 19 2024, 4:17 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 19 2024, 4:17 AM

kamil added a child revision: D13968: [native] avoid showing SIWE backup message screen for non-primary devices.Nov 19 2024, 4:23 AM

kamil published this revision for review.Nov 19 2024, 4:27 AM

Harbormaster completed remote builds in B32713: Diff 45883.Nov 19 2024, 4:34 AM

Nice

This revision is now accepted and ready to land.Nov 20 2024, 6:42 AM

Closed by commit rCOMM9c6874a3c9f5: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created (authored by kamil). · Explain WhyNov 25 2024, 4:06 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9c6874a3c9f5: [lib] ignore `DEVICE_LIST_UPDATE_SUCCESS` when auth connection is created.

Revision Contents
Changeset List

Path

Size

lib/

components/

qr-auth-provider.react.js

4 lines

Diff 46004

lib/components/qr-auth-provider.react.js

	Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
	}			}

	// Get messages from devices			// Get messages from devices

	message GetRequest {			message GetRequest {
	string sessionID = 1;			string sessionID = 1;
	}			}

	message GetResponse {			message GetResponseMessage {
	string fromDeviceID = 1;			string fromDeviceID = 1;
	bytes payload = 2;			bytes payload = 2;
	repeated string blobHashes = 3;			repeated string blobHashes = 3;
	}			}

				message GetResponse {
				oneof data {
				GetResponseMessage responseMessage = 1;
				google.protobuf.Empty ping = 2;
				}
				}

	// Common messages structures for the MessagesStream			// Common messages structures for the MessagesStream

	message ProcessedMessages {			message ProcessedMessages {
	repeated string messageID = 1;			repeated string messageID = 1;
	}			}

	// The messages from the Client to the Tunnelbroker			// The messages from the Client to the Tunnelbroker

	▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines