Page MenuHomePhabricator
Differential D14056

[native] enable backup handler for staff
AcceptedPublic
Actions

Authored by kamil on Wed, Nov 27, 6:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
Unknown Object (File)
Wed, Nov 27, 3:26 PM
View All 12 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

Part of ENG-9604 but only for staff.

Starting Rust thread responsible for uploading Backup. Right now it will be used to upload User Keys only, but in the future, it will be used for User Data and logs.

Adding an alert to log if anything went wrong.

Depends on D14048, D14050

Test Plan

Add additional log to make sure if this is started or not, test it with iOS and Android (background/foreground/background).

Diff Detail

Repository
rCOMM Comm
Branch
backup-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Nov 27, 6:44 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Nov 27, 6:44 AM
kamil updated this revision to Diff 46101.Wed, Nov 27, 9:35 AM

add check if device is primary

kamil added a parent revision: D14058: [lib] create a hook to check if device is primary.Wed, Nov 27, 9:36 AM
kamil added a child revision: D14059: [native] upload User Keys backup when user is staff.Wed, Nov 27, 9:42 AM
Harbormaster completed remote builds in B32886: Diff 46101.Wed, Nov 27, 9:55 AM
kamil published this revision for review.Wed, Nov 27, 10:18 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.
native/backup/backup-handler.js
23–58

Identification changes later in the stack

ashoat added inline comments.Wed, Nov 27, 3:06 PM
native/backup/backup-handler.js
39

Should we only display this alert to staff?

47

Same here

kamil added inline comments.Thu, Nov 28, 1:19 AM
native/backup/backup-handler.js
39

This code won't be ever executed for non-staff users, it's gated on staffCanSee (see line 24). But I can use useStaffAlert here to point out that this is staff-specific

bartek accepted this revision.Fri, Nov 29, 2:55 AM
bartek added inline comments.
native/backup/backup-handler.js
39

By looking at the difference between useStaffCanSee and useIsCurrentUserStaff, the latter has a check for isDev too, and so does the useStaffAlert. Shouldn't we de-dupe them somehow?

This revision is now accepted and ready to land.Fri, Nov 29, 2:55 AM
bartek mentioned this in D14059: [native] upload User Keys backup when user is staff.Fri, Nov 29, 2:56 AM

Revision Contents
Changeset List

PathSize
native/
backup/
49 lines

Diff 46101

View Options

native/backup/backup-handler.js

Loading...