Page MenuHomePhabricator
Differential D14065

[native] regenerate backup on every password change
ClosedPublic
Actions

Authored by kamil on Nov 28 2024, 6:23 AM.
Tags
None
Referenced Files
F3744017: D14065.id46205.diff
Thu, Jan 9, 2:56 PM
F3744016: D14065.id46186.diff
Thu, Jan 9, 2:56 PM
F3744015: D14065.id46109.diff
Thu, Jan 9, 2:56 PM
F3744014: D14065.id46181.diff
Thu, Jan 9, 2:56 PM
F3744000: D14065.diff
Thu, Jan 9, 2:55 PM
Unknown Object (File)
Mon, Jan 6, 4:53 PM
Unknown Object (File)
Tue, Dec 31, 8:24 AM
Unknown Object (File)
Mon, Dec 30, 1:59 PM
View All 43 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM863c17c11b6c: [native] regenerate backup on every password change
Summary

ENG-8070

Some concerns are listed the comment in ENG-8070.

Depends on D14063

Test Plan

On primary device, change password and check that new backup was uploaded

Diff Detail

Repository
rCOMM Comm
Branch
backup-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 28 2024, 6:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2024, 6:23 AM
kamil edited the summary of this revision. (Show Details)Nov 28 2024, 6:25 AM
kamil added inline comments.
native/backup/backup-handler.js
149

This should be added to diff earlier in the stack, I am going to fix this in next rebase

Harbormaster completed remote builds in B32893: Diff 46109.Nov 28 2024, 6:41 AM
kamil published this revision for review.Nov 28 2024, 9:10 AM
bartek accepted this revision.Dec 3 2024, 12:29 AM
This revision is now accepted and ready to land.Dec 3 2024, 12:29 AM
kamil updated this revision to Diff 46181.Dec 3 2024, 4:24 AM

rebase before landing

Harbormaster failed remote builds in B32920: Diff 46181!Dec 3 2024, 4:38 AM
kamil updated this revision to Diff 46186.Dec 3 2024, 5:31 AM

rebase before landing v2

Harbormaster completed remote builds in B32922: Diff 46186.Dec 3 2024, 5:58 AM
Closed by commit rCOMM863c17c11b6c: [native] regenerate backup on every password change (authored by kamil). · Explain WhyDec 3 2024, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM863c17c11b6c: [native] regenerate backup on every password change.

Revision Contents
Changeset List

PathSize
lib/
reducers/
5 lines
native/
backup/
1 line

Diff 46109

View Options

lib/reducers/backup-reducer.js

Loading...
View Options

native/backup/backup-handler.js

Loading...