Page MenuHomePhabricator
Differential D14065

[native] regenerate backup on every password change
ClosedPublic
Actions

Authored by kamil on Nov 28 2024, 6:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 25, 12:36 AM
Unknown Object (File)
Wed, Apr 23, 4:15 PM
Unknown Object (File)
Wed, Apr 23, 1:09 PM
Unknown Object (File)
Wed, Apr 23, 12:19 PM
Unknown Object (File)
Wed, Apr 23, 8:52 AM
Unknown Object (File)
Wed, Apr 23, 2:34 AM
Unknown Object (File)
Mon, Apr 21, 9:44 PM
Unknown Object (File)
Mar 20 2025, 9:28 AM
View All 63 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM863c17c11b6c: [native] regenerate backup on every password change
Summary

ENG-8070

Some concerns are listed the comment in ENG-8070.

Depends on D14063

Test Plan

On primary device, change password and check that new backup was uploaded

Diff Detail

Repository
rCOMM Comm
Branch
backup-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 28 2024, 6:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2024, 6:23 AM
kamil edited the summary of this revision. (Show Details)Nov 28 2024, 6:25 AM
kamil added inline comments.
native/backup/backup-handler.js
149

This should be added to diff earlier in the stack, I am going to fix this in next rebase

Harbormaster completed remote builds in B32893: Diff 46109.Nov 28 2024, 6:41 AM
kamil published this revision for review.Nov 28 2024, 9:10 AM
bartek accepted this revision.Dec 3 2024, 12:29 AM
This revision is now accepted and ready to land.Dec 3 2024, 12:29 AM
kamil updated this revision to Diff 46181.Dec 3 2024, 4:24 AM

rebase before landing

Harbormaster failed remote builds in B32920: Diff 46181!Dec 3 2024, 4:38 AM
kamil updated this revision to Diff 46186.Dec 3 2024, 5:31 AM

rebase before landing v2

Harbormaster completed remote builds in B32922: Diff 46186.Dec 3 2024, 5:58 AM
Closed by commit rCOMM863c17c11b6c: [native] regenerate backup on every password change (authored by kamil). · Explain WhyDec 3 2024, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM863c17c11b6c: [native] regenerate backup on every password change.

Revision Contents
Changeset List

PathSize
lib/
reducers/
5 lines
native/
backup/
1 line

Diff 46109

View Options

lib/reducers/backup-reducer.js

Show All 20 Lines
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import MenuItem from '../components/menu-item.react'; import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react'; import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react'; import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react'; import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react'; import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react'; import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react'; import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react'; import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines return (
text="Leave Thread" text="Leave Thread"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo]);
const onClickPromoteSidebarToThread = React.useCallback(
() =>
pushModal(
<SidebarPromoteModal
threadInfo={threadInfo}
onClose={popModal}
onConfirm={onPromoteSidebar}
/>,
),
[pushModal, threadInfo, popModal, onPromoteSidebar],
);
const promoteSidebar = React.useMemo(() => { const promoteSidebar = React.useMemo(() => {
return ( return (
<MenuItem <MenuItem
key="promote" key="promote"
text="Promote Thread" text="Promote Thread"
icon="message-square-lines" icon="message-square-lines"
onClick={onPromoteSidebar} onClick={onClickPromoteSidebarToThread}
/> />
); );
}, [onPromoteSidebar]); }, [onClickPromoteSidebarToThread]);
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(() => {
const notificationsItem = ( const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" /> <MenuItem key="notifications" text="Notifications" icon="bell" />
); );
const separator = <hr key="separator" className={css.separator} />; const separator = <hr key="separator" className={css.separator} />;
// TODO: Enable menu items when the modals are implemented // TODO: Enable menu items when the modals are implemented
Show All 33 Lines
View Options

native/backup/backup-handler.js

Show All 20 Lines
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import MenuItem from '../components/menu-item.react'; import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react'; import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react'; import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react'; import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react'; import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react'; import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react'; import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react'; import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines return (
text="Leave Thread" text="Leave Thread"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo]);
const onClickPromoteSidebarToThread = React.useCallback(
() =>
pushModal(
<SidebarPromoteModal
threadInfo={threadInfo}
onClose={popModal}
onConfirm={onPromoteSidebar}
/>,
),
[pushModal, threadInfo, popModal, onPromoteSidebar],
);
const promoteSidebar = React.useMemo(() => { const promoteSidebar = React.useMemo(() => {
return ( return (
<MenuItem <MenuItem
key="promote" key="promote"
text="Promote Thread" text="Promote Thread"
icon="message-square-lines" icon="message-square-lines"
onClick={onPromoteSidebar} onClick={onClickPromoteSidebarToThread}
/> />
); );
}, [onPromoteSidebar]); }, [onClickPromoteSidebarToThread]);
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(() => {
const notificationsItem = ( const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" /> <MenuItem key="notifications" text="Notifications" icon="bell" />
); );
const separator = <hr key="separator" className={css.separator} />; const separator = <hr key="separator" className={css.separator} />;
// TODO: Enable menu items when the modals are implemented // TODO: Enable menu items when the modals are implemented
Show All 33 Lines