Page MenuHomePhabricator
Differential D14059

[native] upload User Keys backup when user is staff
ClosedPublic
Actions

Authored by kamil on Wed, Nov 27, 9:42 AM.
Tags
None
Referenced Files
F3514352: D14059.diff
Sun, Dec 22, 4:26 AM
Unknown Object (File)
Tue, Dec 17, 9:02 PM
Unknown Object (File)
Sun, Dec 15, 9:00 AM
Unknown Object (File)
Tue, Dec 10, 5:45 AM
Unknown Object (File)
Tue, Dec 10, 4:40 AM
Unknown Object (File)
Thu, Dec 5, 1:11 PM
Unknown Object (File)
Wed, Dec 4, 8:37 AM
Unknown Object (File)
Tue, Dec 3, 8:16 PM
View All 25 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM6340aabf2ad2: [native] upload User Keys backup when user is staff
Summary

Part of ENG-9604 but only for staff.

This is also needed for ENG-9711.

Depends on D14056

Test Plan
  1. Check if backup is uploaded when user has no backup
  2. Log out/in and check if backup is uploaded

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Nov 27, 9:42 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Nov 27, 9:42 AM
kamil added a child revision: D14060: [native] add handler for staff to attempt backup restore.Wed, Nov 27, 9:45 AM
Harbormaster completed remote builds in B32887: Diff 46102.Wed, Nov 27, 9:59 AM
kamil published this revision for review.Wed, Nov 27, 10:22 AM
kamil added inline comments.
native/backup/backup-handler.js
57 ↗(On Diff #46102)
97–98 ↗(On Diff #46102)

dispatchActionPromise is swallowing errors, this is to avoid that

ashoat added inline comments.Wed, Nov 27, 3:09 PM
native/backup/backup-handler.js
101 ↗(On Diff #46102)

Should we only show this alert to staff?

bartek accepted this revision.Fri, Nov 29, 2:56 AM
bartek added inline comments.
native/backup/backup-handler.js
101 ↗(On Diff #46102)

Looks like it's the same as in https://phab.comm.dev/D14056#inline-78946 - it's gated on staffCanSee

This revision is now accepted and ready to land.Fri, Nov 29, 2:56 AM
kamil updated this revision to Diff 46179.Tue, Dec 3, 4:17 AM
  • rebase
  • use useStaffAlert
Harbormaster completed remote builds in B32918: Diff 46179.Tue, Dec 3, 5:18 AM
Closed by commit rCOMM6340aabf2ad2: [native] upload User Keys backup when user is staff (authored by kamil). · Explain WhyTue, Dec 3, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6340aabf2ad2: [native] upload User Keys backup when user is staff.

Revision Contents
Changeset List

PathSize
native/
backup/
70 lines

Diff 46179

View Options

native/backup/backup-handler.js

Loading...