[SQLite] move `backedUpTablesAllowlist` to separate file
ClosedPublic
Actions

Authored by kamil on May 8 2025, 10:30 AM.

Details

Reviewers

bartek
tomek
angelika

Commits

rCOMM04bdcf89ef80: [SQLite] move `backedUpTablesAllowlist` to separate file

Summary

Implemented as part of ENG-10603

In the next diff, this is needed in more files, it is more convenient to move as a constant to a better place than pass as a parameter in multiple methods.

Depends on D14660

Test Plan

Build app

Diff Detail

Repository

rCOMM Comm

Branch

publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 8 2025, 10:30 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2025, 10:30 AM

kamil edited the summary of this revision. (Show Details)May 8 2025, 10:31 AM

kamil added a child revision: D14662: [SQLite] remove `initializeTablesForLogMonitoring` method.May 8 2025, 10:33 AM

Harbormaster completed remote builds in B34103: Diff 47967.May 8 2025, 10:48 AM

kamil published this revision for review.May 8 2025, 10:57 AM

bartek accepted this revision.May 9 2025, 9:25 AM

This revision is now accepted and ready to land.May 9 2025, 9:25 AM

rebase

Harbormaster completed remote builds in B34196: Diff 48127.May 20 2025, 11:17 AM

Closed by commit rCOMM04bdcf89ef80: [SQLite] move `backedUpTablesAllowlist` to separate file. · Explain WhyMay 20 2025, 11:38 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM04bdcf89ef80: [SQLite] move `backedUpTablesAllowlist` to separate file.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

CMakeLists.txt

2 lines

SQLiteBackup.h

11 lines

SQLiteBackup.cpp

18 lines

SQLiteQueryExecutor.h

2 lines

SQLiteQueryExecutor.cpp

23 lines

ios/

Comm.xcodeproj/

project.pbxproj

6 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

1 line

shared-worker/

_generated/

comm_query_executor.wasm

Diff 48127

View Options

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/ios/Comm.xcodeproj/project.pbxproj

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

[SQLite] move `backedUpTablesAllowlist` to separate fileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48127

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.cpp

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/ios/Comm.xcodeproj/project.pbxproj

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

[SQLite] move `backedUpTablesAllowlist` to separate file
ClosedPublic
Actions

Revision Contents
Changeset List