Page MenuHomePhorge
Feed Search

Jul 20 2022

karol closed D4549: [services] Backup - fix formatting.
Jul 20 2022, 11:42 AM
karol committed rCOMM99e5e2b9a863: [services] Backup - fix formatting.
Jul 20 2022, 11:42 AM
karol updated the diff for D4582: [services] Tests - Add PUT for Blob performance tests.

remove log line

Jul 20 2022, 11:39 AM
karol planned changes to D4582: [services] Tests - Add PUT for Blob performance tests.
Jul 20 2022, 11:39 AM
karol requested review of D4582: [services] Tests - Add PUT for Blob performance tests.
Jul 20 2022, 11:36 AM
karol added inline comments to D4581: [services] Tests - Add performance tests base for Blob.
Jul 20 2022, 11:32 AM
karol requested review of D4581: [services] Tests - Add performance tests base for Blob.
Jul 20 2022, 11:30 AM
karol requested review of D4579: [services] Tests - Refactor integration tests.
Jul 20 2022, 11:26 AM
karol requested review of D4580: [services] Tests - Add performance tests base.
Jul 20 2022, 11:26 AM
karol closed D4375: [services] Build arm containers for m1 mac.
Jul 20 2022, 11:09 AM
karol committed rCOMM32ed95a79ff9: [services] Build arm containers for m1 mac.
Jul 20 2022, 11:09 AM
karol updated the diff for D4375: [services] Build arm containers for m1 mac.

nits

Jul 20 2022, 11:08 AM
karol added a comment to D4375: [services] Build arm containers for m1 mac.

Thanks @karol-bisztyga, my apologies... I simply wasn't paying enough attention.

Some nits inline – please address before landing!

Jul 20 2022, 11:08 AM
karol updated the diff for D4554: [services] Backup - send log - add case for DB.

update error message

Jul 20 2022, 11:05 AM
karol updated the summary of D4554: [services] Backup - send log - add case for DB.
Jul 20 2022, 11:04 AM
karol added a comment to D4554: [services] Backup - send log - add case for DB.
In D4554#130404, @palys-swm wrote:

We want to handle a situation when we save the records in the database (it didn't work in the tests).

Could you explain it a little more? How would we want to handle it? What do you mean by that it didn't work in the test?

Jul 20 2022, 11:04 AM

Jul 19 2022

karol closed D4223: [services] Backup - Fix terminate callback in pull backup reactor.
Jul 19 2022, 10:16 AM
karol committed rCOMMccd926274f68: [services] Backup - Fix terminate callback in pull backup reactor.
Jul 19 2022, 10:16 AM
karol accepted D4513: [services] Tunnelbroker - Change in `getAwsRegion()` function to use `.aws/credentials`.
Jul 19 2022, 9:21 AM
karol accepted D4476: [services] Tunnelbroker - Database function that removes messages by a batch using messageIDs and receiver DeviceID..
Jul 19 2022, 9:19 AM
karol accepted D4473: [services] Tunnelbroker - Switching to use composite key in a messages table in Terraform.
Jul 19 2022, 9:17 AM
karol updated the summary of D4438: [services] Backup - pull attachment holders out of the data section.
Jul 19 2022, 9:05 AM
karol accepted D4563: [identity] db method to add username to users table in ddb.
Jul 19 2022, 9:04 AM
karol accepted D4561: [services] use client update_item method instead of put_item for registration data.
Jul 19 2022, 9:04 AM
karol accepted D4562: [services] helper to update the users table.
Jul 19 2022, 8:58 AM
karol accepted D4559: [services] rename registration table to users table.
Jul 19 2022, 8:57 AM
karol updated the diff for D4223: [services] Backup - Fix terminate callback in pull backup reactor.

rebase

Jul 19 2022, 8:44 AM
karol requested review of D4571: [services] Backup - Add helper method for extra data.
Jul 19 2022, 8:40 AM
karol added inline comments to D4223: [services] Backup - Fix terminate callback in pull backup reactor.
Jul 19 2022, 8:36 AM
karol updated the diff for D4555: [services] Backup - pull backup - change logic to use att holders out of data section.

rebase

Jul 19 2022, 8:31 AM
karol updated the summary of D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
Jul 19 2022, 8:30 AM
karol requested review of D4375: [services] Build arm containers for m1 mac.

Correct me if I'm wrong but I think my question still hasn't been responded to?

Jul 19 2022, 8:12 AM

Jul 18 2022

karol requested review of D4556: [services] Backup - pull backup - change tests.
Jul 18 2022, 2:24 PM
karol requested review of D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
Jul 18 2022, 2:18 PM
karol requested review of D4554: [services] Backup - send log - add case for DB.
Jul 18 2022, 2:13 PM
karol abandoned D4442: [services] Tests - Backup - Adjust the logic.
Jul 18 2022, 2:02 PM
karol abandoned D4440: [services] Backup - Add extra bytes needed to the blob client.
Jul 18 2022, 2:02 PM
karol abandoned D4439: [services] Blob - Add extra bytes needed to get request.
Jul 18 2022, 2:01 PM
karol updated the diff for D4438: [services] Backup - pull attachment holders out of the data section.

empty

Jul 18 2022, 1:59 PM
karol requested changes to D4543: [services] Backup - Add unit test for getUtf8Length.
Jul 18 2022, 9:09 AM
karol accepted D4544: [services] Backup - Add function to get utf8 string length.
Jul 18 2022, 9:01 AM
karol accepted D4505: [services] Backup - Add function to get utf8 string length.

Looks ok, personally, I'd try to do this without pointers but it probably doesn't matter.

Jul 18 2022, 8:53 AM
karol requested review of D4549: [services] Backup - fix formatting.
Jul 18 2022, 8:33 AM
karol accepted D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 18 2022, 8:27 AM
karol accepted D4503: [services] Backup - Fix missing hash in unit tests.
Jul 18 2022, 8:26 AM
karol accepted D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 18 2022, 8:26 AM
karol added a comment to D4375: [services] Build arm containers for m1 mac.

After I've removed it all completely and the base image is downloaded from the hub, now I have that warning badge about architecture.

Jul 18 2022, 8:13 AM
karol updated the diff for D4375: [services] Build arm containers for m1 mac.

add buildx note to the docs

Jul 18 2022, 8:12 AM

Jul 12 2022

karol added a comment to D4439: [services] Blob - Add extra bytes needed to get request.

Ok, I still think that the 3rd option is the best but since I'm outvoted, I'm going to go with option number 2. Option 1 seems like a quick fix and I don't think that in the end, it delivers an efficient solution.

Jul 12 2022, 9:46 AM
karol added a comment to D4375: [services] Build arm containers for m1 mac.

Thx @geekbrother
My suspicion is still that you've built the base image locally.
could you remove the base image and rebuild the tunnelbroker image?
the best way of doing this would be to just clean up the docker completely and run tunnelbroker start
the goal is to see that the base image is being downloaded from the hub

Jul 12 2022, 9:20 AM
karol updated the diff for D4375: [services] Build arm containers for m1 mac.

use buildx

Jul 12 2022, 9:16 AM

Jul 11 2022

karol planned changes to D4375: [services] Build arm containers for m1 mac.

@geekbrother could you please share a screenshot of the "images" tab in the docker desktop app? I requested this here and also pinged you on the Comm app:

Jul 11 2022, 1:30 PM
karol updated the diff for D4375: [services] Build arm containers for m1 mac.

rebase + apply for unit tests

Jul 11 2022, 1:30 PM
karol accepted D4460: [services] wrap database client in Arc to avoid creating a new client each time we clone.
Jul 11 2022, 11:14 AM
karol accepted D4373: [services] Inner function to write to DynamoDB by batch.
Jul 11 2022, 11:11 AM
karol requested changes to D4476: [services] Tunnelbroker - Database function that removes messages by a batch using messageIDs and receiver DeviceID..

Please fix the typo in this diff's title:

[services] Tunnelbroker - Database function that removes messages in a batch using the composite key and batchWrite
Jul 11 2022, 10:34 AM
karol accepted D4378: [services] Tunnelbroker - Function to put message items to the database by batch.
Jul 11 2022, 10:24 AM
karol requested changes to D4478: [services] Tunnelbroker - Add test for `removeMessageItemsByIDsForDeviceID` database function.
Jul 11 2022, 10:16 AM
karol accepted D4475: [services] Tunnelbroker - Switching to use composite key in a messageItem entity.
Jul 11 2022, 10:08 AM
karol requested changes to D4473: [services] Tunnelbroker - Switching to use composite key in a messages table in Terraform.

Shouldn't we also modify the entity files? I'd put the fields in this file (especially in the constructor) in the correct order which would be:

Jul 11 2022, 10:07 AM
karol accepted D4436: [services] Tunnelbroker - Add exponential backoff related constants.
Jul 11 2022, 9:56 AM
karol accepted D4372: [services] Tunnelbroker - Add DYNAMODB_MAX_BATCH_ITEMS to Constants.
Jul 11 2022, 9:54 AM
karol added inline comments to D4373: [services] Inner function to write to DynamoDB by batch.
Jul 11 2022, 9:53 AM
karol added inline comments to D4373: [services] Inner function to write to DynamoDB by batch.
Jul 11 2022, 9:48 AM

Jul 8 2022

karol updated the diff for D4438: [services] Backup - pull attachment holders out of the data section.

retrigger CI/request review

Jul 8 2022, 9:31 AM
karol closed D4437: [services] Add reset local cloud command.
Jul 8 2022, 9:31 AM
karol closed D4425: [services] Tests - Use lazy static instead of functions.
Jul 8 2022, 9:31 AM
karol closed D4413: [services] Tests - run cargo fmt.
Jul 8 2022, 9:31 AM
karol committed rCOMM35a558505000: [services] Add reset local cloud command.
Jul 8 2022, 9:31 AM
karol committed rCOMM4d5e74a9f80d: [services] Tests - Use lazy static instead of functions.
Jul 8 2022, 9:31 AM
karol closed D4379: [services] Tests - Read port from the env vars.
Jul 8 2022, 9:31 AM
karol closed D4341: [services] Backup - Pull Backup - Wait for the get reactor to terminate.
Jul 8 2022, 9:31 AM
karol committed rCOMM68aa78321a3c: [services] Tests - run cargo fmt.
Jul 8 2022, 9:31 AM
karol closed D4326: [services] Tests - Update backup test.
Jul 8 2022, 9:31 AM
karol committed rCOMM02dae1934da6: [services] Tests - Read port from the env vars.
Jul 8 2022, 9:31 AM
karol committed rCOMM5aa0124e6453: [services] Backup - Pull Backup - Wait for the get reactor to terminate.
Jul 8 2022, 9:31 AM
karol closed D4324: [services] Backup - Fix dynamoDB item size limit.
Jul 8 2022, 9:31 AM
karol committed rCOMM0348a8fba605: [services] Tests - Update backup test.
Jul 8 2022, 9:31 AM
karol closed D4323: [services] Backup - Update add attachments logic.
Jul 8 2022, 9:31 AM
karol closed D4322: [services] Backup - Add data hash to database manager.
Jul 8 2022, 9:31 AM
karol committed rCOMMd9e41f608557: [services] Backup - Fix dynamoDB item size limit.
Jul 8 2022, 9:31 AM
karol committed rCOMM195b897c1f35: [services] Backup - Update add attachments logic.
Jul 8 2022, 9:31 AM
karol committed rCOMM764dee263ce7: [services] Backup - Add data hash to database manager.
Jul 8 2022, 9:30 AM
karol closed D4412: [services] Backup - Send Log - Check the real item size.
Jul 8 2022, 9:30 AM
karol closed D4321: [services] Backup - Send Log - Fix logic in terminate callback.
Jul 8 2022, 9:30 AM
karol closed D4411: [services] Backup - Send Log - Use separate variables for value and blob holder.
Jul 8 2022, 9:30 AM
karol committed rCOMMcc745f3bbc81: [services] Backup - Send Log - Check the real item size.
Jul 8 2022, 9:30 AM
karol committed rCOMM280facb88030: [services] Backup - Send Log - Use separate variables for value and blob holder.
Jul 8 2022, 9:30 AM
karol closed D4320: [services] Backup - Add data hash to the log item.
Jul 8 2022, 9:30 AM
karol committed rCOMM0e6c400235e8: [services] Backup - Send Log - Fix logic in terminate callback.
Jul 8 2022, 9:30 AM
karol closed D4277: [services] Tests - Blob - Add test logic.
Jul 8 2022, 9:30 AM
karol committed rCOMMa531a7b440e3: [services] Tests - Blob - Add test logic.
Jul 8 2022, 9:30 AM
karol closed D4276: [services] Tests - Blob - Add Remove.
Jul 8 2022, 9:30 AM
karol closed D4275: [services] Tests - Blob - Add Get.
Jul 8 2022, 9:30 AM
karol committed rCOMM2dc9d5f4c27b: [services] Backup - Add data hash to the log item.
Jul 8 2022, 9:30 AM
karol committed rCOMM02caf33e16fe: [services] Tests - Blob - Add Remove.
Jul 8 2022, 9:30 AM
karol closed D4274: [services] Tests - Blob - Add Put.
Jul 8 2022, 9:30 AM
karol committed rCOMM23ee43573ca0: [services] Tests - Blob - Add Get.
Jul 8 2022, 9:30 AM
karol closed D4273: [services] Tests - Blob - Add blob utils.
Jul 8 2022, 9:30 AM
karol committed rCOMM8810a366fdc6: [services] Tests - Blob - Add Put.
Jul 8 2022, 9:30 AM