rebase before landing

tweak padding

This change broke the CryptoTests (which should be added to Buildkite)

rebase before landing

rebase before landing

Should we use the same approach as native (iframe to login)? See Linear comment here

rebase before landing

varchar -> mediumtext

address feedback

rebase

rebase

rebase before landing

In D6135#183964, @ashoat wrote:

Accepting to unblock but I think this is too large for a VARCHAR column and you should use TEXT. Please either address before landing, or link a Linear task to address it before landing

rebase before landing

rebase before landing

rebase after addressing feedback

rebase after resolving merge conflicts

rebase before landing

In D6131#183954, @ashoat wrote:

Accepting to unblock, but in a less urgent context I would request changes. If you prefer, feel free to create (and link) a follow-up task to address before landing, but I feel strongly that we should just have one RegEx literal with a capture group instead of two separate RegEx literals

rebase before landing

rebase after addressing feedback and before landing

rebase before addressing feedback

rebase before landing

In D6152#184464, @ashoat wrote:

One potential concern would be if we have devs using direnv already (for whatever reason) – I could imagine this breaking their workflow until they run brew install bash and brew install direnv (which we don't want to happen). But arguably it's unlikely anybody is already using direnv?

In D6147#184458, @ashoat wrote:

native/ios/Comm/Info.release.plist needs to be configured as well – everyone please keep this in mind going forward when reviewing changes to plists!

In D6152#184448, @ashoat wrote:

There is an implicit requirement to brew install bash here, isn't there? I think we should hold off on this for now until @jon can take a look at ENG-2621, but open to landing it sooner if we think it won't cause any problems for anybody

In D6150#184381, @michal wrote:

Will the push trigger run after pr merge?

Adding @ashoat as first-pass reviewer because we're introducing nix-direnv dependency here: https://github.com/nix-community/nix-direnv

FYI you'll need to add @ashoat as a reviewer for dependency diffs:

Can you git pull --rebase and then run yarn cleaninstall in root and pod install in native/ios?

Build + run web app

We could introduce alternative workflows with flags like CODESIGNING=NO or whatever, but having the certificates and whatnot included helps surface issues as soon as they occur instead of when we make a release.

I'll put up a diff right now to cut them from the other workflows