Feed Search

Search
Use Results
Edit Query
Hide Query

Feb 24 2023

atul updated the diff for D6878: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm`.

newline

Feb 24 2023, 10:28 PM

atul added 1 blocking reviewer(s) for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise: atul.

Feb 24 2023, 10:09 PM

atul added 1 blocking reviewer(s) for D6634: [web] implement emoji keyboard position into message tooltip: atul.

Feb 24 2023, 10:01 PM

atul added inline comments to D6884: [web] "Unpickle" primary OLM account to sign keys and get `SignedIdentityKeysBlob`.

Feb 24 2023, 9:48 PM

atul added inline comments to D6884: [web] "Unpickle" primary OLM account to sign keys and get `SignedIdentityKeysBlob`.

Feb 24 2023, 9:41 PM

atul added inline comments to D6881: [web] Ensure that `[primary/notification]IdentityPublicKeys` are set in `TraditionalLoginForm`.

Feb 24 2023, 9:38 PM

atul added a comment to D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.

So instead of spinning our own solution now, we could probably just store in redux-persist for now.

Feb 24 2023, 9:37 PM

atul added a comment to D6876: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`.

In D6876#204358, @ashoat wrote:

Had a thought here – we should update our sanitization code to sanitize these public keys, as they are user-identifiable. Can you create a task for that and link here before landing? (Or a diff)

Feb 24 2023, 9:36 PM

atul accepted D6867: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override.

Feb 24 2023, 10:33 AM

atul accepted D6866: [keyserver] Check all new messages for @-mention notif override.

The scenario where multiple new messages are created at the same time with the same collapse key actually does not occur currently in the app. However, in one of the following diffs I will make SIDEBAR_SOURCE and CREATE_SIDEBAR share the same collapse key, and since they are created at the same time, it will be possible for a SIDEBAR_SOURCE to have an @-mention. If that occurs, the SIDEBAR_SOURCE will not be the first message, so we want to make sure we check all of the new messages with the same collapse key.

Feb 24 2023, 10:33 AM

atul added a comment to D6822: Sign concatenation of public and notif keypairs using private key of public identity.

Here's what the message/payload looks like on the web side:

Feb 24 2023, 10:28 AM

atul published D6884: [web] "Unpickle" primary OLM account to sign keys and get `SignedIdentityKeysBlob` for review.

Feb 24 2023, 10:23 AM

atul added a reviewer for D6883: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`: marcin.

Feb 24 2023, 10:22 AM

atul added a reviewer for D6882: [web] Add `PickledOLMAccount`s to Redux `CryptoStore`: marcin.

Feb 24 2023, 10:22 AM

atul added a reviewer for D6881: [web] Ensure that `[primary/notification]IdentityPublicKeys` are set in `TraditionalLoginForm`: marcin.

Feb 24 2023, 10:22 AM

atul added a reviewer for D6880: [web] Update `primaryIdentityPublicKey[s]` selector to capture `primaryIdentityPublicKeys`: marcin.

Feb 24 2023, 10:21 AM

atul added a reviewer for D6879: [web] Update `LoginForm` `useEffect` early-exit logic to include `notificationIdentityPublicKeys`: marcin.

Feb 24 2023, 10:21 AM

atul added a reviewer for D6878: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm`: marcin.

Feb 24 2023, 10:21 AM

atul added a reviewer for D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux: marcin.

Feb 24 2023, 10:21 AM

atul added a reviewer for D6876: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`: marcin.

Feb 24 2023, 10:21 AM

atul updated the test plan for D6883: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`.

Feb 24 2023, 8:46 AM

atul updated the test plan for D6883: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`.

Feb 24 2023, 8:45 AM

atul published D6883: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore` for review.

Feb 24 2023, 8:44 AM

atul published D6882: [web] Add `PickledOLMAccount`s to Redux `CryptoStore` for review.

Feb 24 2023, 8:29 AM

atul requested review of D6881: [web] Ensure that `[primary/notification]IdentityPublicKeys` are set in `TraditionalLoginForm`.

Feb 24 2023, 6:04 AM

atul requested review of D6880: [web] Update `primaryIdentityPublicKey[s]` selector to capture `primaryIdentityPublicKeys`.

Feb 24 2023, 3:35 AM

atul published D6879: [web] Update `LoginForm` `useEffect` early-exit logic to include `notificationIdentityPublicKeys` for review.

Feb 24 2023, 3:21 AM

atul published D6878: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm` for review.

Feb 24 2023, 2:59 AM

atul updated the summary of D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.

Feb 24 2023, 2:56 AM

Feb 23 2023

atul published D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux for review.

Feb 23 2023, 10:16 PM

atul published D6876: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys` for review.

Feb 23 2023, 10:15 PM

atul committed rCOMMc7146bcb2c27: [lib] Update `staff.js`.

Feb 23 2023, 1:49 AM

atul closed D6826: [lib] Require `primaryIdentityPublicKey` in `SIWEStatement`.

Feb 23 2023, 1:47 AM

atul committed rCOMMfe213e9f71eb: [lib] Require `primaryIdentityPublicKey` in `SIWEStatement`.

Feb 23 2023, 1:47 AM

atul updated the diff for D6826: [lib] Require `primaryIdentityPublicKey` in `SIWEStatement`.

rebase + land

Feb 23 2023, 1:42 AM

atul added a comment to D6836: [identity] add nonces table to dynamoDB.

The API will query for the nonce to see if it exists in the table. If it exists, it will succeed and delete the entry. If the nonce isn't in the table, the API will fail.

Feb 23 2023, 1:38 AM

Feb 22 2023

atul closed D6831: [native] Don't prompt SIWE users about keeping login info on logout.

Feb 22 2023, 10:59 PM

atul committed rCOMM9b18b40e786e: [native] Don't prompt SIWE users about keeping login info on logout.

Feb 22 2023, 10:59 PM

atul updated the diff for D6831: [native] Don't prompt SIWE users about keeping login info on logout.

rebase + land

Feb 22 2023, 10:59 PM

atul updated the test plan for D6831: [native] Don't prompt SIWE users about keeping login info on logout.

Feb 22 2023, 8:48 AM

atul accepted D6780: Refactor CommCoreModule.initializeCryptoAccount not to take userID as an argument..

FYI I think this might break the XCTest workflow on GitHub Actions. We might be able to rip out the failing tests if they're no longer relevant?

Feb 22 2023, 8:28 AM

atul closed D6828: [web] Change "Sign in" button colors to match designs.

Feb 22 2023, 8:27 AM

atul committed rCOMM2b5cc9dbafc0: [web] Change "Sign in" button colors to match designs.

Feb 22 2023, 8:27 AM

atul updated the diff for D6828: [web] Change "Sign in" button colors to match designs.

rebase + land

Feb 22 2023, 8:25 AM

atul added a comment to D6828: [web] Change "Sign in" button colors to match designs.

In D6828#202931, @ginsu wrote:

Can't see the color change visually, but code looks good

Feb 22 2023, 7:44 AM

atul updated the test plan for D6828: [web] Change "Sign in" button colors to match designs.

Feb 22 2023, 7:44 AM

atul published D6831: [native] Don't prompt SIWE users about keeping login info on logout for review.

Feb 22 2023, 7:37 AM

atul published D6828: [web] Change "Sign in" button colors to match designs for review.

Feb 22 2023, 6:36 AM

atul requested review of D6826: [lib] Require `primaryIdentityPublicKey` in `SIWEStatement`.

Feb 22 2023, 4:40 AM

atul closed D6655: [landing] Restyle `SIWE` to match `web`.

Feb 22 2023, 1:02 AM

atul committed rCOMMf71131a39819: [landing] Restyle `SIWE` to match `web`.

Feb 22 2023, 1:02 AM

atul updated the diff for D6655: [landing] Restyle `SIWE` to match `web`.

rebase + land

Feb 22 2023, 1:01 AM

atul closed D6652: [landing] Add `ConnectedWalletInfo` to native SIWE flow.

Feb 22 2023, 12:59 AM

atul committed rCOMM32d9731d845a: [landing] Add `ConnectedWalletInfo` to native SIWE flow.

Feb 22 2023, 12:59 AM

atul updated the diff for D6652: [landing] Add `ConnectedWalletInfo` to native SIWE flow.

rebase + land

Feb 22 2023, 12:59 AM

Feb 21 2023

atul added a comment to D6655: [landing] Restyle `SIWE` to match `web`.

Continues to look as it does in Test Plan:

Simulator Screen Shot - iPhone 14 Pro - 2023-02-21 at 01.20.50.png (2×1 px, 1 MB)

Feb 21 2023, 9:22 AM

atul updated the summary of D6655: [landing] Restyle `SIWE` to match `web`.

Feb 21 2023, 9:22 AM

atul updated the diff for D6655: [landing] Restyle `SIWE` to match `web`.

address feedback

Feb 21 2023, 9:21 AM

atul updated the test plan for D6652: [landing] Add `ConnectedWalletInfo` to native SIWE flow.

Feb 21 2023, 9:18 AM

atul updated the diff for D6652: [landing] Add `ConnectedWalletInfo` to native SIWE flow.

address feedback

Feb 21 2023, 9:17 AM

atul closed D6654: [landing] Wrap `SIWE` component with `WagmiENSCacheProvider`.

Feb 21 2023, 8:59 AM

atul committed rCOMM3ee3861025d8: [landing] Wrap `SIWE` component with `WagmiENSCacheProvider`.

Feb 21 2023, 8:59 AM

atul updated the diff for D6654: [landing] Wrap `SIWE` component with `WagmiENSCacheProvider`.

tmp

Feb 21 2023, 8:57 AM

atul closed D6653: [lib] Move `web:wagmi-utils` into `lib:wagmi-utils`.

Feb 21 2023, 8:50 AM

atul committed rCOMM6e7c7fbf711c: [lib] Move `web:wagmi-utils` into `lib:wagmi-utils`.

Feb 21 2023, 8:50 AM

atul updated the diff for D6653: [lib] Move `web:wagmi-utils` into `lib:wagmi-utils`.

rebase + land

Feb 21 2023, 8:46 AM

atul added a comment to D6653: [lib] Move `web:wagmi-utils` into `lib:wagmi-utils`.

Test Plan continues to look good (after rebasing, resolving merge conflicts, etc)

Feb 21 2023, 8:43 AM

atul updated the diff for D6653: [lib] Move `web:wagmi-utils` into `lib:wagmi-utils`.

update

Feb 21 2023, 8:41 AM

atul accepted D6810: [native] Patch baseThreadInfo in MessageListContainer with @-mentions in initial sidebar message.

Feb 21 2023, 8:26 AM

atul accepted D6809: [web] Patch NavInfo.pendingThread with @-mentions in initial sidebar message.

Feb 21 2023, 8:26 AM

atul accepted D6808: [lib][native][web] Include members of sidebar parent in mentions typeahead.

Feb 21 2023, 8:25 AM

atul accepted D6807: [web][native] Rename threadMembers in mentions typeahead code to mentionsCandidates.

Feb 21 2023, 8:25 AM

atul accepted D6806: [lib] Add @-mentioned users in initial sidebar message at creation time.

Feb 21 2023, 8:24 AM

atul accepted D6805: [lib] Factor out extractNewMentionedParentMembers.

Feb 21 2023, 8:19 AM

atul accepted D6804: [lib][native][web] Add members of parent to sidebar when mentioned there.

Feb 21 2023, 8:18 AM

atul accepted D6803: [lib] Add useCreationSideEffectsFunc to MessageSpec.

Feb 21 2023, 8:17 AM

atul accepted D6802: [lib] Factor out extractMentionedMembers.

Feb 21 2023, 8:16 AM

atul accepted D6801: [native][web] Drill parentThreadInfo to InputState.sendTextMessageAction.

Feb 21 2023, 8:11 AM

atul accepted D6800: [lib][native][web] Set sidebarCreation flag when creating messages that triggered a sidebar.

Feb 21 2023, 8:10 AM

atul accepted D6799: [keyserver][lib] Add sidebarCreation to keyserver message creation endpoints.

Feb 21 2023, 8:09 AM

atul accepted D6798: [lib] Disable text/media notif when starting sidebar.

Feb 21 2023, 8:09 AM

atul accepted D6797: [keyserver][lib] Pass MessageData to generatesNotifs.

Feb 21 2023, 8:08 AM

atul accepted D6796: [lib] Add sidebarCreation flag to text and media MessageDatas.

Feb 21 2023, 8:08 AM

atul accepted D6795: [lib] Make text and media message types read-only.

Feb 21 2023, 8:07 AM

atul closed D6793: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request.

Feb 21 2023, 4:04 AM

atul committed rCOMM649a300eac56: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request.

Feb 21 2023, 4:04 AM

atul closed D6794: [native] Replace settings `ThreadSettings` icon on Android.

Feb 21 2023, 12:26 AM

atul committed rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android.

Feb 21 2023, 12:25 AM

atul updated the diff for D6794: [native] Replace settings `ThreadSettings` icon on Android.

rebase before landing

Feb 21 2023, 12:25 AM

atul published D6794: [native] Replace settings `ThreadSettings` icon on Android for review.

Feb 21 2023, 12:19 AM

atul updated the test plan for D6793: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request.

Feb 21 2023, 12:06 AM

Feb 20 2023

atul published D6793: [native] Exclude `primaryIdentityPublicKey` from `siwe_auth` request for review.

Feb 20 2023, 11:54 PM

atul added a comment to D6770: [keyserver] Updating `yarn` scripts to run rust-node-addon build.

Are incremental builds like < 2 seconds or are they going to take a while (eg Rust portion of iOS build)?

Feb 20 2023, 10:45 PM

atul added a comment to D6485: [keyserver] Create a function to query for all uploads from a provided threadID.

In D6485#201861, @ashoat wrote:

In D6485#200792, @rohan wrote:

There's a better way of doing this since mediaFromRow is a little out of date given that we don't actually return the thumbnail information in the objects.

What do you mean by "out of date"? Wondering if something is broken on prod, since we use mediaFromRow everywhere

Feb 20 2023, 10:43 PM

atul attached a referenced file: F392020: 73af3c.png.

Feb 20 2023, 10:38 PM

atul added inline comments to D6769: [keyserver] Start inserting into messages table before calling postMessageSend.

Feb 20 2023, 10:38 PM

atul accepted D6769: [keyserver] Start inserting into messages table before calling postMessageSend.

Feb 20 2023, 10:33 PM

atul accepted D6768: [keyserver] Fix message creation when some (but not all) messages already exist.

Feb 20 2023, 10:30 PM

atul accepted D6767: [native] Emit artificial onSelectionChange alongside onChangeText in ClearableTextInput.

Before this change, I had noticed a bug where the @-mention typeahead would not clear after text input cleared. After this change the issue was gone.

Feb 20 2023, 10:28 PM

atul accepted D6765: [web] Show @-mentions in pending threads.

Feb 20 2023, 10:26 PM