- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 17 2023
May 16 2023
One request inline; please address before landing, or feel free to re-request review if you disagree or if I'm missing something
I was asking for links (hyperlinks) to the TypeScript types. In a previous comment I had requested:
since hooks cannot be called conditionally
Can you link the TypeScript types you used as inspiration? It will make review a lot easier
Thanks, this makes sense to me. cc @ted
May 15 2023
This diff is huge and it's hard to tell if it's "exhaustive" (eg. that everything has been covered).
Only requesting changes because I think you accidentally left a sleep call in there
Can you clarify why you named the folder third_party in D7779 but thirdparty here?
Back to you
I can't tell where these functions will be used, so it's a little harder to review
Memoization concern has been addressed; will leave the rest of the review to the original selected reviewers
Thanks, this is much safer!
Might be good for @marcin to take a look as well, as he is very familiar with this code
I confirmed with @anunay that we don't need this check and can remove it
If this was copy-pasted you should follow the third_party approach we've outlined before and include the LICENSE
It looks like you're missing some parameters for types such as InterpolateColor. Can you find the TypeScript types and try to base your new types on those, and make sure to include all relevant params?
May 13 2023
Can you explain more about the distinction between MessageSearch and MessageSearchContent? Wondering why they're separated, and what each is responsible for
May 12 2023
I don't see the reason the ckeck for matching inbound sessions every time we receive a message.
Back to you for extra details