Page MenuHomePhorge
Feed Search

Aug 3 2023

jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Fix batch writes

Aug 3 2023, 3:46 PM

Aug 1 2023

jon requested review of D8675: [Identity] Add DDB table for one-time-keys.
Aug 1 2023, 7:28 PM
jon updated the diff for D8660: [Docs] Revise identity deployment documentation.

Other corrections

Aug 1 2023, 5:40 PM
jon added inline comments to D8660: [Docs] Revise identity deployment documentation.
Aug 1 2023, 5:40 PM
jon updated the diff for D8660: [Docs] Revise identity deployment documentation.

Minor corrections

Aug 1 2023, 5:38 PM
jon updated the diff for D8660: [Docs] Revise identity deployment documentation.

Address feedback

Aug 1 2023, 5:35 PM
jon requested review of D8642: Allow for devices to register as a keyserver.
Aug 1 2023, 5:11 PM
jon accepted D8598: [services][terraform] Set up blob ECS service.

My concern gets addressed in a later diff

Aug 1 2023, 5:11 PM
jon accepted D8694: [native] cleanup includes in database code.
Aug 1 2023, 5:10 PM
jon accepted D8669: [services][terraform] Introduce S3 backend.
Aug 1 2023, 5:09 PM
jon accepted D8667: [terraform] Introduce SOPS secrets.
Aug 1 2023, 5:08 PM
jon added inline comments to D8577: [Docs] Document keyserver deployment.
Aug 1 2023, 3:21 PM
jon updated the diff for D8577: [Docs] Document keyserver deployment.

Address feedback

Aug 1 2023, 3:21 PM
jon added inline comments to D8468: [Docs/nix] Document how to update flake and push artifacts.
Aug 1 2023, 2:52 PM
jon updated the diff for D8468: [Docs/nix] Document how to update flake and push artifacts.

Address feedback

Aug 1 2023, 2:52 PM

Jul 31 2023

jon accepted D8666: [nix] Add sops.
Jul 31 2023, 2:39 PM
jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Rebase on master

Jul 31 2023, 1:52 PM

Jul 28 2023

jon requested review of D8660: [Docs] Revise identity deployment documentation.
Jul 28 2023, 6:48 PM
jon added inline comments to D8581: [Docs] Document how to deploy identity service.
Jul 28 2023, 6:12 PM

Jul 27 2023

jon accepted D8641: [identity] load OPAQUE server setup from environment variable.
Jul 27 2023, 8:32 PM
jon closed D8581: [Docs] Document how to deploy identity service.
Jul 27 2023, 2:50 PM
jon committed rCOMMa28e329235af: [Docs] Document how to deploy identity service.
Jul 27 2023, 2:50 PM
jon closed D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.
Jul 27 2023, 2:50 PM
jon committed rCOMMd589005d027b: [Identity] Avoid secret generation and slim down size of identity server docker….
Jul 27 2023, 2:50 PM
jon requested review of D8607: [Identity] Refactor DB error logic.
Jul 27 2023, 1:20 AM
jon added a comment to D8605: [Protos] Move GetKeyserverInfo to authtenticated service.

OutboundKeyserverResponse can be deleted from identity_client.proto, right?

Jul 27 2023, 1:07 AM
jon updated the diff for D8605: [Protos] Move GetKeyserverInfo to authtenticated service.

Remove OutboundKeyserverResponse from identity_client.proto

Jul 27 2023, 1:07 AM
jon added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.
Jul 27 2023, 1:04 AM
jon added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.
Jul 27 2023, 1:02 AM
jon accepted D8636: [services][terraform] Add feature-flags service.
Jul 27 2023, 12:15 AM
jon accepted D8635: [services][terraform] Set up IAM for feature-flags service.

Been a couple years, but this looks mostly like what I remember

Jul 27 2023, 12:15 AM
jon added inline comments to D8598: [services][terraform] Set up blob ECS service.
Jul 27 2023, 12:14 AM
jon added inline comments to D8641: [identity] load OPAQUE server setup from environment variable.
Jul 27 2023, 12:13 AM
jon added inline comments to D8641: [identity] load OPAQUE server setup from environment variable.
Jul 27 2023, 12:11 AM
jon requested changes to D8641: [identity] load OPAQUE server setup from environment variable.
Jul 27 2023, 12:00 AM

Jul 26 2023

jon added inline comments to D8606: [Identity] Refactor get user_id and device_id.
Jul 26 2023, 2:38 PM
jon accepted D8603: [CommCoreModule] introduce BaseDataStore template class.

cmake looks fine to me

Jul 26 2023, 2:31 PM
jon accepted D8548: [web] Add web Logger implementation.
Jul 26 2023, 2:29 PM

Jul 25 2023

jon requested review of D8627: [Identity] Remove static lifetime constraint on DBItemError.
Jul 25 2023, 6:11 PM
jon requested review of D8606: [Identity] Refactor get user_id and device_id.
Jul 25 2023, 6:00 PM
jon requested review of D8605: [Protos] Move GetKeyserverInfo to authtenticated service.
Jul 25 2023, 6:00 PM
jon accepted D8583: [services][terraform] Set up ECS cluster.
Jul 25 2023, 2:35 PM
jon accepted D8582: [services][terraform] Import VPC.
Jul 25 2023, 2:35 PM
jon added a reviewer for D8577: [Docs] Document keyserver deployment: ashoat.
Jul 25 2023, 2:34 PM
jon added a comment to D8581: [Docs] Document how to deploy identity service.

Address feedback

Jul 25 2023, 1:32 PM
jon updated the diff for D8581: [Docs] Document how to deploy identity service.

Address feedback

Jul 25 2023, 1:32 PM
jon closed D8587: [Keyserver/rust] Improve debugging.
Jul 25 2023, 1:24 PM
jon committed rCOMM1b51382d1050: [Keyserver/rust] Improve debugging.
Jul 25 2023, 1:24 PM
jon added inline comments to D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.
Jul 25 2023, 1:36 AM
jon updated the diff for D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.

Address feedback

Jul 25 2023, 1:35 AM
jon added inline comments to D8577: [Docs] Document keyserver deployment.
Jul 25 2023, 1:19 AM
jon updated the diff for D8577: [Docs] Document keyserver deployment.

Apply feedback

Jul 25 2023, 1:19 AM
jon added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Jul 25 2023, 12:51 AM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Address feedback

Jul 25 2023, 12:51 AM
jon planned changes to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Jul 25 2023, 12:10 AM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Correct rebase

Jul 25 2023, 12:09 AM

Jul 24 2023

jon updated the summary of D7691: [Keyserver] Open websocket connection with tunnelbroker.
Jul 24 2023, 1:39 PM
jon planned changes to D7691: [Keyserver] Open websocket connection with tunnelbroker.

Still need to apply the original feedback, just updating the work to use the identity credentials

Jul 24 2023, 1:39 PM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Rebase on keyserver+identity work

Jul 24 2023, 1:37 PM
jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

apply camelCase, fix returning a promise vs return a closure (void).

Jul 24 2023, 1:36 PM
jon updated the diff for D8475: [Keyserver] Refactor identity utilities.

Rebase on master

Jul 24 2023, 1:35 PM
jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Rebase on master

Jul 24 2023, 1:35 PM
jon abandoned D8474: [Keyserver] Refactor prekey lifecycle logic.

I rebased this into D8476. But I applied your suggestion @kamil, thanks

Jul 24 2023, 1:34 PM
jon updated the diff for D8464: [Identity] Implement RefreshUserPreKey.

Rebase on master

Jul 24 2023, 1:33 PM
jon updated the diff for D8463: [Services-test/identity] Refactor create_device.

Rebase on master

Jul 24 2023, 1:32 PM
jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Rebase on master

Jul 24 2023, 1:32 PM

Jul 20 2023

jon added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.
Jul 20 2023, 4:54 PM
jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

Address feedback

Jul 20 2023, 4:54 PM
jon requested review of D8587: [Keyserver/rust] Improve debugging.
Jul 20 2023, 4:43 PM
jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Apply missed feedback during refactor

Jul 20 2023, 4:39 PM
jon accepted D8584: [lint-staged] Lint Terraform files in subdirs.
Jul 20 2023, 3:55 PM
jon requested changes to D8548: [web] Add web Logger implementation.
Jul 20 2023, 3:53 PM
jon accepted D8570: [services][terraform] Import shared resources.
Jul 20 2023, 3:51 PM
jon accepted D8571: [services][terraform] Add default ManagedBy tag to all resources.
Jul 20 2023, 3:51 PM
jon requested review of D8581: [Docs] Document how to deploy identity service.
Jul 20 2023, 2:25 AM
jon requested review of D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.
Jul 20 2023, 2:24 AM

Jul 19 2023

jon requested review of D8577: [Docs] Document keyserver deployment.
Jul 19 2023, 10:40 PM
jon closed D8538: [Keyserver/rust] Initialize gRPC with host's TLS certs.
Jul 19 2023, 9:18 PM
jon committed rCOMMd8a895c13a62: [Keyserver/rust] Initialize gRPC with host's TLS certs.
Jul 19 2023, 9:18 PM
jon requested review of D8434: [Identity] Add authenticated gRPC service.

i don't love that we block on verify_access_token in the interceptor function. would rather use a tower layer instead of a tonic interceptor to call the code asynchronously,

Jul 19 2023, 8:07 PM
jon requested changes to D8501: [identity] log out user RPC.

Eventually, we should move this to the authenticated service

Jul 19 2023, 7:19 PM
jon requested changes to D8548: [web] Add web Logger implementation.
Jul 19 2023, 7:10 PM
jon accepted D8549: [native] Make metadata related methods public.
Jul 19 2023, 7:06 PM
jon added a comment to D8550: [native] hide native-specific code.

Makes sense as a transitional step. But I wonder if there is a better solution which someone else might know.

Jul 19 2023, 7:06 PM
jon added a comment to D8552: [web] add `std::vector` (C++) <-> `Array` (JS) marshalling.

My cpp is very rusty, but shouldn't we have a header file? how will we call methods defined here?

Jul 19 2023, 6:48 PM
jon accepted D8567: [services][terraform] Move current config to dev/.

Makes sense to me

Jul 19 2023, 6:45 PM
jon added inline comments to D8568: [services][terraform] Create remote config.
Jul 19 2023, 6:43 PM
jon requested changes to D8571: [services][terraform] Add default ManagedBy tag to all resources.
Jul 19 2023, 6:41 PM
jon requested changes to D8570: [services][terraform] Import shared resources.
Jul 19 2023, 6:39 PM
jon added a reviewer for D8538: [Keyserver/rust] Initialize gRPC with host's TLS certs: ashoat.
Jul 19 2023, 4:16 PM

Jul 18 2023

jon requested review of D8538: [Keyserver/rust] Initialize gRPC with host's TLS certs.
Jul 18 2023, 10:01 PM
jon accepted D8533: [keyserver] rename napi add_reserved_usernames function.
Jul 18 2023, 9:01 PM

Jul 17 2023

jon abandoned D8052: [Keyserver] Use olm identity key for tunnelbroker connection.

squashed this into D7691 because of rebase work

Jul 17 2023, 2:25 PM
jon abandoned D7702: [Keyserver] Introduce tunnelbroker types.

squashed this into D7691 because of rebase work

Jul 17 2023, 2:25 PM
jon accepted D8520: Modify NIX and keyserver configuration files to allow node version >= 18.

LGTM if we just want node>=18 (as mentioned in summary)

Jul 17 2023, 2:23 PM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Squash initial session commits into one

Jul 17 2023, 2:23 PM
jon closed D8405: [Keyserver] Attempt login to identity service.
Jul 17 2023, 2:40 AM
jon committed rCOMM5092f6ecd961: [Keyserver] Attempt login to identity service.
Jul 17 2023, 2:39 AM
jon closed D8404: [Keyserver/rust] Remove legacy auth_token configuration.
Jul 17 2023, 2:39 AM
jon closed D8403: [Keyserver/rust] Enable logging of rust addon.
Jul 17 2023, 2:39 AM