Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Aug 7 2023

• jon updated the diff for D8463: [Services-test/identity] Refactor create_device.

Rebase on master

Aug 7 2023, 8:33 AM

• jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Rebase on master

Aug 7 2023, 8:33 AM

• jon requested review of D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.

Aug 7 2023, 8:20 AM

• jon requested review of D8749: [Identity/Tunnelbroker] Add integration tests.

Aug 7 2023, 8:11 AM

• jon requested review of D8748: [Identity] Issue refresh_key_request to tunnelbroker.

Aug 7 2023, 8:09 AM

Aug 3 2023

• jon requested review of D8723: [Identity] Allow for tunnelbroker endpoint to be configured.

Aug 3 2023, 12:21 PM

• jon requested review of D8722: [Identity] Implement GetKeyserverKeys.

Aug 3 2023, 12:19 PM

• jon requested review of D8721: [Identity] Add some utilties with manipulating DDB results.

Aug 3 2023, 12:11 PM

• jon accepted D8703: [tunnelbroker] Remove lazy_static dependency.

Aug 3 2023, 11:16 AM

• jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Fix batch writes

Aug 3 2023, 8:46 AM

Aug 1 2023

• jon requested review of D8675: [Identity] Add DDB table for one-time-keys.

Aug 1 2023, 12:28 PM

• jon updated the diff for D8660: [Docs] Revise identity deployment documentation.

Other corrections

Aug 1 2023, 10:40 AM

• jon added inline comments to D8660: [Docs] Revise identity deployment documentation.

Aug 1 2023, 10:40 AM

• jon updated the diff for D8660: [Docs] Revise identity deployment documentation.

Minor corrections

Aug 1 2023, 10:38 AM

• jon updated the diff for D8660: [Docs] Revise identity deployment documentation.

Address feedback

Aug 1 2023, 10:35 AM

• jon requested review of D8642: Allow for devices to register as a keyserver.

Aug 1 2023, 10:11 AM

• jon accepted D8598: [services][terraform] Set up blob ECS service.

My concern gets addressed in a later diff

Aug 1 2023, 10:11 AM

• jon accepted D8694: [native] cleanup includes in database code.

Aug 1 2023, 10:10 AM

• jon accepted D8669: [services][terraform] Introduce S3 backend.

Aug 1 2023, 10:09 AM

• jon accepted D8667: [terraform] Introduce SOPS secrets.

Aug 1 2023, 10:08 AM

• jon added inline comments to D8577: [Docs] Document keyserver deployment.

Aug 1 2023, 8:21 AM

• jon updated the diff for D8577: [Docs] Document keyserver deployment.

Address feedback

Aug 1 2023, 8:21 AM

• jon added inline comments to D8468: [Docs/nix] Document how to update flake and push artifacts.

Aug 1 2023, 7:52 AM

• jon updated the diff for D8468: [Docs/nix] Document how to update flake and push artifacts.

Address feedback

Aug 1 2023, 7:52 AM

Jul 31 2023

• jon accepted D8666: [nix] Add sops.

Jul 31 2023, 7:39 AM

• jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Rebase on master

Jul 31 2023, 6:52 AM

Jul 28 2023

• jon requested review of D8660: [Docs] Revise identity deployment documentation.

Jul 28 2023, 11:48 AM

• jon added inline comments to D8581: [Docs] Document how to deploy identity service.

Jul 28 2023, 11:12 AM

Jul 27 2023

• jon accepted D8641: [identity] load OPAQUE server setup from environment variable.

Jul 27 2023, 1:32 PM

• jon closed D8581: [Docs] Document how to deploy identity service.

Jul 27 2023, 7:50 AM

• jon committed rCOMMa28e329235af: [Docs] Document how to deploy identity service (authored by • jon).

[Docs] Document how to deploy identity service

Jul 27 2023, 7:50 AM

• jon closed D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.

Jul 27 2023, 7:50 AM

• jon committed rCOMMd589005d027b: [Identity] Avoid secret generation and slim down size of identity server docker… (authored by • jon).

[Identity] Avoid secret generation and slim down size of identity server docker…

Jul 27 2023, 7:50 AM

Jul 26 2023

• jon requested review of D8607: [Identity] Refactor DB error logic.

Jul 26 2023, 6:20 PM

• jon added a comment to D8605: [Protos] Move GetKeyserverInfo to authtenticated service.

OutboundKeyserverResponse can be deleted from identity_client.proto, right?

Jul 26 2023, 6:07 PM

• jon updated the diff for D8605: [Protos] Move GetKeyserverInfo to authtenticated service.

Remove OutboundKeyserverResponse from identity_client.proto

Jul 26 2023, 6:07 PM

• jon added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.

Jul 26 2023, 6:04 PM

• jon added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.

Jul 26 2023, 6:02 PM

• jon accepted D8636: [services][terraform] Add feature-flags service.

Jul 26 2023, 5:15 PM

• jon accepted D8635: [services][terraform] Set up IAM for feature-flags service.

Been a couple years, but this looks mostly like what I remember

Jul 26 2023, 5:15 PM

• jon added inline comments to D8598: [services][terraform] Set up blob ECS service.

Jul 26 2023, 5:14 PM

• jon added inline comments to D8641: [identity] load OPAQUE server setup from environment variable.

Jul 26 2023, 5:13 PM

• jon added inline comments to D8641: [identity] load OPAQUE server setup from environment variable.

Jul 26 2023, 5:11 PM

• jon requested changes to D8641: [identity] load OPAQUE server setup from environment variable.

Jul 26 2023, 5:00 PM

• jon added inline comments to D8606: [Identity] Refactor get user_id and device_id.

Jul 26 2023, 7:38 AM

• jon accepted D8603: [CommCoreModule] introduce BaseDataStore template class.

cmake looks fine to me

Jul 26 2023, 7:31 AM

• jon accepted D8548: [web] Add web Logger implementation.

Jul 26 2023, 7:29 AM

Jul 25 2023

• jon requested review of D8627: [Identity] Remove static lifetime constraint on DBItemError.

Jul 25 2023, 11:11 AM

• jon requested review of D8606: [Identity] Refactor get user_id and device_id.

Jul 25 2023, 11:00 AM

• jon requested review of D8605: [Protos] Move GetKeyserverInfo to authtenticated service.

Jul 25 2023, 11:00 AM

• jon accepted D8583: [services][terraform] Set up ECS cluster.

Jul 25 2023, 7:35 AM

• jon accepted D8582: [services][terraform] Import VPC.

Jul 25 2023, 7:35 AM

• jon added a reviewer for D8577: [Docs] Document keyserver deployment: ashoat.

Jul 25 2023, 7:34 AM

• jon added a comment to D8581: [Docs] Document how to deploy identity service.

Address feedback

Jul 25 2023, 6:32 AM

• jon updated the diff for D8581: [Docs] Document how to deploy identity service.

Address feedback

Jul 25 2023, 6:32 AM

• jon closed D8587: [Keyserver/rust] Improve debugging.

Jul 25 2023, 6:24 AM

• jon committed rCOMM1b51382d1050: [Keyserver/rust] Improve debugging (authored by • jon).

[Keyserver/rust] Improve debugging

Jul 25 2023, 6:24 AM

Jul 24 2023

• jon added inline comments to D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.

Jul 24 2023, 6:36 PM

• jon updated the diff for D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.

Address feedback

Jul 24 2023, 6:35 PM

• jon added inline comments to D8577: [Docs] Document keyserver deployment.

Jul 24 2023, 6:19 PM

• jon updated the diff for D8577: [Docs] Document keyserver deployment.

Apply feedback

Jul 24 2023, 6:19 PM

• jon added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.

Jul 24 2023, 5:51 PM

• jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Address feedback

Jul 24 2023, 5:51 PM

• jon planned changes to D7691: [Keyserver] Open websocket connection with tunnelbroker.

Jul 24 2023, 5:10 PM

• jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Correct rebase

Jul 24 2023, 5:09 PM

• jon updated the summary of D7691: [Keyserver] Open websocket connection with tunnelbroker.

Jul 24 2023, 6:39 AM

• jon planned changes to D7691: [Keyserver] Open websocket connection with tunnelbroker.

Still need to apply the original feedback, just updating the work to use the identity credentials

Jul 24 2023, 6:39 AM

• jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Rebase on keyserver+identity work

Jul 24 2023, 6:37 AM

• jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

apply camelCase, fix returning a promise vs return a closure (void).

Jul 24 2023, 6:36 AM

• jon updated the diff for D8475: [Keyserver] Refactor identity utilities.

Rebase on master

Jul 24 2023, 6:35 AM

• jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Rebase on master

Jul 24 2023, 6:35 AM

• jon abandoned D8474: [Keyserver] Refactor prekey lifecycle logic.

I rebased this into D8476. But I applied your suggestion @kamil, thanks

Jul 24 2023, 6:34 AM

• jon updated the diff for D8464: [Identity] Implement RefreshUserPreKey.

Rebase on master

Jul 24 2023, 6:33 AM

• jon updated the diff for D8463: [Services-test/identity] Refactor create_device.

Rebase on master

Jul 24 2023, 6:32 AM

• jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Rebase on master

Jul 24 2023, 6:32 AM

Jul 20 2023

• jon added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.

Jul 20 2023, 9:54 AM

• jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

Address feedback

Jul 20 2023, 9:54 AM

• jon requested review of D8587: [Keyserver/rust] Improve debugging.

Jul 20 2023, 9:43 AM

• jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Apply missed feedback during refactor

Jul 20 2023, 9:39 AM

• jon accepted D8584: [lint-staged] Lint Terraform files in subdirs.

Jul 20 2023, 8:55 AM

• jon requested changes to D8548: [web] Add web Logger implementation.

Jul 20 2023, 8:53 AM

• jon accepted D8570: [services][terraform] Import shared resources.

Jul 20 2023, 8:51 AM

• jon accepted D8571: [services][terraform] Add default ManagedBy tag to all resources.

Jul 20 2023, 8:51 AM

Jul 19 2023

• jon requested review of D8581: [Docs] Document how to deploy identity service.

Jul 19 2023, 7:25 PM

• jon requested review of D8580: [Identity] Avoid secret generation and slim down size of identity server docker image.

Jul 19 2023, 7:24 PM

• jon requested review of D8577: [Docs] Document keyserver deployment.

Jul 19 2023, 3:40 PM

• jon closed D8538: [Keyserver/rust] Initialize gRPC with host's TLS certs.

Jul 19 2023, 2:18 PM

• jon committed rCOMMd8a895c13a62: [Keyserver/rust] Initialize gRPC with host's TLS certs (authored by • jon).

[Keyserver/rust] Initialize gRPC with host's TLS certs

Jul 19 2023, 2:18 PM

• jon requested review of D8434: [Identity] Add authenticated gRPC service.

i don't love that we block on verify_access_token in the interceptor function. would rather use a tower layer instead of a tonic interceptor to call the code asynchronously,

Jul 19 2023, 1:07 PM

• jon requested changes to D8501: [identity] log out user RPC.

Eventually, we should move this to the authenticated service

Jul 19 2023, 12:19 PM

• jon requested changes to D8548: [web] Add web Logger implementation.

Jul 19 2023, 12:10 PM

• jon accepted D8549: [native] Make metadata related methods public.

Jul 19 2023, 12:06 PM

• jon added a comment to D8550: [native] hide native-specific code.

Makes sense as a transitional step. But I wonder if there is a better solution which someone else might know.

Jul 19 2023, 12:06 PM

• jon added a comment to D8552: [web] add `std::vector` (C++) <-> `Array` (JS) marshalling.

My cpp is very rusty, but shouldn't we have a header file? how will we call methods defined here?

Jul 19 2023, 11:48 AM

• jon accepted D8567: [services][terraform] Move current config to dev/.

Makes sense to me

Jul 19 2023, 11:45 AM

• jon added inline comments to D8568: [services][terraform] Create remote config.

Jul 19 2023, 11:43 AM

• jon requested changes to D8571: [services][terraform] Add default ManagedBy tag to all resources.

Jul 19 2023, 11:41 AM

• jon requested changes to D8570: [services][terraform] Import shared resources.

Jul 19 2023, 11:39 AM

• jon added a reviewer for D8538: [Keyserver/rust] Initialize gRPC with host's TLS certs: ashoat.

Jul 19 2023, 9:16 AM

Jul 18 2023

• jon requested review of D8538: [Keyserver/rust] Initialize gRPC with host's TLS certs.

Jul 18 2023, 3:01 PM