Page MenuHomePhorge
Feed Search

Aug 9 2023

atul updated the diff for D8759: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in `EditThreadAvatarProvider`.

rebase and land

Aug 9 2023, 6:19 AM
atul updated the diff for D8759: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in `EditThreadAvatarProvider`.

rebase and land

Aug 9 2023, 6:00 AM
atul closed D8758: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.
Aug 9 2023, 5:25 AM
atul committed rCOMM752b499b6fa2: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.
Aug 9 2023, 5:25 AM
atul updated the diff for D8758: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.

rebase and land

Aug 9 2023, 5:13 AM
atul closed D8757: [native] Introduce `useNativeSetThreadAvatar` and use throughout `native`.
Aug 9 2023, 1:31 AM
atul committed rCOMMc97d3b71cef5: [native] Introduce `useNativeSetThreadAvatar` and use throughout `native`.
Aug 9 2023, 1:31 AM
atul updated the diff for D8757: [native] Introduce `useNativeSetThreadAvatar` and use throughout `native`.

rethrow exception in useNativeSetThreadAvatar

Aug 9 2023, 1:30 AM
atul added inline comments to D8757: [native] Introduce `useNativeSetThreadAvatar` and use throughout `native`.
Aug 9 2023, 12:14 AM

Aug 8 2023

atul published D8759: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in `EditThreadAvatarProvider` for review.
Aug 8 2023, 9:04 AM
atul requested review of D8758: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.
Aug 8 2023, 8:57 AM
atul closed D8756: [Buildkite] Add automatic retries to workflows missing it.
Aug 8 2023, 8:55 AM
atul committed rCOMM4a80b245a2c8: [Buildkite] Add automatic retries to workflows missing it.
Aug 8 2023, 8:55 AM
atul requested review of D8757: [native] Introduce `useNativeSetThreadAvatar` and use throughout `native`.
Aug 8 2023, 8:54 AM
atul updated the diff for D8756: [Buildkite] Add automatic retries to workflows missing it.

rebase and land

Aug 8 2023, 8:52 AM
atul added a comment to D8756: [Buildkite] Add automatic retries to workflows missing it.
In D8756#258173, @tomek wrote:

I guess we could have a test plan here: e.g. create a job that fails and check if it gets retried. But if we follow what's in other workflows, we shouldn't expect any differences.

Aug 8 2023, 8:38 AM
atul closed D8741: [native] Consume `useNativeUpdateThreadImageAvatar` in `useSelectFromGalleryAndUpdateImageAvatar`.
Aug 8 2023, 7:25 AM
atul committed rCOMM77ddd5a08fb9: [native] Consume `useNativeUpdateThreadImageAvatar` in….
Aug 8 2023, 7:25 AM
atul updated the diff for D8741: [native] Consume `useNativeUpdateThreadImageAvatar` in `useSelectFromGalleryAndUpdateImageAvatar`.

rebase and land

Aug 8 2023, 7:22 AM
atul published D8756: [Buildkite] Add automatic retries to workflows missing it for review.
Aug 8 2023, 7:19 AM
atul closed D8740: [lib] Introduce `useNativeUpdateThreadImageAvatar` to `AvatarHooks`.
Aug 8 2023, 6:26 AM
atul committed rCOMMfb4f1746fb42: [lib] Introduce `useNativeUpdateThreadImageAvatar` to `AvatarHooks`.
Aug 8 2023, 6:26 AM
atul updated the diff for D8740: [lib] Introduce `useNativeUpdateThreadImageAvatar` to `AvatarHooks`.

have sendPhoto return promise

Aug 8 2023, 6:23 AM
atul added inline comments to D8740: [lib] Introduce `useNativeUpdateThreadImageAvatar` to `AvatarHooks`.
Aug 8 2023, 6:22 AM
atul updated the diff for D8740: [lib] Introduce `useNativeUpdateThreadImageAvatar` to `AvatarHooks`.

address feedback

Aug 8 2023, 6:19 AM
atul accepted D8092: [landing] introduce keyserver faq data.
Aug 8 2023, 5:35 AM
atul accepted D8078: [landing] introduce new assetMetaData.
Aug 8 2023, 5:33 AM
atul accepted D8033: [landing] introduce telegram competitor data.
Aug 8 2023, 5:30 AM
atul accepted D8032: [landing] introduce slack competitor data.
Aug 8 2023, 5:29 AM

Aug 6 2023

atul published D8741: [native] Consume `useNativeUpdateThreadImageAvatar` in `useSelectFromGalleryAndUpdateImageAvatar` for review.
Aug 6 2023, 3:36 AM
atul published D8740: [lib] Introduce `useNativeUpdateThreadImageAvatar` to `AvatarHooks` for review.
Aug 6 2023, 3:19 AM
atul closed D8736: [lib] Move `selectFromGalleryAndUpdateThreadAvatar` from provider to `avatar-hooks`.
Aug 6 2023, 2:51 AM
atul committed rCOMM4b38dc2000d7: [lib] Move `selectFromGalleryAndUpdateThreadAvatar` from provider to `avatar….
Aug 6 2023, 2:51 AM
atul updated the diff for D8736: [lib] Move `selectFromGalleryAndUpdateThreadAvatar` from provider to `avatar-hooks`.

rebase and land

Aug 6 2023, 2:46 AM

Aug 5 2023

atul requested review of D8736: [lib] Move `selectFromGalleryAndUpdateThreadAvatar` from provider to `avatar-hooks`.
Aug 5 2023, 10:08 AM
atul accepted D8729: [lib] make calendarQuery field in SIWEAuthRequest type required.
Aug 5 2023, 7:14 AM
atul resigned from D8683: [keyserver] Fix the pinned count MariaDB out of range issue.
Aug 5 2023, 7:12 AM

Aug 4 2023

atul closed D8726: [web] Call `baseSetUserAvatar` from `onImageSelected`.
Aug 4 2023, 9:41 PM
atul committed rCOMMcf12040be85f: [web] Call `baseSetUserAvatar` from `onImageSelected`.
Aug 4 2023, 9:41 PM
atul closed D8725: [web] Remove extraneous ESLint suppression.
Aug 4 2023, 9:41 PM
atul committed rCOMM4c9e85a79923: [web] Remove extraneous ESLint suppression.
Aug 4 2023, 9:41 PM
atul closed D8724: [web] Introduce `useUploadAvatarMedia` to `AvatarHooks`.
Aug 4 2023, 9:41 PM
atul committed rCOMMf86be566a289: [web] Introduce `useUploadAvatarMedia` to `AvatarHooks`.
Aug 4 2023, 9:41 PM
atul accepted D8734: [lib] Remove extraneous space in thread creation robotext.
Aug 4 2023, 6:13 PM
atul requested review of D8726: [web] Call `baseSetUserAvatar` from `onImageSelected`.
Aug 4 2023, 8:40 AM
atul updated the summary of D8725: [web] Remove extraneous ESLint suppression.
Aug 4 2023, 8:12 AM
atul published D8725: [web] Remove extraneous ESLint suppression for review.
Aug 4 2023, 7:59 AM
atul published D8724: [web] Introduce `useUploadAvatarMedia` to `AvatarHooks` for review.
Aug 4 2023, 7:54 AM
atul accepted D8711: [web] move reaction message action type logic into useSendReaction.
Aug 4 2023, 4:36 AM
atul accepted D8710: [web] make reactions prop for InlineEngagement requried.
Aug 4 2023, 4:30 AM
atul accepted D8708: [web] seperate out each reaction into their own pill.
Aug 4 2023, 4:29 AM
atul accepted D8707: [web] add space between inline engagement container and edges of chat window.
Aug 4 2023, 4:28 AM
atul accepted D8029: [landing] introduce Discord competitor data.

Didn't read through copy, but diff looks good.

Aug 4 2023, 4:27 AM
atul closed D8718: [GH Actions] Add `gradle.jvmargs` args to `./gradlew bundleRelease`.
Aug 4 2023, 1:34 AM
atul committed rCOMMd1ea1b4ff331: [GH Actions] Add `gradle.jvmargs` args to `./gradlew bundleRelease`.
Aug 4 2023, 1:34 AM
atul closed D8717: [GH Actions] Add back `Delete some stuff to free up disk space` step for Android workflows.
Aug 4 2023, 1:34 AM
atul committed rCOMM4c7f91ea6735: [GH Actions] Add back `Delete some stuff to free up disk space` step for….
Aug 4 2023, 1:34 AM

Aug 3 2023

atul accepted D8709: [web] deprecate stringForReactionList.
Aug 3 2023, 11:57 AM
atul updated the summary of D8718: [GH Actions] Add `gradle.jvmargs` args to `./gradlew bundleRelease`.
Aug 3 2023, 11:55 AM
atul attached a referenced file: F673486: aede96.png.
Aug 3 2023, 11:54 AM
atul published D8718: [GH Actions] Add `gradle.jvmargs` args to `./gradlew bundleRelease` for review.
Aug 3 2023, 11:54 AM
atul published D8717: [GH Actions] Add back `Delete some stuff to free up disk space` step for Android workflows for review.
Aug 3 2023, 11:53 AM
atul closed D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.
Aug 3 2023, 4:01 AM
atul committed rCOMMe7e6e8a7a1a9: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.
Aug 3 2023, 4:01 AM
atul updated the diff for D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.

rebase and land

Aug 3 2023, 3:56 AM
atul added inline comments to D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.
Aug 3 2023, 2:19 AM
atul updated the diff for D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.

address feedback

Aug 3 2023, 2:11 AM

Aug 2 2023

atul updated the test plan for D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu`.
Aug 2 2023, 7:51 AM
atul published D8702: [web] Add "Use ENS avatar" option to `EditUserAvatarMenu` for review.
Aug 2 2023, 7:50 AM
atul closed D8701: [Buildkite] Remove `i686-linux-android` from `rustup target add`.
Aug 2 2023, 2:51 AM
atul committed rCOMMdda2db822eae: [Buildkite] Remove `i686-linux-android` from `rustup target add`.
Aug 2 2023, 2:51 AM

Aug 1 2023

atul published D8701: [Buildkite] Remove `i686-linux-android` from `rustup target add` for review.
Aug 1 2023, 9:29 PM
atul resigned from D8697: Significant refactor of notification encryption code.

Don't have a ton of context here

Aug 1 2023, 9:21 PM
atul accepted D8700: [keyserver] await INSERT INTO messages before calling postMessageSend.
Aug 1 2023, 9:20 PM
atul accepted D8698: Upload iOS notification payload to blob service if its size exceeds limits.
Aug 1 2023, 9:20 PM
atul added a reviewer for D8697: Significant refactor of notification encryption code: ashoat.

(Preemptively adding @ashoat as reviewer)

Aug 1 2023, 9:18 PM
atul accepted D8684: [web] clean up edited label.
Aug 1 2023, 9:16 PM
atul accepted D8678: [web] split the inline engagement pill into two.

Don't love the way the "after" looks, but guessing this is an intermediate step "on the way" to the intended design?

Aug 1 2023, 9:12 PM
atul requested changes to D8683: [keyserver] Fix the pinned count MariaDB out of range issue.

Looks good at a high level, adding @ashoat as blocking to make sure someone w/ more context on roles takes a look before landing.

Aug 1 2023, 9:10 PM
atul closed D8690: [GH Actions] Add "Disk Usage" step to Android workflows.
Aug 1 2023, 8:23 PM
atul closed D8689: [Android] Remove 32-bit x86 support.
Aug 1 2023, 8:23 PM
atul committed rCOMMd43534141cb8: [GH Actions] Add "Disk Usage" step to Android workflows.
Aug 1 2023, 8:23 PM
atul committed rCOMM583c1520a50d: [Android] Remove 32-bit x86 support.
Aug 1 2023, 8:23 PM
atul closed D8688: [GH Actions] Remove JDK 11 step from Android workflows.
Aug 1 2023, 8:23 PM
atul committed rCOMM2a988943fe42: [GH Actions] Remove JDK 11 step from Android workflows.
Aug 1 2023, 8:23 PM
atul added inline comments to D8689: [Android] Remove 32-bit x86 support.
Aug 1 2023, 8:22 PM
atul added inline comments to D8689: [Android] Remove 32-bit x86 support.
Aug 1 2023, 8:21 PM
atul closed D8687: [GH Actions] Remove "Install Yarn" step from Android workflows.
Aug 1 2023, 8:11 PM
atul committed rCOMMf675292aef91: [GH Actions] Remove "Install Yarn" step from Android workflows.
Aug 1 2023, 8:11 PM
atul updated the diff for D8687: [GH Actions] Remove "Install Yarn" step from Android workflows.

remove install yarn step from all workflows

Aug 1 2023, 8:09 PM
atul added a comment to D8687: [GH Actions] Remove "Install Yarn" step from Android workflows.

Can this be done for all runners? Both windows and macos seem to have Yarn 1.22.19

Aug 1 2023, 8:05 PM
atul added inline comments to D8660: [Docs] Revise identity deployment documentation.
Aug 1 2023, 8:03 PM

Jul 31 2023

atul published D8690: [GH Actions] Add "Disk Usage" step to Android workflows for review.
Jul 31 2023, 11:10 PM
atul updated the summary of D8689: [Android] Remove 32-bit x86 support.
Jul 31 2023, 11:09 PM
atul updated the summary of D8688: [GH Actions] Remove JDK 11 step from Android workflows.
Jul 31 2023, 11:09 PM
atul published D8689: [Android] Remove 32-bit x86 support for review.
Jul 31 2023, 11:05 PM
atul published D8688: [GH Actions] Remove JDK 11 step from Android workflows for review.
Jul 31 2023, 10:02 PM
atul published D8687: [GH Actions] Remove "Install Yarn" step from Android workflows for review.
Jul 31 2023, 9:58 PM
atul committed rCOMM6e524d6f0a68: Bump word-wrap from 1.2.3 to 1.2.4 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Jul 31 2023, 8:36 PM
atul requested changes to D8683: [keyserver] Fix the pinned count MariaDB out of range issue.

We definitely want to prevent two back to back pin actions for the same message, but even more so for two unpin actions since that throws an error on the keyserver.

Jul 31 2023, 7:08 PM