Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Dec 14 2023

atul committed rCOMM3ce50c43aecc: [web] Update `validateStateAndProcessDBOperations` to handle `RawThreadInfos` (authored by atul).

[web] Update `validateStateAndProcessDBOperations` to handle `RawThreadInfos`

Dec 14 2023, 12:49 PM

atul closed D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.

Dec 14 2023, 12:49 PM

atul committed rCOMM47e706802def: [lib] Update remaining places in `lib` to support `RawThreadInfos` (authored by atul).

[lib] Update remaining places in `lib` to support `RawThreadInfos`

Dec 14 2023, 12:49 PM

atul closed D10271: [lib] Add ridiculous branching to `update-thread-read-status-spec` to appease `flow`.

Dec 14 2023, 12:49 PM

atul committed rCOMM914419603d5a: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos` (authored by atul).

[lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`

Dec 14 2023, 12:49 PM

atul committed rCOMM73b7ea7ee7df: [lib] Add ridiculous branching to `update-thread-read-status-spec` to appease… (authored by atul).

[lib] Add ridiculous branching to `update-thread-read-status-spec` to appease…

Dec 14 2023, 12:49 PM

atul closed D10270: [lib] Add ridiculous branching to `delete-account-spec` to appease `flow`.

Dec 14 2023, 12:49 PM

atul closed D10268: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in `shared/updates`.

Dec 14 2023, 12:49 PM

atul committed rCOMM0319f12e9c15: [lib] Add ridiculous branching to `delete-account-spec` to appease `flow` (authored by atul).

[lib] Add ridiculous branching to `delete-account-spec` to appease `flow`

Dec 14 2023, 12:48 PM

atul committed rCOMM379b729b9287: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in… (authored by atul).

[lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in…

Dec 14 2023, 12:48 PM

atul closed D10243: [lib] Update `lib/types` to accomodate `RawThreadInfos`.

Dec 14 2023, 12:48 PM

atul committed rCOMMaf5c27550278: [lib] Update `lib/types` to accomodate `RawThreadInfos` (authored by atul).

[lib] Update `lib/types` to accomodate `RawThreadInfos`

Dec 14 2023, 12:48 PM

atul updated the diff for D10284: [native] Update `updateRolesAndPermissions` to only handle `LegacyRawThreadInfos`.

land

Dec 14 2023, 12:13 PM

atul resigned from D10250: [web] Update SubchannelMembers to call useUserSearchIndex.

Looks like @inka is giving this a thorough review, so resigning to remove from queue. Feel free to re-assign me as reviewer if there's something specific I can be useful with.

Dec 14 2023, 12:12 PM

atul added a comment to D10280: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`.

In D10280#299275, @ashoat wrote:

Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)

Dec 14 2023, 12:01 PM

atul added a comment to D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.

In D10274#299272, @ashoat wrote:

Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)

Dec 14 2023, 12:01 PM

atul published D10340: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners for review.

Dec 14 2023, 10:41 AM

atul published D10339: [identity] Switch Identity unit tests to autoscaling CI runners for review.

Dec 14 2023, 10:36 AM

atul closed D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

Dec 14 2023, 10:20 AM

atul committed rCOMM542fd5705da4: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and… (authored by atul).

[lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and…

Dec 14 2023, 10:20 AM

atul added inline comments to D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

Dec 14 2023, 10:13 AM

atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

maintain previous order w/ unshift/push

Dec 14 2023, 10:10 AM

atul closed D10328: [blob] Switch Blob unit tests to autoscaling CI runners.

Dec 14 2023, 10:03 AM

atul committed rCOMMc65e52c345e5: [blob] Switch Blob unit tests to autoscaling CI runners (authored by atul).

[blob] Switch Blob unit tests to autoscaling CI runners

Dec 14 2023, 10:03 AM

atul added a comment to D10328: [blob] Switch Blob unit tests to autoscaling CI runners.

This does mean that we wouldn't catch it if eg. there was some new non-Cargo dependency in the blob service that wasn't in the Nix environment

Dec 14 2023, 9:46 AM

atul added inline comments to D10328: [blob] Switch Blob unit tests to autoscaling CI runners.

Dec 14 2023, 9:45 AM

Dec 13 2023

atul accepted D10315: [web] cleanup thread notifications modal.

Dec 13 2023, 10:38 PM

atul updated the diff for D10297: [native] Redux migration to support minimally encoded permissions.

final rebase pass

Dec 13 2023, 3:19 PM

atul updated the diff for D10295: [keyserver] Move `threadStoreValidator` to `redux-state-responders`.

final rebase pass

Dec 13 2023, 3:18 PM

atul updated the diff for D10294: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with `rawThreadInfoValidator`.

last rebase pass

Dec 13 2023, 3:17 PM

atul updated the diff for D10286: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support `minimallyEncodePermissions` option.

last rebase pass

Dec 13 2023, 3:16 PM

atul updated the diff for D10285: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument.

address feedback

Dec 13 2023, 3:12 PM

atul added inline comments to D10285: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument.

Dec 13 2023, 3:11 PM

atul updated the diff for D10284: [native] Update `updateRolesAndPermissions` to only handle `LegacyRawThreadInfos`.

final rebase pass

Dec 13 2023, 3:10 PM

atul updated the diff for D10283: [lib] Update `convertThreadStoreThreadInfosToNewIDSchema` migration to ensure `rawThreadInfos` are NOT minimally encoded.

address feedback: more specific invariant message

Dec 13 2023, 3:09 PM

atul attached a referenced file: F940349: 2a9dc0.png.

Dec 13 2023, 3:08 PM

atul added inline comments to D10283: [lib] Update `convertThreadStoreThreadInfosToNewIDSchema` migration to ensure `rawThreadInfos` are NOT minimally encoded.

Dec 13 2023, 3:08 PM

atul updated the diff for D10281: [native] Introduce `assertAllThreadInfosAreLegacy` to address migration 29 `flow` issues.

address feedback

Dec 13 2023, 3:05 PM

atul updated the diff for D10280: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`.

last rebase pass

Dec 13 2023, 3:03 PM

atul updated the diff for D10278: [native] Update `client-db-utils` to accomodate `RawThreadInfos`.

last rebase pass

Dec 13 2023, 3:01 PM

atul updated the diff for D10277: [web] Update `validateStateAndProcessDBOperations` to handle `RawThreadInfos`.

last rebase pass

Dec 13 2023, 3:00 PM

atul updated the diff for D10275: [lib] Update remaining places in `lib` to support `RawThreadInfos`.

last rebase pass

Dec 13 2023, 2:59 PM

atul updated the diff for D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.

will address these flow refactors at the end of the stack.

Dec 13 2023, 2:52 PM

atul updated the diff for D10271: [lib] Add ridiculous branching to `update-thread-read-status-spec` to appease `flow`.

address feedback

Dec 13 2023, 2:47 PM

atul added inline comments to D10271: [lib] Add ridiculous branching to `update-thread-read-status-spec` to appease `flow`.

Dec 13 2023, 2:46 PM

atul updated the diff for D10270: [lib] Add ridiculous branching to `delete-account-spec` to appease `flow`.

final rebase pass

Dec 13 2023, 2:42 PM

atul updated the diff for D10268: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in `shared/updates`.

final rebase pass

Dec 13 2023, 2:41 PM

atul updated the diff for D10243: [lib] Update `lib/types` to accomodate `RawThreadInfos`.

final rebase pass

Dec 13 2023, 2:40 PM

atul added inline comments to D10233: [lib] Simplify `getRelativeMemberInfos`.

Dec 13 2023, 2:39 PM

atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

preemptively fix flow issue that pops up later in stack because of changes to this diff

Dec 13 2023, 2:37 PM

atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

final rebase pass

Dec 13 2023, 2:35 PM

atul updated the diff for D10195: [lib] Update `threadInfoFromRawThreadInfo` to return `MinimallyEncodedThreadInfo`.

final rebase pass

Dec 13 2023, 2:32 PM

atul abandoned D10272: [lib] Introduce `getRelativeMemberInfos` which helps narrow `[Legacy]RawThreadInfos`.

No longer needed.

Dec 13 2023, 2:21 PM

atul added inline comments to D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

Dec 13 2023, 2:19 PM

atul retitled D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants from [lib] Introduce separate `Legacy` and `MinimallyEncoded` variants of `getRelativeMemberInfos` to [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

Dec 13 2023, 2:18 PM

atul updated the diff for D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.

Use @ashoat's implementation of getRelativeMemberInfos instead of splitting into two

Dec 13 2023, 2:15 PM

atul updated the diff for D10295: [keyserver] Move `threadStoreValidator` to `redux-state-responders`.

land

Dec 13 2023, 1:57 PM

atul closed D10233: [lib] Simplify `getRelativeMemberInfos`.

Dec 13 2023, 1:45 PM

atul committed rCOMM1b12b933f5cc: [lib] Simplify `getRelativeMemberInfos` (authored by atul).

[lib] Simplify `getRelativeMemberInfos`

Dec 13 2023, 1:45 PM

atul closed D10227: [native] Rip `LegacyRawThreadInfos` out of `native`.

Dec 13 2023, 1:45 PM

atul committed rCOMMd86606cc1a48: [native] Rip `LegacyRawThreadInfos` out of `native` (authored by atul).

[native] Rip `LegacyRawThreadInfos` out of `native`

Dec 13 2023, 1:45 PM

atul closed D10226: [web] Rip `LegacyRawThreadInfos` out of `web`.

Dec 13 2023, 1:45 PM

atul committed rCOMM3880d57f9884: [web] Rip `LegacyRawThreadInfos` out of `web` (authored by atul).

[web] Rip `LegacyRawThreadInfos` out of `web`

Dec 13 2023, 1:45 PM

atul closed D10225: [lib] Rip `LegacyRawThreadInfos` out of `lib/selector`.

Dec 13 2023, 1:45 PM

atul committed rCOMM4c7b8986f148: [lib] Rip `LegacyRawThreadInfos` out of `lib/selector` (authored by atul).

[lib] Rip `LegacyRawThreadInfos` out of `lib/selector`

Dec 13 2023, 1:45 PM

atul closed D10224: [lib] Replace `LegacyRawThreadInfoS` with `RawThreadInfoS` where simple.

Dec 13 2023, 1:45 PM

atul committed rCOMM4e14dfe653f7: [lib] Replace `LegacyRawThreadInfoS` with `RawThreadInfoS` where simple (authored by atul).

[lib] Replace `LegacyRawThreadInfoS` with `RawThreadInfoS` where simple

Dec 13 2023, 1:45 PM

atul updated the diff for D10233: [lib] Simplify `getRelativeMemberInfos`.

land

Dec 13 2023, 1:43 PM

atul closed D10314: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `ThreadCurrentUserInfo`.

Dec 13 2023, 1:34 PM

atul committed rCOMM7b262ca9855a: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate… (authored by atul).

[lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate…

Dec 13 2023, 1:34 PM

atul closed D10298: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `MemberInfo`s.

Dec 13 2023, 1:34 PM

atul closed D10313: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s.

Dec 13 2023, 1:34 PM

atul committed rCOMM44076541f977: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s (authored by atul).

[lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s

Dec 13 2023, 1:34 PM

atul committed rCOMM5d62218e3325: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate… (authored by atul).

[lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate…

Dec 13 2023, 1:34 PM

atul closed D10210: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`.

Dec 13 2023, 1:34 PM

atul committed rCOMM6b29dad3100d: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo` (authored by atul).

[lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`

Dec 13 2023, 1:34 PM

atul updated the diff for D10314: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `ThreadCurrentUserInfo`.

land

Dec 13 2023, 1:26 PM

atul updated the diff for D10313: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s.

shorter invariant message

Dec 13 2023, 1:26 PM

atul updated the diff for D10298: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `MemberInfo`s.

shorter invariant message

Dec 13 2023, 1:24 PM

atul updated the diff for D10313: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `RoleInfo`s.

collapse loops

Dec 13 2023, 1:21 PM

atul updated the diff for D10298: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `MemberInfo`s.

address feedback: merge loops

Dec 13 2023, 1:18 PM

atul updated the diff for D10210: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`.

land WITH FIXES FROM D10298, D10313, D10314

Dec 13 2023, 1:15 PM

atul closed D10296: [lib] Fix `threadPermissionsFromBitmaskHex` invariant.

Dec 13 2023, 1:12 PM

atul committed rCOMMe40290b7161c: [lib] Fix `threadPermissionsFromBitmaskHex` invariant (authored by atul).

[lib] Fix `threadPermissionsFromBitmaskHex` invariant

Dec 13 2023, 1:12 PM

atul updated the diff for D10296: [lib] Fix `threadPermissionsFromBitmaskHex` invariant.

land what's easy/safe to land to reduce stack

Dec 13 2023, 1:04 PM

atul closed D10223: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.

Dec 13 2023, 12:56 PM

atul committed rCOMM347740333ec0: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]` (authored by atul).

[lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`

Dec 13 2023, 12:56 PM

atul updated the diff for D10223: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.

fix and re-land

Dec 13 2023, 12:53 PM

atul closed D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.

Dec 13 2023, 12:51 PM

atul committed rCOMMc8c3cea3fb65: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync… (authored by atul).

[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync…

Dec 13 2023, 12:51 PM

atul updated the test plan for D10328: [blob] Switch Blob unit tests to autoscaling CI runners.

Dec 13 2023, 12:49 PM

atul updated the diff for D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.

re-land

Dec 13 2023, 12:48 PM

atul updated the diff for D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.

fix up and re-land

Dec 13 2023, 12:47 PM

atul published D10328: [blob] Switch Blob unit tests to autoscaling CI runners for review.

Dec 13 2023, 12:39 PM

atul accepted D10310: [native] Fix failing base64 decode for thumbhash.

Dec 13 2023, 6:49 AM

Dec 12 2023

atul reopened D10223: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.

Dec 12 2023, 8:09 PM

atul reopened D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`.

Dec 12 2023, 8:09 PM

atul added a reverting change for D10211: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync-spec`: rCOMMd18296d7f320: Revert "[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state….

Dec 12 2023, 8:09 PM

atul committed rCOMMd18296d7f320: Revert "[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state… (authored by atul).

Revert "[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state…

Dec 12 2023, 8:09 PM

atul added a reverting change for rCOMM77cc67c2c532: [lib] Introduce `rawThreadInfoValidator` and consume in `threads-state-sync…: rCOMMd18296d7f320: Revert "[lib] Introduce `rawThreadInfoValidator` and consume in `threads-state….

Dec 12 2023, 8:09 PM