In D10891#314115, @ginsu wrote:

Looks good, could you lmk when you land this. I know I made some changes to WebNavigationSettingsSection in my stacks (D10824) so just want to make sure to make changes to that if you land this diff first

land accepted part of stack

rebase and land after additional testing

we should extend the test plan by checking if old clients can work correctly after this change.

rebase, resolve merge conflicts, land

provides nice autocompletion for devs

so this should be consistent with the rest of the codebase

Personally feel like it'd make more sense to put the explanation above the button, but what you have matches the designs.

I guess my initial understanding when I first landed "flip the switch" diff for minimal permissions was correct and we weren't yet persisting threadStore in Redux OR SQLite for non-staff users.

confirmed that there were no regressions with native

Don't really understand the purpose of useStaffContext, would it make more sense to introduce something like useStaffUserHasBeenLoggedIn to consume the context?

Accepting, but think it would make sense to replace invariant with a simple if statement.

Question inline about order of alphabetizing usernames and resolving ENS names

Left two comments, but also assuming that the video in the Test Plan is unfinished? It seems unusual that the selected users don't appear in the modal at all after they've been selected?

Looks good. From a naming standpoint, I think I'd prefer something like previouslySelectedUsers or something along those lines.

fix

address feedback from @tomek

remove whitelines

rebase

rebase

rebase

rebase

rebase

rebase

rebase

land

rebase

land up until D10792