Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 12 2024
Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID
Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID
Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID
Feb 9 2024
Feb 8 2024
Feb 7 2024
Address review - move usingCommServicesAccessToken check into identityInvalidSessionDowngrade
Thank you!
We might need to do something additional to clear the auth metadata from CommCoreModule.
We may also need to call clearSensitiveData.
Feb 6 2024
No, that's intentional. If the recovery fails, we want to "flush" all of the requests so that they fail.
With user profiles we can navigate to our chat with that user. When we do this, we should use the context to close the members sidebar
By flipping sessionRecoveryInProgress to false, we tell CallKeyserverEndpointProvider to flush all waitingCalls using the new cookie.
This code is quite complex and hard to analyse. Moreover, instead of setting canRecoverSession to false, we use a default undefined, and only set to true when we want to allow it. I followed all places where getCallSingleKeyserverEndpoint is used (which is the only place where we set canRecoverSession to true), and it looks like it is indeed never used where paramOverride is used.
It also looks like canRecoverSession i being set to true in all other cases.
I would still love for someone else to review this though
Feb 5 2024
Can you test logging out and in a couple of times?
I don't understand the point of this diff. Do we need to do keyserverStore = { ...keyserverStore }; for some reason?
I know what mechanism you mean, with the REHYDRATE skipping a part of state if it was changed by the reducer, but this code should never change anything on REHYDRATE action, because keyserverStore is not changed by the REHYDRATE action. So the inner ifs (line 102 and 115) will always return false and not execute. And it is very intentional that the keyserver store is not changed on the REHYDRATE action.
It seems odd that the modals would use this context. Can you give an example of how a modal will use it?
Feb 1 2024
If you need CSAT, you can just take it from it redux....
Jan 31 2024
Make reduceBaseNavInfo set the default date ranges
Update types
It would be great if you could also check if running this action with Ashoat's id in payload resets Ashoat's keyserver correctly - this is not included in keyserver-reducer.test.js
Stop resetting theme on logOutActionTypes.started
Address review - following the discussion in ENG-4730 we want to keep updating the currentUserInfo sent by Ashoat's keyserver