Page MenuHomePhabricator
Feed Advanced Search

Feb 12 2024

inka requested changes to D11022: [web] dispatch setAccessTokenActionType after successful identity login on web.
Feb 12 2024, 2:38 AM
inka added inline comments to D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 12 2024, 1:57 AM
inka updated the diff for D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.

Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID

Feb 12 2024, 1:54 AM
inka updated the diff for D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.

Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID

Feb 12 2024, 1:53 AM
inka updated the diff for D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.

Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID

Feb 12 2024, 1:53 AM
inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID

Feb 12 2024, 1:52 AM

Feb 9 2024

inka accepted D11013: [lib][native][web] Replace ashoatKeyserverID in Socket code with keyserverID.
Feb 9 2024, 8:40 AM
inka accepted D11012: [lib] Pass keyserverID to Socket.
Feb 9 2024, 8:37 AM
inka requested review of D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 9 2024, 8:07 AM
inka requested review of D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 9 2024, 7:41 AM
inka requested review of D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 9 2024, 7:38 AM
inka requested review of D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 9 2024, 7:36 AM
inka requested review of D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 9 2024, 7:29 AM

Feb 8 2024

inka added inline comments to D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.
Feb 8 2024, 1:59 AM

Feb 7 2024

inka closed D10965: [lib][web][native] Handle invalidSessionDowngrade for identity actions.
Feb 7 2024, 9:07 AM
inka closed D10963: [web][native] Handle invalidSessionDowngrade for deleteKeyserverAccountActionTypes.success.
Feb 7 2024, 9:07 AM
inka committed rCOMM7a6a2ce0c3d8: [lib][web][native] Handle invalidSessionDowngrade for identity actions (authored by inka).
[lib][web][native] Handle invalidSessionDowngrade for identity actions
Feb 7 2024, 9:07 AM
inka committed rCOMM12b824a049d1: [web][native] Handle invalidSessionDowngrade for… (authored by inka).
[web][native] Handle invalidSessionDowngrade for…
Feb 7 2024, 9:07 AM
inka closed D10962: [lib] Add identityInvalidSessionDowngrade.
Feb 7 2024, 9:07 AM
inka committed rCOMM546bf954bd95: [lib] Add identityInvalidSessionDowngrade (authored by inka).
[lib] Add identityInvalidSessionDowngrade
Feb 7 2024, 9:07 AM
inka updated the diff for D10965: [lib][web][native] Handle invalidSessionDowngrade for identity actions.

Address review - move usingCommServicesAccessToken check into identityInvalidSessionDowngrade

Feb 7 2024, 6:16 AM
inka accepted D10966: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire KeyserverStore.

Thank you!

Feb 7 2024, 4:45 AM
inka accepted D10784: [native][web] migrate keyservers to SQLite.
Feb 7 2024, 4:43 AM
inka added a comment to D10784: [native][web] migrate keyservers to SQLite.

We might need to do something additional to clear the auth metadata from CommCoreModule.
We may also need to call clearSensitiveData.

Feb 7 2024, 4:42 AM
inka accepted D10955: [lib][web][native] handle failed redux migrations.
Feb 7 2024, 4:32 AM
inka added inline comments to D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.
Feb 7 2024, 4:27 AM

Feb 6 2024

inka added a comment to D10949: [lib] Conclude sessionRecoveryInProgress when user cookie is received or session is invalidated.

No, that's intentional. If the recovery fails, we want to "flush" all of the requests so that they fail.

Feb 6 2024, 5:46 AM
inka requested review of D10965: [lib][web][native] Handle invalidSessionDowngrade for identity actions.
Feb 6 2024, 3:37 AM
inka added a comment to D10899: [web] introduce member list sidebar provider.

With user profiles we can navigate to our chat with that user. When we do this, we should use the context to close the members sidebar

Feb 6 2024, 3:18 AM
inka accepted D10934: [lib] refactor keyserver-related actions in `master-reducer` to ops.
Feb 6 2024, 3:10 AM
inka requested review of D10963: [web][native] Handle invalidSessionDowngrade for deleteKeyserverAccountActionTypes.success.
Feb 6 2024, 3:05 AM
inka requested review of D10962: [lib] Add identityInvalidSessionDowngrade.
Feb 6 2024, 2:58 AM
inka added a comment to D10949: [lib] Conclude sessionRecoveryInProgress when user cookie is received or session is invalidated.

By flipping sessionRecoveryInProgress to false, we tell CallKeyserverEndpointProvider to flush all waitingCalls using the new cookie.

Feb 6 2024, 2:16 AM
inka accepted D10951: [lib] Disable keyserver session recovery when paramOverride is specified.

This code is quite complex and hard to analyse. Moreover, instead of setting canRecoverSession to false, we use a default undefined, and only set to true when we want to allow it. I followed all places where getCallSingleKeyserverEndpoint is used (which is the only place where we set canRecoverSession to true), and it looks like it is indeed never used where paramOverride is used.
It also looks like canRecoverSession i being set to true in all other cases.
I would still love for someone else to review this though

Feb 6 2024, 2:03 AM
inka accepted D10950: [lib] Drill sessionRecoveryInProgress through to CallKeyserverEndpointProvider.
Feb 6 2024, 1:21 AM
inka accepted D10948: [lib] Introduce SET_SESSION_RECOVERY_IN_PROGRESS action.
Feb 6 2024, 12:41 AM
inka accepted D10946: [lib] Introduce sessionRecoveryInProgress to ConnectionInfo.
Feb 6 2024, 12:39 AM
inka accepted D10947: [lib] Extract action types constants out of socket-types.js.
Feb 6 2024, 12:28 AM
inka added inline comments to D10934: [lib] refactor keyserver-related actions in `master-reducer` to ops.
Feb 6 2024, 12:13 AM

Feb 5 2024

inka accepted D10787: [web][native] read keyservers from SQLite on app start.

Can you test logging out and in a couple of times?

Feb 5 2024, 2:55 AM
inka accepted D10785: [native][web] start processing keyserver store ops on SQLite.
Feb 5 2024, 2:41 AM
inka accepted D10926: [web] refactor set new session in `redux-setup` to ops.
Feb 5 2024, 2:28 AM
inka accepted D10925: [web] refactor logout in `redux-setup` to ops.
Feb 5 2024, 2:23 AM
inka added inline comments to D10934: [lib] refactor keyserver-related actions in `master-reducer` to ops.
Feb 5 2024, 2:16 AM
inka requested changes to D10934: [lib] refactor keyserver-related actions in `master-reducer` to ops.
Feb 5 2024, 2:14 AM
inka requested changes to D10933: [lib] avoid modifying state on rehydrate action.

I don't understand the point of this diff. Do we need to do keyserverStore = { ...keyserverStore }; for some reason?
I know what mechanism you mean, with the REHYDRATE skipping a part of state if it was changed by the reducer, but this code should never change anything on REHYDRATE action, because keyserverStore is not changed by the REHYDRATE action. So the inner ifs (line 102 and 115) will always return false and not execute. And it is very intentional that the keyserver store is not changed on the REHYDRATE action.

Feb 5 2024, 1:57 AM
inka added inline comments to D10784: [native][web] migrate keyservers to SQLite.
Feb 5 2024, 1:40 AM
inka added a comment to D10899: [web] introduce member list sidebar provider.

It seems odd that the modals would use this context. Can you give an example of how a modal will use it?

Feb 5 2024, 1:21 AM

Feb 1 2024

inka requested changes to D10909: [lib] Add hook for easy access to CSAT.

If you need CSAT, you can just take it from it redux....

Feb 1 2024, 8:29 AM
inka added inline comments to D10899: [web] introduce member list sidebar provider.
Feb 1 2024, 4:24 AM
inka accepted D10900: [web] introduce member list sidebar header.
Feb 1 2024, 4:18 AM
inka added inline comments to D10867: [native] Store access token in Redux.
Feb 1 2024, 3:36 AM
inka closed D10872: [lib] Remove lateResponses on logout.
Feb 1 2024, 3:23 AM
inka committed rCOMM824c39c5a589: [lib] Remove lateResponses on logout (authored by inka).
[lib] Remove lateResponses on logout
Feb 1 2024, 3:23 AM
inka closed D10870: [native] Remove logout / delete account / identity login logic from specific reducers.
Feb 1 2024, 3:23 AM
inka closed D10869: [web] Remove logout / delete account / identity login logic from specific reducers.
Feb 1 2024, 3:23 AM
inka closed D10868: [lib] Remove logout / delete account / identity login logic from specific reducers.
Feb 1 2024, 3:23 AM
inka committed rCOMM4d73659a4cec: [native] Remove logout / delete account / identity login logic from specific… (authored by inka).
[native] Remove logout / delete account / identity login logic from specific…
Feb 1 2024, 3:23 AM
inka committed rCOMMe20f26b445e5: [web] Remove logout / delete account / identity login logic from specific… (authored by inka).
[web] Remove logout / delete account / identity login logic from specific…
Feb 1 2024, 3:23 AM
inka committed rCOMM925785ebd455: [lib] Remove logout / delete account / identity login logic from specific… (authored by inka).
[lib] Remove logout / delete account / identity login logic from specific…
Feb 1 2024, 3:23 AM
inka closed D10860: [native][web] Clear user specific data on identity actions.
Feb 1 2024, 3:23 AM
inka closed D10845: [web][native] Create lists of fields that are not to be removed on identity actions.
Feb 1 2024, 3:23 AM
inka committed rCOMM63edbf4aa371: [native][web] Clear user specific data on identity actions (authored by inka).
[native][web] Clear user specific data on identity actions
Feb 1 2024, 3:23 AM
inka committed rCOMM0e7d3303b747: [web][native] Create lists of fields that are not to be removed on identity… (authored by inka).
[web][native] Create lists of fields that are not to be removed on identity…
Feb 1 2024, 3:23 AM
inka closed D10801: [lib] Add a function for sanitizing the state on identity actions.
Feb 1 2024, 3:23 AM
inka committed rCOMM25526c596bb4: [lib] Add a function for sanitizing the state on identity actions (authored by inka).
[lib] Add a function for sanitizing the state on identity actions
Feb 1 2024, 3:23 AM

Jan 31 2024

inka updated the diff for D10860: [native][web] Clear user specific data on identity actions.

Make reduceBaseNavInfo set the default date ranges

Jan 31 2024, 10:25 AM
inka updated the diff for D10801: [lib] Add a function for sanitizing the state on identity actions.

Update types

Jan 31 2024, 10:08 AM
inka added inline comments to D10801: [lib] Add a function for sanitizing the state on identity actions.
Jan 31 2024, 10:07 AM
inka updated the diff for D10872: [lib] Remove lateResponses on logout.

Rebase

Jan 31 2024, 10:01 AM
inka closed D10795: [lib] Stop reducing data loaded, CSAT, theme and user info on set new session.
Jan 31 2024, 9:59 AM
inka closed D10796: [lib] Refactor set new session in entry, invite links, thread activity reducers.
Jan 31 2024, 9:59 AM
inka closed D10794: [lib] Refactor set new session in calendar query/filters reducers.
Jan 31 2024, 9:59 AM
inka committed rCOMM7d6787ea5517: [lib] Refactor set new session in calendar query/filters reducers (authored by inka).
[lib] Refactor set new session in calendar query/filters reducers
Jan 31 2024, 9:59 AM
inka committed rCOMM4ff24158598d: [lib] Refactor set new session in entry, invite links, thread activity reducers (authored by inka).
[lib] Refactor set new session in entry, invite links, thread activity reducers
Jan 31 2024, 9:59 AM
inka committed rCOMM6118f94a76e9: [lib] Stop reducing data loaded, CSAT, theme and user info on set new session (authored by inka).
[lib] Stop reducing data loaded, CSAT, theme and user info on set new session
Jan 31 2024, 9:59 AM
inka accepted D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops.
Jan 31 2024, 8:05 AM
inka accepted D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops.

It would be great if you could also check if running this action with Ashoat's id in payload resets Ashoat's keyserver correctly - this is not included in keyserver-reducer.test.js

Jan 31 2024, 7:37 AM
inka requested changes to D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops.
Jan 31 2024, 6:15 AM
inka accepted D10882: [lib] Replace `ConnectionInfo.showDisconnectedBar` with `ConnectionInfo.unreachable`.
Jan 31 2024, 1:52 AM
inka updated the diff for D10868: [lib] Remove logout / delete account / identity login logic from specific reducers.

Stop resetting theme on logOutActionTypes.started

Jan 31 2024, 1:44 AM
inka updated the diff for D10795: [lib] Stop reducing data loaded, CSAT, theme and user info on set new session.

Address review - following the discussion in ENG-4730 we want to keep updating the currentUserInfo sent by Ashoat's keyserver

Jan 31 2024, 1:42 AM
inka closed D10783: [lib] Set data loaded to false on delete account.
Jan 31 2024, 1:24 AM
inka committed rCOMM5bc36b2511d4: [lib] Set data loaded to false on delete account (authored by inka).
[lib] Set data loaded to false on delete account
Jan 31 2024, 1:24 AM
inka closed D10778: [web] Handle invalid session downgrade for identity delete account.
Jan 31 2024, 1:24 AM
inka committed rCOMM626d2202ec19: [web] Handle invalid session downgrade for identity delete account (authored by inka).
[web] Handle invalid session downgrade for identity delete account
Jan 31 2024, 1:24 AM

Jan 30 2024

inka updated subscribers of D10784: [native][web] migrate keyservers to SQLite.
Jan 30 2024, 3:09 AM
inka accepted D10772: [lib] refactor setting device token in `keyserver-reducer` to ops.
Jan 30 2024, 1:48 AM
inka accepted D10771: [lib] refactor connection-related actions in `keyserver-reducer` to ops.
Jan 30 2024, 1:47 AM
inka accepted D10843: [lib] Clear connection issue on successful login.
Jan 30 2024, 1:09 AM

Jan 29 2024

inka closed D10661: [lib] Refactor logout in thread activity reducer.
Jan 29 2024, 8:42 AM
inka committed rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer (authored by inka).
[lib] Refactor logout in thread activity reducer
Jan 29 2024, 8:42 AM
inka closed D10659: [lib] Refactor logout in invite links reducer.
Jan 29 2024, 8:42 AM
inka closed D10658: [lib] Refactor logout in keyserver reducer.
Jan 29 2024, 8:42 AM
inka committed rCOMM242e78f9ba70: [lib] Refactor logout in invite links reducer (authored by inka).
[lib] Refactor logout in invite links reducer
Jan 29 2024, 8:42 AM
inka closed D10653: lib] Refactor message reducer.
Jan 29 2024, 8:42 AM
inka closed D10650: [lib] Refactor logout in reduceEntryInfos.
Jan 29 2024, 8:42 AM
inka committed rCOMM635fdc9038fe: [lib] Refactor logout in keyserver reducer (authored by inka).
[lib] Refactor logout in keyserver reducer
Jan 29 2024, 8:42 AM
inka committed rCOMM581f71cd93ec: lib] Refactor message reducer (authored by inka).
lib] Refactor message reducer
Jan 29 2024, 8:42 AM
inka committed rCOMM2ffa6b79192d: [lib] Refactor logout in reduceEntryInfos (authored by inka).
[lib] Refactor logout in reduceEntryInfos
Jan 29 2024, 8:42 AM