rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 19 2022
Apr 19 2022
rebase
rebase
• benschac committed rCOMMd77f80b11afb: [web] [fix] [ENG-731] update thread selected state text (authored by • benschac).
[web] [fix] [ENG-731] update thread selected state text
Fair enough. I thought it would be helpful since we're using the same onClick handler. Not married to it. Happy to abandon.
Apr 18 2022
Apr 18 2022
lets tuple to avoid churn. I don't think that's the right solution.
• benschac committed rCOMM87803ee89059: [landing] [chore] [ENG-1010] fix import order in webpack (authored by • benschac).
[landing] [chore] [ENG-1010] fix import order in webpack
• benschac committed rCOMM2d1aa421404f: [web] [chore] [ENG-1010] fix linting issues (authored by • benschac).
[web] [chore] [ENG-1010] fix linting issues
Per @atul's comment, we can ignore entire files from the config, which is done in this diff: https://phabricator.ashoat.com/D3761
Per @atul comment, we can ignore entire files from the config, which is done in this diff: https://phabricator.ashoat.com/D3761
rebase
rebase
• benschac added inline comments to D3758: [lib,landing,web] [chore] [ENG-1019] move onClick type to lib.
In D3730#103649, @atul wrote:Do we know why this is happening? I would expect that setting the color prop to transparent would make the arrow "invisible."
I'm guessing the underlying SVG has some color value hard-coded and is "visible" because the stroke or fill or whatever is set to the correct color.
I think the right approach here might be looking at selection.json and seeing if there are any hard-coded values for the right-angle-arrow SVG.
Feel free to re-request review if I'm off-base here or missing something
• benschac requested review of D3758: [lib,landing,web] [chore] [ENG-1019] move onClick type to lib.
• benschac added reviewers for D3752: [web] [chore] [ENG-1010] add flow disable comment: tomek, • jacek, • abosh.
• benschac updated the summary of D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config.
• benschac added reviewers for D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config: tomek, • jacek, • abosh.
ty for catching this! you're 100% right:
update colors
Apr 15 2022
Apr 15 2022
diff not needed
• benschac added a comment to D3625: [web] [copy] [ENG-716] update copy to old leave thread content.
diff is no longer needed. closing,
• benschac committed rCOMM3676c64ae33d: [web] [refactor] [ENG-716] modal design to match figma (authored by • benschac).
[web] [refactor] [ENG-716] modal design to match figma
shorthand
• benschac committed rCOMM5c4a83a420bc: [web] [feat] [ENG-972] update modal header to match design (authored by • benschac).
[web] [feat] [ENG-972] update modal header to match design
• benschac committed rCOMM3a07611abc79: [web] [fix] [ENG-716] use cross icon in modal (authored by • benschac).
[web] [fix] [ENG-716] use cross icon in modal
• benschac added 2 blocking reviewer(s) for D3730: [web] [fix] [ENG-1005] arrows visually broken on safari: atul, tomek.
• benschac retitled D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config from [landing] [chore] add disable comments in webpack config to [landing] [chore] [ENG-1010] add disable comments in webpack config.
• benschac retitled D3751: [landing] [chore] [ENG-1010] fix import order in webpack from [landing] [chore] fix import order in webpack to [landing] [chore] [ENG-1010] fix import order in webpack.
• benschac requested review of D3750: [landing] [chore] [ENG-1010] add disable comments in webpack config.
this diff isn't relevant anymore after I refactored the onClickPromoteThread call into a hook in D3746
• benschac updated the summary of D3731: [web] [feat] [ENG-991] add promote thread to menu dropdown.
• benschac added inline comments to D3731: [web] [feat] [ENG-991] add promote thread to menu dropdown.
cleanup
clean up
• benschac updated the summary of D3731: [web] [feat] [ENG-991] add promote thread to menu dropdown.
Apr 14 2022
Apr 14 2022
• benschac updated the summary of D3737: [web] [feat] [ENG-991] add promote api call to promote menu drop down.
• benschac requested review of D3737: [web] [feat] [ENG-991] add promote api call to promote menu drop down.
revert
fix
re add fix
Apr 13 2022
Apr 13 2022
• benschac committed rCOMM43d4681aaa97: [web] [feat] [ENG-716] add icon to modal header (authored by • benschac).
[web] [feat] [ENG-716] add icon to modal header
rebase
• benschac updated the diff for D3625: [web] [copy] [ENG-716] update copy to old leave thread content.
rebase
rebase
rebase
rebase
rebase
fix selector
• benschac updated the summary of D3440: [web] [fix] ENG-766 sidebar sidebar height chopped off + font size.
use withCloseButton prop
• benschac updated the diff for D3539: [web] [feat] [ENG-766] toggle longer arrow for multiple thread sidebars in chat thread list.
rebase
• benschac updated the diff for D3454: [web] [fix] ENG-895 Chat Thread List Menu button and time doesn't match design.
rebase
rebase
• benschac updated the diff for D3440: [web] [fix] ENG-766 sidebar sidebar height chopped off + font size.
rebase
@atul -- I still need review. here. ty
• benschac committed rCOMM9eff5619b322: [web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect (authored by • benschac).
[web] [refactor] [ENG-986] use lib useIsomorphicLayoutEffect
• benschac committed rCOMM53e27e650642: [web] [fix] [ENG-986] replace useLayoutEffect with useEffect (authored by • benschac).
[web] [fix] [ENG-986] replace useLayoutEffect with useEffect
• benschac updated the diff for D3678: [web] [fix] [ENG-986] replace useLayoutEffect with useEffect.
more terse useEffect