Feed Search

Search
Use Results
Edit Query
Hide Query

Apr 18 2023

atul closed D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:20 PM

atul committed rCOMM7ed76f40821b: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency.

Apr 18 2023, 8:20 PM

atul closed D7497: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:20 PM

atul committed rCOMMefe9eb49757d: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:20 PM

atul committed rCOMM61f134825fab: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:20 PM

atul closed D7493: [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:20 PM

atul committed rCOMMca2c754b086c: [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:20 PM

atul added inline comments to D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 8:18 PM

atul published D7502: [native] Pull `EditAvatarBadge` into its own component for review.

Apr 18 2023, 8:14 PM

atul updated the summary of D7499: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency.

Apr 18 2023, 8:08 PM

atul published D7499: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency for review.

Apr 18 2023, 7:47 PM

atul attached a referenced file: F494242: c8ad87.png.

Apr 18 2023, 7:42 PM

atul added inline comments to D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 7:42 PM

atul added inline comments to D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 7:29 PM

atul published D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar` for review.

Apr 18 2023, 7:28 PM

atul retitled D7493: [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar` from [native] Pull `useUploadProcessedMedia` out of `[User/Thread]Avatar`

Apr 18 2023, 7:28 PM

atul retitled D7497: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar` from [native] Pull `useProcessSelectedMedia` out of `[User/Thread]Avatar`

Apr 18 2023, 7:28 PM

atul updated the summary of D7497: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 7:04 PM

atul published D7497: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar` for review.

Apr 18 2023, 7:02 PM

atul requested review of D7493: [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`.

Apr 18 2023, 6:01 PM

atul closed D7492: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`.

Apr 18 2023, 5:26 PM

atul committed rCOMM7cc483349a86: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`.

Apr 18 2023, 5:26 PM

atul closed D7491: [native] Move vector-related components to `native/vectors`.

Apr 18 2023, 5:22 PM

atul committed rCOMM0f965613045c: [native] Move vector-related components to `native/vectors`.

Apr 18 2023, 5:22 PM

atul closed D7490: [native] Move avatar-related components to `native/avatars`.

Apr 18 2023, 5:19 PM

atul committed rCOMM9054c499f971: [native] Move avatar-related components to `native/avatars`.

Apr 18 2023, 5:19 PM

atul requested review of D7492: [native] Naively split `EditAvatar` into `EditUserAvatar` and `EditThreadAvatar`.

Apr 18 2023, 5:14 PM

atul requested review of D7491: [native] Move vector-related components to `native/vectors`.

Apr 18 2023, 5:14 PM

atul requested review of D7490: [native] Move avatar-related components to `native/avatars`.

Apr 18 2023, 5:14 PM

atul closed D7489: [native] Fix construction of `MediaLibrarySelection`.

Apr 18 2023, 4:32 PM

atul committed rCOMM580f1174065e: [native] Fix construction of `MediaLibrarySelection`.

Apr 18 2023, 4:31 PM

atul published D7489: [native] Fix construction of `MediaLibrarySelection` for review.

Apr 18 2023, 4:19 PM

atul added inline comments to D7476: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

Apr 18 2023, 4:19 PM

atul closed D7481: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 3:44 PM

atul committed rCOMM944f05c38c6a: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 3:44 PM

atul updated the diff for D7481: [native] Process and upload image for image avatar in `EditAvatar`.

rebase and land

Apr 18 2023, 3:44 PM

atul added inline comments to D7481: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 3:41 PM

atul updated the diff for D7481: [native] Process and upload image for image avatar in `EditAvatar`.

address feedback

Apr 18 2023, 3:31 PM

atul closed D7476: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

Apr 18 2023, 3:12 PM

atul committed rCOMM8ce8efd3731d: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

Apr 18 2023, 3:12 PM

atul added inline comments to D7481: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 3:11 PM

atul updated the summary of D7481: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 3:01 PM

atul updated the diff for D7476: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

rebase and land

Apr 18 2023, 3:01 PM

atul updated the diff for D7476: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

address feedback

Apr 18 2023, 2:55 PM

atul added a comment to D7476: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

will the callsite have a problem with you returning ?MediaLibrarySelection

Apr 18 2023, 2:51 PM

atul closed D7478: [native] Make `onTranscodingProgress` field of `MediaProcessConfig` optional.

Apr 18 2023, 2:14 PM

atul committed rCOMMe62a683b104e: [native] Make `onTranscodingProgress` field of `MediaProcessConfig` optional.

Apr 18 2023, 2:14 PM

atul updated the diff for D7478: [native] Make `onTranscodingProgress` field of `MediaProcessConfig` optional.

rebase and land

Apr 18 2023, 2:14 PM

atul closed D7477: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

Apr 18 2023, 2:09 PM

atul committed rCOMM6ee32d15dceb: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

Apr 18 2023, 2:09 PM

atul updated the diff for D7477: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

rebase and land

Apr 18 2023, 2:02 PM

atul added inline comments to D7481: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 2:37 AM

atul updated the test plan for D7481: [native] Process and upload image for image avatar in `EditAvatar`.

Apr 18 2023, 1:45 AM

atul published D7481: [native] Process and upload image for image avatar in `EditAvatar` for review.

Apr 18 2023, 1:44 AM

Apr 17 2023

atul published D7478: [native] Make `onTranscodingProgress` field of `MediaProcessConfig` optional for review.

Apr 17 2023, 11:37 PM

atul attached a referenced file: F492344: 35b267.png.

Apr 17 2023, 10:41 PM

atul updated the test plan for D7477: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

Apr 17 2023, 10:41 PM

atul updated the test plan for D7477: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

Apr 17 2023, 10:41 PM

atul requested review of D7477: [native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly.

Apr 17 2023, 10:40 PM

atul requested review of D7476: [native] Introduce `openPhotoGallery` in `EditAvatar` component.

Apr 17 2023, 10:39 PM

atul accepted D7413: Send to the keyserver data necessary to initialize olm session for e2e notifications.

Apr 17 2023, 1:50 PM

atul accepted D7463: Add table to store olm notifications sessions.

Looks correct at a high level. One concern I had was the choice of ascii CHARSET. That isn't a CHARSET that we use elsewhere in create-db or migration-config, so curious as to the reasoning.

Apr 17 2023, 1:44 PM

atul accepted D7452: [native] Install CommUtils JSI module.

Don't have a ton of experience here but makes sense, would be good to amend test plan to make sure that we can call functions in CommCoreModule as before

Apr 17 2023, 1:36 PM

atul accepted D7395: Introduce methods in CommCoreModule to initialize olm session for notifications. Refactor method to get one time keys for primary olm account.

Apr 17 2023, 1:34 PM

atul accepted D7383: Refactor NotificationsCryptoModule. Add methods to initialize olm notifications session..

Apr 17 2023, 1:32 PM

atul edited reviewers for D7381: Implement prekey lifecycle in `CryptoModule`., added: ashoat; removed: atul.

Apr 17 2023, 1:32 PM

atul resigned from D7381: Implement prekey lifecycle in `CryptoModule`..

Defer to @ashoat since he already started giving feedback + has more context

Apr 17 2023, 1:31 PM

atul accepted D7458: [native] update comm icon pack.

Could you share the source SVGs via DropBox or Google Drive or something?

Apr 17 2023, 1:30 PM

Apr 16 2023

atul closed D7435: [keyserver] Fix `avatarUpdateQuery`.

Apr 16 2023, 5:48 PM

atul committed rCOMMb367a4710322: [keyserver] Fix `avatarUpdateQuery`.

Apr 16 2023, 5:48 PM

atul updated the diff for D7435: [keyserver] Fix `avatarUpdateQuery`.

rebase and land

Apr 16 2023, 5:41 PM

Apr 14 2023

atul closed D7437: [keyserver] Fix `updateUserAvatar` query.

Apr 14 2023, 7:57 PM

atul committed rCOMMf3d78381cecc: [keyserver] Fix `updateUserAvatar` query.

Apr 14 2023, 7:57 PM

atul updated the diff for D7437: [keyserver] Fix `updateUserAvatar` query.

rebase and land

Apr 14 2023, 6:51 PM

atul closed D7439: [keyserver] Get rid of `versions` table and related endpoints.

Apr 14 2023, 6:23 PM

atul committed rCOMM3ae2c4ef4551: [keyserver] Get rid of `versions` table and related endpoints.

Apr 14 2023, 6:23 PM

atul updated the diff for D7439: [keyserver] Get rid of `versions` table and related endpoints.

rebase and land

Apr 14 2023, 6:21 PM

atul accepted D7433: [lib] Set correct codeVersion for encrypted media shim.

Apr 14 2023, 3:55 PM

Apr 13 2023

atul accepted D7411: [native] Make AES functions async.

Left generateKey synchronous because it's not computation heavy and promise overhead is not worth it.

Apr 13 2023, 11:17 PM

atul updated the summary of D7437: [keyserver] Fix `updateUserAvatar` query.

Apr 13 2023, 11:03 PM

atul published D7439: [keyserver] Get rid of `versions` table and related endpoints for review.

Apr 13 2023, 11:03 PM

atul added inline comments to D7437: [keyserver] Fix `updateUserAvatar` query.

Apr 13 2023, 10:54 PM

atul requested review of D7437: [keyserver] Fix `updateUserAvatar` query.

Apr 13 2023, 10:40 PM

atul added inline comments to D7435: [keyserver] Fix `avatarUpdateQuery`.

Apr 13 2023, 9:03 PM

atul published D7435: [keyserver] Fix `avatarUpdateQuery` for review.

Apr 13 2023, 9:01 PM

atul closed D7430: [keyserver] Update `updateThread` to handle image avatars.

Apr 13 2023, 8:07 PM

atul committed rCOMM80240c5c3191: [keyserver] Update `updateThread` to handle image avatars.

Apr 13 2023, 8:07 PM

atul updated the diff for D7430: [keyserver] Update `updateThread` to handle image avatars.

address feedback

Apr 13 2023, 7:57 PM

atul accepted D7432: [Treewide] Update h2 crate.

Apr 13 2023, 7:43 PM

atul published D7432: [Treewide] Update h2 crate for review.

Apr 13 2023, 7:43 PM

atul requested review of D7430: [keyserver] Update `updateThread` to handle image avatars.

Apr 13 2023, 5:59 PM

atul added a comment to D7396: [lib] add ops for message store threads.

In D7396#221029, @ashoat wrote:

@atul is rather busy right now and probably won't be able to review anytime soon, but if I recall correctly I think he was the original architect of the message ops, so would be good for him to take a pass here

Apr 13 2023, 5:37 PM

atul closed D7406: [keyserver] Update `updateUserAvatar` to construct `ClientImageAvatar`.

Apr 13 2023, 2:32 PM

atul committed rCOMM928a3c32f387: [keyserver] Update `updateUserAvatar` to construct `ClientImageAvatar`.

Apr 13 2023, 2:32 PM

atul closed D7404: [keyserver] Update `updateUserAvatar` to handle image avatars.

Apr 13 2023, 2:28 PM

atul committed rCOMM92a4f4e73e54: [keyserver] Update `updateUserAvatar` to handle image avatars.

Apr 13 2023, 2:28 PM

atul added a comment to D7409: [services] Make AWS SDK versions consistent.

There is a newer version of AWS SDKs (0.55.0 for aws-{config,types} / 0.25.1 for aws-sdk-*) but they contain too many renames and breaking changes.

Apr 13 2023, 1:47 PM

Apr 12 2023

atul updated the summary of D7406: [keyserver] Update `updateUserAvatar` to construct `ClientImageAvatar`.

Apr 12 2023, 11:38 PM

atul updated the diff for D7406: [keyserver] Update `updateUserAvatar` to construct `ClientImageAvatar`.

cut a newline

Apr 12 2023, 11:28 PM

atul updated the test plan for D7406: [keyserver] Update `updateUserAvatar` to construct `ClientImageAvatar`.

Apr 12 2023, 11:26 PM