move to own function

americanize variable names

consistency

In D7677#227419, @ashoat wrote:

Test plan before / after seems identical? Maybe I'm missing something

readonly

address feedback

In D7638#226562, @ginsu wrote:

I think it would also be good to update uploadSelectedMedia's parameter type which is currently ?MediaLibrarySelection to just MediaLibrarySelection in this diff as well

Don't need this anymore, handled by other diffs

address merge conflicts

land

resolve merge conflicts and address feedback

address feedback before landing

rebase and land

Can you explain a little bit why you opted against using createRecursiveDrawerItemsData? Assume this is what you meant when you said "Considered different approaches, but this seemed the cleanest", but would like a bit more context

rebase and land

Thanks for catching this

rebase + land

Yes this looks right, but are all the changes that are necessary for release landed? As in, if I were to make a release just off of this diff would things be good to go?

PS – a good way to introduce a use case for this "dangling function" would have been to refactor existing migrations to use it.

fix typo

just include

Is there a reason we shouldn't always just include pinnedCount?

I don't think this is correct. You'll exclude pinnedCount if it's 0

check if not null and not undefined instead of truthiness

address feedback

fixup sql formatting