Page MenuHomePhabricator
Feed Advanced Search

May 17 2023

ashoat committed rCOMMf1983bafc7eb: [native] Introduce RegistrationContainer to handle SafeAreaView (authored by ashoat).
[native] Introduce RegistrationContainer to handle SafeAreaView
May 17 2023, 5:26 AM
ashoat committed rCOMMed64f3949075: [native] Add SIWEPanel to ConnectEthereum screen (authored by ashoat).
[native] Add SIWEPanel to ConnectEthereum screen
May 17 2023, 5:26 AM
ashoat closed D7843: [native] Split onClosing and onClosed params to SIWEPanel.
May 17 2023, 5:26 AM
ashoat committed rCOMMf8b83d7961d2: [native] Split onClosing and onClosed params to SIWEPanel (authored by ashoat).
[native] Split onClosing and onClosed params to SIWEPanel
May 17 2023, 5:26 AM

May 16 2023

ashoat accepted D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.
May 16 2023, 1:32 PM
ashoat requested review of D7846: [native] Add loading spinner to RegistrationButton loading variant.
May 16 2023, 12:59 PM
ashoat requested review of D7845: [native] Introduce RegistrationContainer to handle SafeAreaView.
May 16 2023, 12:43 PM
ashoat requested review of D7844: [native] Add SIWEPanel to ConnectEthereum screen.
May 16 2023, 12:28 PM
ashoat requested review of D7843: [native] Split onClosing and onClosed params to SIWEPanel.
May 16 2023, 12:20 PM
ashoat closed D7841: [native] Factor out loading spinner from SIWEPanel.
May 16 2023, 12:01 PM
ashoat committed rCOMM318b4a97c7c5: [native] Factor out loading spinner from SIWEPanel (authored by ashoat).
[native] Factor out loading spinner from SIWEPanel
May 16 2023, 12:01 PM
ashoat closed D7840: [native] Make SIWEPanel more generic.
May 16 2023, 12:01 PM
ashoat committed rCOMMa3a99101985b: [native] Make SIWEPanel more generic (authored by ashoat).
[native] Make SIWEPanel more generic
May 16 2023, 12:01 PM
ashoat requested changes to D7815: Send encrypted notifications to iOS devices.
May 16 2023, 10:09 AM
ashoat accepted D7814: Implement method in NSE to decrypt notification.
May 16 2023, 10:03 AM
ashoat accepted D7813: Implement function to encrypt relevant parts of iOS notification.

One request inline; please address before landing, or feel free to re-request review if you disagree or if I'm missing something

May 16 2023, 9:56 AM
ashoat accepted D7631: Implement utilities and database query wrapper to create new olm session on eht keyserver side.
May 16 2023, 9:52 AM
ashoat added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 16 2023, 9:48 AM
ashoat added a comment to D7789: [native] Introduced new types for Reanimated.

I was asking for links (hyperlinks) to the TypeScript types. In a previous comment I had requested:

May 16 2023, 9:44 AM
ashoat requested review of D7841: [native] Factor out loading spinner from SIWEPanel.
May 16 2023, 7:17 AM
ashoat requested review of D7840: [native] Make SIWEPanel more generic.
May 16 2023, 6:43 AM
ashoat added inline comments to D7837: [web] Added FocusTrap for modals.
May 16 2023, 6:13 AM
ashoat added inline comments to D7823: [web] Added EditTextMessage component.
May 16 2023, 6:07 AM
ashoat requested changes to D7775: [native] Use MessageSearchContent.

since hooks cannot be called conditionally

May 16 2023, 6:04 AM
ashoat accepted D7803: [keyserver] Add thumbhash to upload endpoints.
May 16 2023, 6:00 AM
ashoat closed D7834: [native] Introduce outline RegistrationButton variant.
May 16 2023, 5:59 AM
ashoat committed rCOMM33cbe3577a6b: [native] Introduce outline RegistrationButton variant (authored by ashoat).
[native] Introduce outline RegistrationButton variant
May 16 2023, 5:59 AM
ashoat closed D7832: [native] Introduce RegistrationButtonContainer.
May 16 2023, 5:59 AM
ashoat closed D7831: [native] Remove useStyles call from RegistrationContentContainer.
May 16 2023, 5:59 AM
ashoat committed rCOMM63c7412fe68b: [native] Introduce RegistrationButtonContainer (authored by ashoat).
[native] Introduce RegistrationButtonContainer
May 16 2023, 5:59 AM
ashoat committed rCOMMdd8352994644: [native] Remove useStyles call from RegistrationContentContainer (authored by ashoat).
[native] Remove useStyles call from RegistrationContentContainer
May 16 2023, 5:59 AM
ashoat closed D7829: [native] Rename RegistrationContainer to RegistrationContentContainer.
May 16 2023, 5:59 AM
ashoat closed D7826: [native] Disable overscroll for RegistrationContainer on iOS.
May 16 2023, 5:59 AM
ashoat committed rCOMM08bf2853b10b: [native] Disable overscroll for RegistrationContainer on iOS (authored by ashoat).
[native] Disable overscroll for RegistrationContainer on iOS
May 16 2023, 5:59 AM
ashoat committed rCOMM9e3db4822cc4: [native] Rename RegistrationContainer to RegistrationContentContainer (authored by ashoat).
[native] Rename RegistrationContainer to RegistrationContentContainer
May 16 2023, 5:59 AM
ashoat accepted D7791: [native] Added animation to the highlight of edited message.
May 16 2023, 5:56 AM
ashoat requested changes to D7789: [native] Introduced new types for Reanimated.

Can you link the TypeScript types you used as inspiration? It will make review a lot easier

May 16 2023, 5:54 AM
ashoat added inline comments to D7822: [web] Added ChatInputTextArea component.
May 16 2023, 5:50 AM
ashoat accepted D7740: [native] Add a header componnent with a search bar.

Thanks, this makes sense to me. cc @ted

May 16 2023, 5:48 AM
ashoat requested review of D7834: [native] Introduce outline RegistrationButton variant.
May 16 2023, 4:45 AM
ashoat requested review of D7832: [native] Introduce RegistrationButtonContainer.
May 16 2023, 4:36 AM
ashoat requested review of D7831: [native] Remove useStyles call from RegistrationContentContainer.
May 16 2023, 4:29 AM
ashoat requested review of D7829: [native] Rename RegistrationContainer to RegistrationContentContainer.
May 16 2023, 4:26 AM
ashoat requested review of D7826: [native] Disable overscroll for RegistrationContainer on iOS.
May 16 2023, 3:59 AM
ashoat closed D7821: [native] Vertically center Ethereum logo in ConnectEthereum.
May 16 2023, 3:36 AM
ashoat committed rCOMM1593f46a2145: [native] Vertically center Ethereum logo in ConnectEthereum (authored by ashoat).
[native] Vertically center Ethereum logo in ConnectEthereum
May 16 2023, 3:36 AM

May 15 2023

ashoat requested review of D7821: [native] Vertically center Ethereum logo in ConnectEthereum.
May 15 2023, 5:32 PM
ashoat accepted D7804: Add thumbhash field to multimedia messages.

This diff is huge and it's hard to tell if it's "exhaustive" (eg. that everything has been covered).

May 15 2023, 12:42 PM
ashoat requested changes to D7803: [keyserver] Add thumbhash to upload endpoints.

Only requesting changes because I think you accidentally left a sleep call in there

May 15 2023, 12:34 PM
ashoat resigned from D7780: [native] Implement thumbhash generation on Android.

Can you clarify why you named the folder third_party in D7779 but thirdparty here?

May 15 2023, 12:24 PM
ashoat accepted D7779: [native] Implement thumbhash generation on iOS.
May 15 2023, 12:08 PM
ashoat committed rCOMM3cd8ee280988: [native] Introduce designSystemColors to colors.js (authored by ashoat).
[native] Introduce designSystemColors to colors.js
May 15 2023, 11:15 AM
ashoat closed D7820: [native] Introduce designSystemColors to colors.js.
May 15 2023, 11:15 AM
ashoat added a reverting change for D7820: [native] Introduce designSystemColors to colors.js: rCOMMbad54c31c17f: Revert "[native] Introduce designSystemColors to colors.js".
May 15 2023, 11:14 AM
ashoat added a reverting change for rCOMM16044bf5ac63: [native] Introduce designSystemColors to colors.js: rCOMMbad54c31c17f: Revert "[native] Introduce designSystemColors to colors.js".
May 15 2023, 11:14 AM
ashoat committed rCOMMbad54c31c17f: Revert "[native] Introduce designSystemColors to colors.js" (authored by ashoat).
Revert "[native] Introduce designSystemColors to colors.js"
May 15 2023, 11:14 AM
ashoat reopened D7820: [native] Introduce designSystemColors to colors.js.
May 15 2023, 11:14 AM
ashoat closed D7820: [native] Introduce designSystemColors to colors.js.
May 15 2023, 11:14 AM
ashoat committed rCOMM16044bf5ac63: [native] Introduce designSystemColors to colors.js (authored by ashoat).
[native] Introduce designSystemColors to colors.js
May 15 2023, 11:14 AM
ashoat requested review of D7820: [native] Introduce designSystemColors to colors.js.
May 15 2023, 11:00 AM
ashoat added inline comments to D7740: [native] Add a header componnent with a search bar.
May 15 2023, 10:45 AM
ashoat abandoned D7819: [DO NOT REVIEW] Dummy diff 2 to test Ted's new Herald rule.
May 15 2023, 10:20 AM
ashoat abandoned D7818: [DO NOT REVIEW] Dummy diff to test Ted's new Herald rule.
May 15 2023, 10:19 AM
ashoat published D7819: [DO NOT REVIEW] Dummy diff 2 to test Ted's new Herald rule for review.
May 15 2023, 10:19 AM
ashoat published D7818: [DO NOT REVIEW] Dummy diff to test Ted's new Herald rule for review.
May 15 2023, 10:18 AM
ashoat added inline comments to D7797: Implement olm session updater that has encrypting functionality.
May 15 2023, 9:59 AM
ashoat requested changes to D7813: Implement function to encrypt relevant parts of iOS notification.

Back to you

May 15 2023, 9:57 AM
ashoat added a comment to D7813: Implement function to encrypt relevant parts of iOS notification.

I can't tell where these functions will be used, so it's a little harder to review

May 15 2023, 9:57 AM
ashoat resigned from D7781: [landing] animate mobile nav component.

Memoization concern has been addressed; will leave the rest of the review to the original selected reviewers

May 15 2023, 9:54 AM
ashoat added inline comments to D7744: [native] Check install referrer on Android.
May 15 2023, 9:46 AM
ashoat accepted D7744: [native] Check install referrer on Android.
May 15 2023, 9:46 AM
ashoat accepted D7751: [native] Introduce a hook that allows running an effect just once per installation.

Thanks, this is much safer!

May 15 2023, 9:39 AM
ashoat added a reviewer for D7806: [keyserver] Validate notifications: marcin.

Might be good for @marcin to take a look as well, as he is very familiar with this code

May 15 2023, 9:36 AM
ashoat added inline comments to D7805: [keyserver] Use platform details in validateOutput.
May 15 2023, 9:35 AM
ashoat added inline comments to D7570: Implement prekey lifecycle on the keyserver.
May 15 2023, 8:58 AM
ashoat closed D7812: Update to @commapp/olm@0.0.10.
May 15 2023, 8:56 AM
ashoat committed rCOMM943eda4a9312: Update to @commapp/olm@0.0.10 (authored by ashoat).
Update to @commapp/olm@0.0.10
May 15 2023, 8:56 AM
ashoat requested review of D7812: Update to @commapp/olm@0.0.10.
May 15 2023, 8:27 AM
ashoat added a comment to D7796: Implement methods in NotificationsCryptoModule to decrypt data.

I confirmed with @anunay that we don't need this check and can remove it

May 15 2023, 7:27 AM
ashoat added inline comments to D7797: Implement olm session updater that has encrypting functionality.
May 15 2023, 6:38 AM
ashoat added a comment to D7758: [native] Add C++ function to decode base64.

If this was copy-pasted you should follow the third_party approach we've outlined before and include the LICENSE

May 15 2023, 6:37 AM
ashoat added inline comments to D7780: [native] Implement thumbhash generation on Android.
May 15 2023, 6:36 AM
ashoat added inline comments to D7740: [native] Add a header componnent with a search bar.
May 15 2023, 6:33 AM
ashoat added inline comments to D7791: [native] Added animation to the highlight of edited message.
May 15 2023, 6:29 AM
ashoat added a comment to D7789: [native] Introduced new types for Reanimated.

It looks like you're missing some parameters for types such as InterpolateColor. Can you find the TypeScript types and try to base your new types on those, and make sure to include all relevant params?

May 15 2023, 6:25 AM

May 13 2023

ashoat added inline comments to D7780: [native] Implement thumbhash generation on Android.
May 13 2023, 11:59 AM
ashoat added inline comments to D7777: [native] Add search button to chat header.
May 13 2023, 11:57 AM
ashoat requested changes to D7774: [native] Add MessageSearchContent.
May 13 2023, 11:56 AM
ashoat added a comment to D7775: [native] Use MessageSearchContent.

Can you explain more about the distinction between MessageSearch and MessageSearchContent? Wondering why they're separated, and what each is responsible for

May 13 2023, 11:52 AM

May 12 2023

ashoat added inline comments to D7774: [native] Add MessageSearchContent.
May 12 2023, 9:41 AM
ashoat accepted D7773: [native] Add message search screen.
May 12 2023, 9:40 AM
ashoat accepted D7770: [native] Extract function for modyfing items to be displayed in MessageResult.
May 12 2023, 9:37 AM
ashoat accepted D7798: Change properties of olm account updater so that the callback can use pickling key as well.
May 12 2023, 9:31 AM
ashoat requested changes to D7631: Implement utilities and database query wrapper to create new olm session on eht keyserver side.
May 12 2023, 9:30 AM
ashoat accepted D7797: Implement olm session updater that has encrypting functionality.
May 12 2023, 9:25 AM
ashoat accepted D7796: Implement methods in NotificationsCryptoModule to decrypt data.

I don't see the reason the ckeck for matching inbound sessions every time we receive a message.

May 12 2023, 9:21 AM
ashoat added inline comments to D7740: [native] Add a header componnent with a search bar.
May 12 2023, 9:15 AM
ashoat accepted D7792: [native] Don’t display edit mode when user changes thread.
May 12 2023, 8:53 AM
ashoat requested changes to D7789: [native] Introduced new types for Reanimated.

Back to you for extra details

May 12 2023, 2:19 AM
ashoat requested changes to D7791: [native] Added animation to the highlight of edited message.
May 12 2023, 2:18 AM