update copy
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 18 2023
Jul 18 2023
ginsu updated the summary of D8537: [landing] introduce multi paragraph functionality in CompetitorFeature.
ginsu requested review of D8537: [landing] introduce multi paragraph functionality in CompetitorFeature.
Jul 17 2023
Jul 17 2023
updated copy still works and looks great! will update diff momentarily with these new changes
address comments
Jul 13 2023
Jul 13 2023
address comments
ginsu requested changes to D8445: [native] Prevent duplicate role names in one community on the client.
Code looks good, but I feel that navigating the user away from the create role screen on an error is not a great experience. If I encountered an error because I chose a duplicate name, as a user I would expect that I would stay on the same page so that I could quickly fix the name and try again.
sweet thanks for sharing the video!
Jul 12 2023
Jul 12 2023
ginsu added a comment to D8431: [native] Display loading indicator while role creation is in progress.
Could you post a pic/video of the spinner in the test plan so that we can see what it looks like. Thanks
looks great!
thanks for fixing this!
Jul 11 2023
Jul 11 2023
Some concerns with the size prop
ginsu accepted D8428: [native] Conditionally retrieve threadInfo from redux store to show newly created roles.
Looks good, but just want to clarify my understanding of your last point in the summary:
few minor nits inline, but looks good!
ginsu committed rCOMM2b30b991db77: [lib/native/web] add user edit icon to comm icon pack (authored by ginsu).
[lib/native/web] add user edit icon to comm icon pack
[native] fix emoji keyboard theme colors
rebase before landing
rebase before landing
Jul 10 2023
Jul 10 2023
use rsquo
use rsquo
ginsu retitled D8031: [landing] introduce keybase competitor data from DRAFT [landing] introduce keybase competitor data to [landing] introduce keybase competitor data.
populate data with copy
Jul 7 2023
Jul 7 2023
ginsu committed rCOMMd738d9261ff9: [native] default selectMultipleEmojis to false for emoji keyboard (authored by ginsu).
[native] default selectMultipleEmojis to false for emoji keyboard
ginsu updated the diff for D8319: [native] default selectMultipleEmojis to false for emoji keyboard.
rebase before landing
[native] fix newer emojis crashing the app
Does this fix a bug that is live in production? If so, can you please coordinate with @atul to get a new release out?
Jul 6 2023
Jul 6 2023
address comments
Let's fix the rolePanelNameEntry color and the rolePanelCountEntry. Sorry should have caught this in my first round of review
Adding @ashoat as a reviewer since I am introducing a new color variable
Jul 5 2023
Jul 5 2023
Looks good now, thanks for addressing all the feedback!
ginsu committed rCOMM864aeee11a51: [native] switch getViewerAlreadySelectedMessageReactions to… (authored by ginsu).
[native] switch getViewerAlreadySelectedMessageReactions to…
ginsu updated the diff for D8410: [native] switch getViewerAlreadySelectedMessageReactions to useGetViewerAlreadySelectedMessageReactions.
address comments
ginsu committed rCOMM63eac315a98a: [native] remove unnecessary async/await in emoji keyboard (authored by ginsu).
[native] remove unnecessary async/await in emoji keyboard
Jul 3 2023
Jul 3 2023
ginsu added inline comments to D8288: [lib/native] introduce getViewerAlreadySelectedMessageReactions.
Jun 30 2023
Jun 30 2023
ginsu committed rCOMMa29d491e68f1: [landing ] add rohan and patryk to the team page (authored by ginsu).
[landing ] add rohan and patryk to the team page
Jun 28 2023
Jun 28 2023
thanks for addressing this!
Jun 27 2023
Jun 27 2023
ginsu committed rCOMM6119ef78e56f: [lib/native] add user-filled to comm icons pack (authored by ginsu).
[lib/native] add user-filled to comm icons pack
add icons CommIcons type on web
address comments
Jun 26 2023
Jun 26 2023
ginsu accepted D8318: [lib] Move `selectFromGalleryAndUpdateUserAvatar` from provider to `avatar-hooks`.
really like this idea of having hooks be platform-specific and providers being platform-agnostic
ginsu published D8319: [native] default selectMultipleEmojis to false for emoji keyboard for review.
Was this based off of comm-icon-config.json from the repo?
ginsu committed rCOMM50c0adf387b7: [native] change color theme of the emoji keyboard based on the app theme (authored by ginsu).
[native] change color theme of the emoji keyboard based on the app theme
[native] style emoji keyboard
ginsu updated the diff for D8310: [native] change color theme of the emoji keyboard based on the app theme.
rebase before landing
rebase before landing
Jun 24 2023
Jun 24 2023
Jotted down my reasoning here: https://phab.comm.dev/D8249?id=27866#inline-53090
Jun 23 2023
Jun 23 2023
ginsu committed rCOMM9be393b234f2: [lib/native] introduce getViewerAlreadySelectedMessageReactions (authored by ginsu).
[lib/native] introduce getViewerAlreadySelectedMessageReactions
ginsu committed rCOMMb400d0b364f6: [native] introudce selectMultipleEmojis and alreadySelectedEmojis to… (authored by ginsu).
[native] introudce selectMultipleEmojis and alreadySelectedEmojis to…
[native] persist recently used emojis