Page MenuHomePhabricator
Feed Advanced Search

Nov 14 2023

michal accepted D9869: [Flow202][keyserver][skip-ci] [20/x] Add any-casts for invalid validator tests.

Alternatively we could use //$FlowExpectedError, but doesn't really matter

Nov 14 2023, 7:34 AM
michal accepted D9866: [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of accountUpdateInputValidator.

As an alternative, in a few places where I had to deal with a deprecated field I typed them as an optional empty field (e.g. email?: empty):

  • we don't need to introduce a new type
  • flow still guards us against using the deprecated field on the server
Nov 14 2023, 7:34 AM
michal accepted D9861: [Flow202][keyserver][skip-ci] [12/x] Address type errors with getInitialReduxStateResponder.
Nov 14 2023, 7:30 AM
michal accepted D9818: Refactor Windows push code to match conventions for other platforms.
Nov 14 2023, 7:21 AM
michal accepted D9882: [lib] Calculate currentAsOf for every keyserver in mergeNewMessages.
Nov 14 2023, 7:13 AM
michal accepted D9881: [lib] Add function for finding the time of the newest message per keyserver.
Nov 14 2023, 7:06 AM
michal accepted D9879: [keyserver][lib] Update freshMessageStore to return currentAsOf for all keyservers.
Nov 14 2023, 7:04 AM
michal added inline comments to D9820: [lib] Refactor keyserver reducer pt.2 - early return.
Nov 14 2023, 7:01 AM
michal accepted D9852: [Flow202][keyserver][skip-ci] [4/x] Address type error in rescindPushNotifs.
Nov 14 2023, 6:21 AM
michal requested changes to D9820: [lib] Refactor keyserver reducer pt.2 - early return.
Nov 14 2023, 6:17 AM
michal accepted D9816: [lib] Inline reduceDeviceToken.
Nov 14 2023, 6:11 AM
michal accepted D9815: [lib] Inline reduceConnectionInfo pt.2.
Nov 14 2023, 6:07 AM
michal accepted D9803: [lib] Inline reduceConnectionInfo pt.1.
Nov 14 2023, 5:25 AM
michal added inline comments to D9764: [lib] Inline reduceLastCommunicatedPlatformDetails.
Nov 14 2023, 5:12 AM
michal added inline comments to D9763: [lib] Inline reduceUpdatesCurrentAsOf.
Nov 14 2023, 4:10 AM
michal accepted D9750: [lib] Refactor keyserver reducer pt.1.
Nov 14 2023, 4:06 AM

Nov 9 2023

michal updated the diff for D9760: [CI] Fix macOS GitHub CI.

Add the python node-gyp fix to all js CI workflows.

Nov 9 2023, 6:52 AM

Nov 8 2023

michal requested review of D9760: [CI] Fix macOS GitHub CI.
Nov 8 2023, 1:48 PM

Nov 7 2023

michal accepted D9650: [keyserver][web] Refactor getInitialReduxState action.
Nov 7 2023, 3:46 AM
michal accepted D9661: Decrypt encrypted web notifications in service worker.

Could we amend the test plan with testing on safari and testing of incorrectly decrypted notifications?

Nov 7 2023, 3:43 AM
michal accepted D9620: Encrypt notifications for web clients supporting decryption.
Nov 7 2023, 3:25 AM
michal accepted D9727: [keyserver] add log while receiving response to a non-existing Tunnelbroker request.
Nov 7 2023, 3:04 AM
michal accepted D9730: [lib/keyserver] configure Tunnelbroker URL.
Nov 7 2023, 3:04 AM
michal accepted D9648: [lib][web][native] Refactor actions in user-actions.js pt.3 - login.
Nov 7 2023, 3:03 AM
michal added a comment to D9650: [keyserver][web] Refactor getInitialReduxState action.

We might also want to remove invite secret from urlinfo

Nov 7 2023, 2:44 AM
michal added inline comments to D9648: [lib][web][native] Refactor actions in user-actions.js pt.3 - login.
Nov 7 2023, 2:38 AM
michal updated the diff for D9739: [web] Move getSafariEncryptionKey to initPromise.

Readonly

Nov 7 2023, 2:20 AM
michal accepted D9645: [lib][web][native] Refactor actions in user-actions.js pt.2.
Nov 7 2023, 2:15 AM
michal accepted D9640: [keyserver][lib] Remove id from LoggedOutUserInfo.
Nov 7 2023, 2:12 AM
michal accepted D9622: [lib][web][native] Move deviceToken to keyserverStore.
Nov 7 2023, 2:11 AM
michal updated the diff for D9739: [web] Move getSafariEncryptionKey to initPromise.

Additionaly link the init in progress status to the init promise with types, so we won't get this situation in the future (an async operation between setting the status and setting the init promise).

Nov 7 2023, 1:45 AM
michal requested review of D9739: [web] Move getSafariEncryptionKey to initPromise.
Nov 7 2023, 1:12 AM

Nov 6 2023

michal requested review of D9722: [lib] Remove withCredentials on upload blob call.
Nov 6 2023, 2:10 AM
michal accepted D9721: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.
Nov 6 2023, 1:37 AM
michal accepted D9718: [Flow202][electron-update-server][skip-ci] [3/3] Fix Flow issues in electron-update-server.
Nov 6 2023, 1:32 AM
michal accepted D9717: [Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef for express throughout our codebase.
Nov 6 2023, 1:30 AM
michal accepted D9716: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run Prettier on flow-typed folders.
Nov 6 2023, 1:30 AM
michal accepted D9714: [Flow202][lib][skip-ci] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js.
Nov 6 2023, 1:28 AM
michal accepted D9670: [identity] pull out CORS logic.
Nov 6 2023, 1:25 AM

Nov 3 2023

michal accepted D9679: [identity] check if wallet address is reserved in LoginWalletUser RPC.
Nov 3 2023, 8:22 AM
michal accepted D9678: [identity] add RPC for logging in users with reserved wallet addresses.

LGTM but I haven't worked with identity service

Nov 3 2023, 8:22 AM
michal added inline comments to D9650: [keyserver][web] Refactor getInitialReduxState action.
Nov 3 2023, 7:57 AM
michal added a comment to D9640: [keyserver][lib] Remove id from LoggedOutUserInfo.

Will this break logging out on older clients?

Nov 3 2023, 7:51 AM
michal accepted D9636: [keyserver][lib][native] Refactor getVersion action.
Nov 3 2023, 7:45 AM
michal accepted D9628: [lib][web][native] Refactor setDeviceToken action.
Nov 3 2023, 7:39 AM
michal added a comment to D9622: [lib][web][native] Move deviceToken to keyserverStore.

Don't we need a migration for web too?

Nov 3 2023, 7:29 AM
michal accepted D9617: [web] implement screen for testing Tunnelbroker.
Nov 3 2023, 7:06 AM
michal accepted D9630: [Tunnelbroker] implement socket Heartbeats.
Nov 3 2023, 6:53 AM
michal accepted D9618: [native] implement screen for testing Tunnelbroker.
Nov 3 2023, 6:50 AM
michal accepted D9371: [lib][web][native] Refactor actions in thread-actions.js pt.2.
Nov 3 2023, 5:19 AM
michal accepted D9356: [lib][web][native] Refactor actions in entry-actions.js.
Nov 3 2023, 5:17 AM
michal accepted D9644: [lib] Add function for splitting calendar query per keyserver.
Nov 3 2023, 5:13 AM
michal accepted D9632: [lib] implement socket Heartbeats with Tunnelbroker.
Nov 3 2023, 5:03 AM
michal accepted D9631: [keyserver] implement Tunnelbroker socket Heartbeats.
Nov 3 2023, 4:56 AM
michal added inline comments to D9630: [Tunnelbroker] implement socket Heartbeats.
Nov 3 2023, 4:46 AM
michal added inline comments to D9618: [native] implement screen for testing Tunnelbroker.
Nov 3 2023, 4:22 AM
michal added inline comments to D9617: [web] implement screen for testing Tunnelbroker.
Nov 3 2023, 4:19 AM
michal accepted D9623: [keyserver] implement socket and update code to interact with Tunnelbroker API.
Nov 3 2023, 4:15 AM
michal accepted D9611: [lib] handle Tunnelbroker messages.

Please check the console.warn/error before landing but looks good.

Nov 3 2023, 4:07 AM
michal added a comment to D9670: [identity] pull out CORS logic.

Nice to see the magic string constants removed!

Nov 3 2023, 3:51 AM

Nov 2 2023

michal accepted D9610: [native] create Tunnelbroker session.
Nov 2 2023, 9:00 AM
michal accepted D9609: [web] create Tunnelbroker session.
Nov 2 2023, 9:00 AM
michal added inline comments to D9611: [lib] handle Tunnelbroker messages.
Nov 2 2023, 7:24 AM
michal accepted D9616: [lib] implement sending messages to Tunnelbroker.
Nov 2 2023, 7:21 AM
michal added inline comments to D9623: [keyserver] implement socket and update code to interact with Tunnelbroker API.
Nov 2 2023, 7:07 AM
michal updated the test plan for D9500: [keyserver] Remove cookieSources.
Nov 2 2023, 6:18 AM
michal accepted D9578: [Tunnelbroker] add recipient confirmation tests.

[...] I guess its due to pt 4 - we cannot check if websocket is empty without hacky ways like timeouts

Nov 2 2023, 6:09 AM
michal accepted D9577: [Tunnelbroker] add recipient confirmation to Tunnelbroker.
Nov 2 2023, 5:59 AM
michal added inline comments to D9500: [keyserver] Remove cookieSources.
Nov 2 2023, 4:31 AM
michal updated the diff for D9500: [keyserver] Remove cookieSources.

Update types and client_version_unsupported logic

Nov 2 2023, 4:31 AM

Oct 31 2023

michal added inline comments to D9610: [native] create Tunnelbroker session.
Oct 31 2023, 10:45 AM

Oct 30 2023

michal added inline comments to D9610: [native] create Tunnelbroker session.
Oct 30 2023, 10:05 AM
michal accepted D9607: [lib] implement creating Tunnelbroker socket.
Oct 30 2023, 10:00 AM
michal added inline comments to D9606: [lib] introduce Tunnelbroker Context.
Oct 30 2023, 9:55 AM
michal added a comment to D9623: [keyserver] implement socket and update code to interact with Tunnelbroker API.

Do we need to handle socket reconnection?

Oct 30 2023, 9:35 AM
michal added a comment to D9623: [keyserver] implement socket and update code to interact with Tunnelbroker API.

Should we implement some kind of timeout for the promises?

Oct 30 2023, 9:27 AM
michal accepted D9590: [native] introduce Add keyserver screen UI.

LGTM although I haven't been really working with react native code lately. Do the diffs for filling in the missing // TODO exist?

Oct 30 2023, 9:09 AM
michal accepted D9591: [native] introduce addKeyserverActionType.
Oct 30 2023, 9:09 AM
michal requested review of D9629: [keyserver] Remove table prefix in sql query.
Oct 30 2023, 7:41 AM
michal updated the diff for D9503: [web/keyserver] Separate web and keyserver versions.

Rebase

Oct 30 2023, 7:19 AM
michal updated the diff for D9398: [nix] Create new url facts.

Rebase migration

Oct 30 2023, 7:18 AM
michal updated the diff for D9396: [keyserver] Update CORS.

Rebase before landing

Oct 30 2023, 7:17 AM
michal added inline comments to D9598: [keyserver] Set last_message correctly for threads.
Oct 30 2023, 6:47 AM
michal planned changes to D9452: [keyserver] Separate webapp and keyserver endpoints.

Setting as "plan changes" because it needs to be defered for a while to let web clients migrate (start using squadcal endpoints instead of web.comm.app).

Oct 30 2023, 6:12 AM
michal abandoned D8680: [keyserver] Correctly set memberships last_message.

Replaced by D9598

Oct 30 2023, 6:09 AM
michal accepted D9596: [lib] define Tunnelbroker API in Flow types.

Nit: I would prefer to see the validators just below the corresponding type definition. IMO it makes it harder for people to forget to update validators when updating the types.

Oct 30 2023, 6:07 AM
michal accepted D9595: [Tunnelbroker] implement sending response after session creation attempt.
Oct 30 2023, 5:50 AM
michal updated the diff for D8492: [keyserver] Always fetch the latest message for threads.

Fix formatting

Oct 30 2023, 5:18 AM
michal updated the diff for D8492: [keyserver] Always fetch the latest message for threads.

Rebase

Oct 30 2023, 4:39 AM
michal updated the diff for D9605: [keyserver] Fix existing memberships.last_message in migration.

Use genesis.id

Oct 30 2023, 4:38 AM
michal updated the diff for D9598: [keyserver] Set last_message correctly for threads.

Fixes

Oct 30 2023, 4:35 AM

Oct 27 2023

michal added reviewers for D9605: [keyserver] Fix existing memberships.last_message in migration: tomek, inka, ashoat.

Thanks for noticing that, not sure how I missed it

Oct 27 2023, 9:49 AM
michal added a comment to D9598: [keyserver] Set last_message correctly for threads.

This gist contains both a SELECT query based on the UPDATE query and an UPDATE query. Both of these queries show equivalent results under EXPLAIN so I think they should have the same performance. They are both set for my user (3033752 which I took from the table in ENG-5287) and the genesis thread (1).

Oct 27 2023, 8:59 AM
michal updated the diff for D9396: [keyserver] Update CORS.

(indentation fixes, I forgot to commit them)

Oct 27 2023, 8:14 AM
michal updated the diff for D9396: [keyserver] Update CORS.

Indentation and naming fixes

Oct 27 2023, 8:13 AM
michal updated the test plan for D9451: [web/native/keyserver] Start using new url facts.
Oct 27 2023, 7:55 AM
michal updated the diff for D9451: [web/native/keyserver] Start using new url facts.

Updated the docs issues, amended the test plan for docker keyserver deploy.

Oct 27 2023, 7:54 AM
michal updated the test plan for D9396: [keyserver] Update CORS.
Oct 27 2023, 7:52 AM
michal updated the test plan for D9396: [keyserver] Update CORS.
Oct 27 2023, 7:51 AM
michal updated the test plan for D9396: [keyserver] Update CORS.
Oct 27 2023, 7:50 AM