Thanks for fixing this, glad Flow will prevent this sort of thing in the future
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Nov 27 2023
Nov 27 2023
atul accepted D9991: [Flow202][native][skip-ci] [7/x] Fix leftover this keyword in ChatThreadList hook conversion.
Nov 22 2023
Nov 22 2023
Nov 21 2023
Nov 21 2023
atul accepted D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Changes wrt minimal permissions work looks correct
atul updated the test plan for D9947: [web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s.
atul added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
atul published D9947: [web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s for review.
atul added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
Nov 20 2023
Nov 20 2023
atul updated the diff for D9927: [lib] Update all-but-one instance of `RelativeMemberInfo` with `RelativeMemberInfo|MinimallyEncodedRelativeMemberInfo`.
land
atul updated the diff for D9927: [lib] Update all-but-one instance of `RelativeMemberInfo` with `RelativeMemberInfo|MinimallyEncodedRelativeMemberInfo`.
rebase and land
Nov 18 2023
Nov 18 2023
Nov 16 2023
Nov 16 2023
atul updated the diff for D9917: [web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching.
land
atul updated the diff for D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
land
atul added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
atul published D9917: [web] Pull out `filterOut[Parent/Other]MembersWithENSNames` to remove branching for review.
atul added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
atul updated the diff for D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
add comment to parameterize function
atul updated the diff for D9896: [lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring.
address feedback and land
atul updated the diff for D9895: [native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`.
rebase and land
atul requested review of D9894: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`.
misclick
atul planned changes to D9894: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`.
atul updated the diff for D9894: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`.
land
Nov 15 2023
Nov 15 2023
atul published D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues for review.
atul published D9896: [lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring for review.
atul published D9895: [native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo` for review.
atul updated the summary of D9894: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`.
atul published D9894: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo` for review.
There's more in web to be updated, but this first pass will make subsequent refactoring easy. Loosely starting with "leaf" components/functions and working way up.
atul updated the diff for D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo`.
land
atul updated the diff for D9889: [lib] Update `checkIfDefaultMembersAreVoiced` to handle `MinimallyEncodedThreadInfo`.
land
atul added a comment to D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo`.
In D9890#288332, @tomek wrote:Are there some places where we're expecting only ThreadInfo and not MinimallyEncodedThreadInfo (or the other way around)? Is it possible to modify ThreadInfo type to be what it already is or MinimallyEncodedThreadInfo (type ThreadInfo = { ... } | MinimallyEncodedThreadInfo)? That might be a more maintainable and much simpler approach.
atul updated the diff for D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo`.
fix
atul planned changes to D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo`.
atul published D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo` for review.
Nov 14 2023
Nov 14 2023
address feedback (merge imports)
atul updated the diff for D9848: [lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo`.
address feedback (type annotations)
Nov 13 2023
Nov 13 2023
atul updated the diff for D9847: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`.
rebase and land
atul published D9847: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo` for review.
This should be the second-to-last MinimallyEncoded* type that we introduce. We'll need a MinimallyEncodedResolvedThreadInfo for clients, but that'll be later in the stack.
atul added a comment to D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo`.
In D9841#287316, @ashoat wrote:Before landing, can you create a task to track fixing up threadHasPermission?
atul published D9845: [lib] Update `threadHasPermission` to "go through" `permissionLookup` for review.