Page MenuHomePhorge
Feed Search

Jan 5 2024

ginsu added inline comments to D10516: [web] refactor tabs component.
Jan 5 2024, 8:19 PM
ginsu updated the diff for D10520: [web] update thread settings media gallery modal to use new tabs component.

address comments + rebase before landing

Jan 5 2024, 8:14 PM
ginsu updated the diff for D10519: [web] update sidebars modal to use new tabs component.

address comments + rebase before landing

Jan 5 2024, 8:10 PM
ginsu attached a referenced file: F1031762: Screenshot 2024-01-05 at 3.03.55 PM.png.
Jan 5 2024, 8:05 PM
ginsu added inline comments to D10519: [web] update sidebars modal to use new tabs component.
Jan 5 2024, 8:05 PM
ginsu added inline comments to D10516: [web] refactor tabs component.
Jan 5 2024, 7:58 PM
ginsu added inline comments to D10549: [web] update the thread top bar ui.
Jan 5 2024, 6:52 PM
ginsu requested review of D10549: [web] update the thread top bar ui.
Jan 5 2024, 8:54 AM
ginsu requested review of D10548: [web] factor out pinned messages banner into its own component.
Jan 5 2024, 8:46 AM
ginsu updated the diff for D10516: [web] refactor tabs component.

address comments

Jan 5 2024, 8:01 AM
ginsu closed D10348: [web] fixup pinned message modal.
Jan 5 2024, 4:03 AM
ginsu committed rCOMM38684f16525b: [web] fixup pinned message modal.
Jan 5 2024, 4:03 AM
ginsu closed D10347: [lib/native/web] introduce pinnedMessageCountText function.
Jan 5 2024, 4:03 AM
ginsu closed D10346: [lib/web/native] rename toggle pin utils to be message pinning utils.
Jan 5 2024, 4:03 AM
ginsu committed rCOMM7d8837fc824e: [lib/native/web] introduce pinnedMessageCountText function.
Jan 5 2024, 4:03 AM
ginsu committed rCOMM782f6c2294c8: [lib/web/native] rename toggle pin utils to be message pinning utils.
Jan 5 2024, 4:03 AM
ginsu closed D10345: [web] rename message results modal to be pinned messages modal.
Jan 5 2024, 4:03 AM
ginsu committed rCOMMa36bb67e51fa: [web] rename message results modal to be pinned messages modal.
Jan 5 2024, 4:03 AM
ginsu updated the diff for D10348: [web] fixup pinned message modal.

rebase

Jan 5 2024, 3:26 AM
ginsu updated the diff for D10347: [lib/native/web] introduce pinnedMessageCountText function.

update

Jan 5 2024, 3:20 AM
ginsu updated the diff for D10348: [web] fixup pinned message modal.

rebase before landing

Jan 5 2024, 2:54 AM
ginsu updated the diff for D10347: [lib/native/web] introduce pinnedMessageCountText function.

rebase before landing

Jan 5 2024, 2:51 AM
ginsu updated the diff for D10346: [lib/web/native] rename toggle pin utils to be message pinning utils.

rebase before landing

Jan 5 2024, 2:49 AM
ginsu updated the diff for D10345: [web] rename message results modal to be pinned messages modal.

rebase before landing

Jan 5 2024, 2:44 AM
ginsu added a comment to D10345: [web] rename message results modal to be pinned messages modal.

Thanks for doing this! I know you're working primarily on web, but while you're doing this could you also rename the MessageResultsScreen for native for the same thing? Let me know if it's a little complicated / it'll delay your work and I can do it later myself as well!

Jan 5 2024, 2:27 AM

Jan 4 2024

ginsu requested review of D10516: [web] refactor tabs component.

Seems correct, but would appreciate a bit of clarity on use of generics in Props<T: string> to make sure I'm understanding things correctly

Jan 4 2024, 11:29 PM
ginsu closed D10517: [web] rename tabs to tabs legacy.
Jan 4 2024, 11:00 PM
ginsu committed rCOMM2e6586754590: [web] rename tabs to tabs legacy.
Jan 4 2024, 11:00 PM
ginsu closed D10515: [web] rename card color family to panel.
Jan 4 2024, 11:00 PM
ginsu committed rCOMM97647cc7ab60: [web] rename card color family to panel.
Jan 4 2024, 11:00 PM
ginsu closed D10514: [web] rename panel color family to frame.
Jan 4 2024, 11:00 PM
ginsu committed rCOMM88e5545f2009: [web] rename panel color family to frame.
Jan 4 2024, 11:00 PM
ginsu added a comment to D10547: [web] Remove extraneous CSS selectors.

Just a heads up I noticed that you removed the chat.css file, in my stack I use this file to add some styles. Just wanted to call this out since this seems like it could be a potential merge conflict

Jan 4 2024, 10:09 PM
ginsu accepted D10547: [web] Remove extraneous CSS selectors.

thanks for doing this!

Jan 4 2024, 10:04 PM
ginsu added inline comments to D10528: [web] house the thread list in a panel component.
Jan 4 2024, 9:59 PM
ginsu added a comment to D10517: [web] rename tabs to tabs legacy.

As an aside, would it make sense to also rename imports to be LegacyTabs? Doesn't really matter and will probably be removed altogether at the end of the stack anyways.

Jan 4 2024, 9:46 PM
ginsu attached a referenced file: F1028191: Screenshot 2024-01-04 at 4.35.28 PM.png.
Jan 4 2024, 9:44 PM
ginsu attached a referenced file: F1028199: Screenshot 2024-01-04 at 4.39.55 PM.png.
Jan 4 2024, 9:44 PM
ginsu added inline comments to D10516: [web] refactor tabs component.
Jan 4 2024, 9:43 PM
ginsu added inline comments to D10518: [web] upate emoji avatar selection modal to use new tabs component.
Jan 4 2024, 9:25 PM
ginsu attached a referenced file: F1026775: Screenshot 2024-01-04 at 7.00.56 AM.png.
Jan 4 2024, 12:23 PM
ginsu attached a referenced file: F1026778: Screenshot 2024-01-04 at 7.17.21 AM.png.
Jan 4 2024, 12:23 PM
ginsu added inline comments to D10529: [web] update thread list ui.
Jan 4 2024, 12:23 PM
ginsu requested review of D10529: [web] update thread list ui.
Jan 4 2024, 12:12 PM
ginsu requested review of D10528: [web] house the thread list in a panel component.
Jan 4 2024, 11:58 AM
ginsu requested review of D10527: [web] update the chat tabs ui.
Jan 4 2024, 11:46 AM
ginsu accepted D10525: [web] Fix default apps.
Jan 4 2024, 11:24 AM
ginsu requested review of D10524: [web] deprecate and clean up unused tabs code.
Jan 4 2024, 9:59 AM
ginsu requested review of D10523: [web] update chat tabs to use the new tabs component.
Jan 4 2024, 9:54 AM
ginsu requested review of D10522: [web] update thread settings modal to use the new tabs component.
Jan 4 2024, 9:35 AM
ginsu requested review of D10521: [web] update members modal to use the new tabs component.
Jan 4 2024, 9:31 AM
ginsu requested review of D10520: [web] update thread settings media gallery modal to use new tabs component.
Jan 4 2024, 9:25 AM
ginsu requested review of D10519: [web] update sidebars modal to use new tabs component.
Jan 4 2024, 9:20 AM
ginsu updated the summary of D10518: [web] upate emoji avatar selection modal to use new tabs component.
Jan 4 2024, 9:14 AM
ginsu requested review of D10518: [web] upate emoji avatar selection modal to use new tabs component.

will make sure ci passes before landing

Jan 4 2024, 9:01 AM
ginsu requested review of D10517: [web] rename tabs to tabs legacy.
Jan 4 2024, 8:51 AM
ginsu updated the summary of D10516: [web] refactor tabs component.
Jan 4 2024, 8:50 AM
ginsu updated the diff for D10516: [web] refactor tabs component.

update

Jan 4 2024, 8:45 AM
ginsu requested review of D10516: [web] refactor tabs component.
Jan 4 2024, 8:40 AM

Jan 3 2024

ginsu requested review of D10515: [web] rename card color family to panel.
Jan 3 2024, 10:22 PM
ginsu requested review of D10514: [web] rename panel color family to frame.
Jan 3 2024, 10:13 PM
ginsu closed D10500: [web] introduce panel component.
Jan 3 2024, 8:45 PM
ginsu committed rCOMM5ac45fa7c608: [web] introduce panel component.
Jan 3 2024, 8:45 PM
ginsu updated the diff for D10500: [web] introduce panel component.

rebase before landing

Jan 3 2024, 8:43 PM
ginsu closed D10499: [web] introduce community header.
Jan 3 2024, 7:53 PM
ginsu committed rCOMM2a82d05adb5e: [web] introduce community header.
Jan 3 2024, 7:53 PM
ginsu updated the diff for D10499: [web] introduce community header.

rebase before landing

Jan 3 2024, 7:52 PM
ginsu added inline comments to D10500: [web] introduce panel component.
Jan 3 2024, 6:40 PM
ginsu attached a referenced file: F1023677: Screenshot 2024-01-03 at 1.35.57 PM.png.
Jan 3 2024, 6:38 PM
ginsu attached a referenced file: F1023678: Screenshot 2024-01-03 at 1.36.25 PM.png.
Jan 3 2024, 6:38 PM
ginsu retitled D10500: [web] introduce panel component from [web] introduce card component
Jan 3 2024, 6:38 PM
ginsu added a comment to D10500: [web] introduce panel component.

Left a comment about using React.Children.* APIs which are listed as "legacy" in the React docs.

Jan 3 2024, 6:36 PM
ginsu updated the diff for D10500: [web] introduce panel component.

address comments

Jan 3 2024, 6:15 PM

Jan 2 2024

ginsu closed D10498: [web] introduce community header actions.
Jan 2 2024, 10:28 PM
ginsu committed rCOMM91e90f292e22: [web] introduce community header actions.
Jan 2 2024, 10:28 PM
ginsu updated the diff for D10499: [web] introduce community header.

address comments

Jan 2 2024, 10:23 PM
ginsu added a comment to D10498: [web] introduce community header actions.

Maybe I'm missing something, but it looks like the message list is missing in the screenshots provided. Guessing this was just for debugging layout or something?

Jan 2 2024, 10:19 PM
ginsu updated the diff for D10498: [web] introduce community header actions.

address comments + rebase before landing

Jan 2 2024, 10:17 PM

Dec 30 2023

ginsu attached a referenced file: F1013968: Screenshot 2023-12-29 at 7.01.37 PM.png.
Dec 30 2023, 12:02 AM
ginsu updated the summary of D10500: [web] introduce panel component.
Dec 30 2023, 12:02 AM

Dec 29 2023

ginsu updated the diff for D10500: [web] introduce panel component.

update

Dec 29 2023, 11:59 PM
ginsu planned changes to D10500: [web] introduce panel component.

uncovered a small visual bug when a card has more than 2 sections

Dec 29 2023, 11:25 PM
ginsu published D10500: [web] introduce panel component for review.
Dec 29 2023, 11:24 PM
ginsu closed D10497: [web] introduce community header button.
Dec 29 2023, 10:42 PM
ginsu committed rCOMM1b5844aa048c: [web] introduce community header button.
Dec 29 2023, 10:42 PM
ginsu closed D10496: [web] update colors in app directory modal to use enum option color family.
Dec 29 2023, 10:42 PM
ginsu committed rCOMM339696eae83c: [web] update colors in app directory modal to use enum option color family.
Dec 29 2023, 10:42 PM
ginsu updated the diff for D10497: [web] introduce community header button.

rebase before landing

Dec 29 2023, 10:40 PM
ginsu updated the diff for D10496: [web] update colors in app directory modal to use enum option color family.

rebase before landing

Dec 29 2023, 10:40 PM
ginsu attached a referenced file: F1013762: Screenshot 2023-12-29 at 5.27.21 PM.png.
Dec 29 2023, 10:28 PM
ginsu added a comment to D10497: [web] introduce community header button.

Just a question - do you plan to add the Roles community action here later as well?

Dec 29 2023, 10:28 PM
ginsu requested review of D10499: [web] introduce community header.
Dec 29 2023, 9:00 PM
ginsu requested review of D10498: [web] introduce community header actions.
Dec 29 2023, 8:42 PM
ginsu accepted D10484: [lib][web][native] Create defaultKeyserverInfo.

seems reasonable, thanks for factoring that out!

Dec 29 2023, 8:31 PM
ginsu requested review of D10497: [web] introduce community header button.
Dec 29 2023, 8:22 PM
ginsu requested review of D10496: [web] update colors in app directory modal to use enum option color family.
Dec 29 2023, 8:06 PM
ginsu closed D10474: [web] cleanup and better organize code for tooltips.
Dec 29 2023, 2:46 AM
ginsu closed D10473: [web] rename navigation sidebar tooltip to label tooltip.
Dec 29 2023, 2:46 AM
ginsu committed rCOMM2d8266808317: [web] cleanup and better organize code for tooltips.
Dec 29 2023, 2:45 AM
ginsu committed rCOMMeb9f85f86b0c: [web] rename navigation sidebar tooltip to label tooltip.
Dec 29 2023, 2:45 AM