address comments + rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jan 5 2024
address comments + rebase before landing
address comments
update
rebase before landing
rebase before landing
rebase before landing
rebase before landing
Thanks for doing this! I know you're working primarily on web, but while you're doing this could you also rename the MessageResultsScreen for native for the same thing? Let me know if it's a little complicated / it'll delay your work and I can do it later myself as well!
Jan 4 2024
Seems correct, but would appreciate a bit of clarity on use of generics in Props<T: string> to make sure I'm understanding things correctly
Just a heads up I noticed that you removed the chat.css file, in my stack I use this file to add some styles. Just wanted to call this out since this seems like it could be a potential merge conflict
thanks for doing this!
As an aside, would it make sense to also rename imports to be LegacyTabs? Doesn't really matter and will probably be removed altogether at the end of the stack anyways.
will make sure ci passes before landing
Jan 3 2024
rebase before landing
rebase before landing
Left a comment about using React.Children.* APIs which are listed as "legacy" in the React docs.
address comments
Jan 2 2024
address comments
Maybe I'm missing something, but it looks like the message list is missing in the screenshots provided. Guessing this was just for debugging layout or something?
address comments + rebase before landing
Dec 30 2023
Dec 29 2023
uncovered a small visual bug when a card has more than 2 sections
rebase before landing
rebase before landing
Just a question - do you plan to add the Roles community action here later as well?
seems reasonable, thanks for factoring that out!