It would be helpful if you linked a Linear task describing why we need to change that or explain what the plan is. I guess we're going to introduce a new, similar hook, but I can't be sure.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Feb 6 2024
Feb 6 2024
tomek added inline comments to D10115: [native] Update update-roles-and-permissions-test-data.js to include specialRole field.
tomek added inline comments to D10114: [lib] Update thread-ops-utils.test.js to include specialRole field.
Feb 5 2024
Feb 5 2024
Await more promises at once
Feb 1 2024
Feb 1 2024
Invert the flag
Rebase
Rebase
tomek updated the diff for D10338: [web][native] Download invite link blob and use it as an override.
Rebase and address comments
tomek updated the diff for D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.
Rebased the diff but I'm not sure whether it works and is the right approach
tomek updated the diff for D10308: [keyserver] Modify link verification so that it works with users that aren't logged in to a keyserver.
Rebase
Rebase
Rebase
Update comment
tomek removed a reviewer for D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs: rohan.
tomek updated the diff for D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.
Rebase
tomek updated the diff for D10150: [keyserver] Introduce a function that allows fetching all the primary links.
Rebase
In D10134#296332, @tomek wrote:I'm going to check the option of using MariaDB transactions to minimize the number of possible race conditions
Rebase
tomek updated the diff for D10131: [keyserver] Change blob upload functions to return more usable results.
Include status and text in a result
This is quite fragile - it should work because in identity context we select commServicesAccessToken, and when it changes, we create a new value of getAuthMetadata function. Also, accessToken and userID are exposed by the same emitter.
Rename
Improve canceling logic
Jan 31 2024
Jan 31 2024
tomek updated the diff for D10099: [keyserver] Introduce a util function that generates invite link blob hash.
Rebase
tomek updated the diff for D10098: [keyserver] Modify blob functions so that they take params object where both hash and holder are provided.
Destructure in the function
Instantly delete blobs
Set instant flag
Rebase
Destructure params inside function
tomek updated the diff for D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.
Delete unnecessary async
tomek requested review of D10842: [lib] Don't automatically log out on connection issue when using CSAT.
tomek requested review of D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.
Decided that it is a lot more efficient to introduce a new diff which introduces canceling the auth D10884.
tomek accepted D10882: [lib] Replace `ConnectionInfo.showDisconnectedBar` with `ConnectionInfo.unreachable`.
My understanding is that ConnectionInfo is a client-only type and no inital value is sent from the keyserver. I was a bit confused because of connectionInfoValidator, but it turns out connectionInfoValidator is only consumed by keyserverInfoValidator which is only consumed by keyserverStoreValidator... which doesn't seem to be used anywhere? It looks like the only two KeyserverInfo fields we send as part of initialReduxState are sessionID and updatesCurrentAsOf.
This seems to be correct, but we should extend the test plan by checking if old clients can work correctly after this change.
Jan 30 2024
Jan 30 2024
tomek added inline comments to D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.
Jan 29 2024
Jan 29 2024
tomek added inline comments to D10635: [lib][web][native] Make it possible to remove a subset of drafts.
tomek planned changes to D10842: [lib] Don't automatically log out on connection issue when using CSAT.
In D10842#312452, @ashoat wrote:Is this what we want to do for all connection issues, even for my keyserver? Or are there some kinds of connection issues, where if they occur for my keyserver, we'd want to log the user out?
tomek added inline comments to D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.
Jan 26 2024
Jan 26 2024
tomek requested review of D10842: [lib] Don't automatically log out on connection issue when using CSAT.
tomek updated the diff for D10830: [lib] Create a selector that checks if a user is logged in to a keyserver.
Delete unnecessary check - a dependency on dataLoaded flag makes this logic invalid