Feed Search

Search
Use Results
Edit Query
Hide Query

Apr 10 2024

ginsu updated the diff for D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.

rebase + confirm ci passes

Apr 10 2024, 7:34 PM

ginsu updated the diff for D11568: [lib/native/web] refactor notif permission alert info reducer.

rebase + confirm ci passes

Apr 10 2024, 7:33 PM

ginsu attached a referenced file: F1511189: Screenshot 2024-04-10 at 3.28.26 PM.png.

Apr 10 2024, 7:32 PM

ginsu added inline comments to D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.

Apr 10 2024, 7:32 PM

ginsu accepted D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

Apr 10 2024, 7:25 PM

ginsu closed D11567: [lib/native/web] introduce alert types.

Apr 10 2024, 6:16 PM

ginsu closed D11598: [native] handle successful connection from connect farcaster bottom sheet.

Apr 10 2024, 6:16 PM

ginsu committed rCOMM9e6a658b2b6c: [lib/native/web] introduce alert types.

Apr 10 2024, 6:16 PM

ginsu committed rCOMMd7827e8b38e1: [native] handle successful connection from connect farcaster bottom sheet.

Apr 10 2024, 6:16 PM

ginsu closed D11597: [native] flip farcaster prompt based on fid prop instead of context.

Apr 10 2024, 6:16 PM

ginsu committed rCOMM39cda6c1f115: [native] flip farcaster prompt based on fid prop instead of context.

Apr 10 2024, 6:16 PM

ginsu updated the diff for D11567: [lib/native/web] introduce alert types.

rebase before landing + make sure ci passes

Apr 10 2024, 5:54 PM

ginsu updated the diff for D11598: [native] handle successful connection from connect farcaster bottom sheet.

address comments

Apr 10 2024, 5:45 PM

ginsu added inline comments to D11598: [native] handle successful connection from connect farcaster bottom sheet.

Apr 10 2024, 5:09 PM

ginsu requested review of D11621: [native] fix copy in FarcasterPrompt.

Apr 10 2024, 5:01 PM

ginsu added inline comments to D11597: [native] flip farcaster prompt based on fid prop instead of context.

Apr 10 2024, 5:00 PM

ginsu added inline comments to D11597: [native] flip farcaster prompt based on fid prop instead of context.

Apr 10 2024, 4:54 PM

ginsu added a comment to D11484: [native] update FarcasterPrompt based on if the fid is set or not.

In D11484#333855, @ashoat wrote:

This diff actually did end up affecting the registration flow. It introduced a very slight regression due to @ginsu's removal of the question mark. @ginsu, can you reply here either with a diff that fixes it, or a task?

Apr 10 2024, 4:46 PM

ginsu requested review of D11613: [lib/native] introduce connect farcaster alert handler.

will make sure ci passes before landing

Apr 10 2024, 5:48 AM

ginsu accepted D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.

Apr 10 2024, 5:07 AM

ginsu accepted D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.

Apr 10 2024, 5:06 AM

ginsu accepted D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.

Apr 10 2024, 5:05 AM

Apr 9 2024

ginsu requested review of D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.

Apr 9 2024, 7:35 PM

ginsu requested review of D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.

actually jk, I confused myself there is no bug with this diff

Apr 9 2024, 7:06 PM

ginsu updated the summary of D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.

Apr 9 2024, 7:06 PM

ginsu planned changes to D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.

found a bug

Apr 9 2024, 5:49 PM

ginsu requested review of D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.

Apr 9 2024, 5:44 PM

ginsu requested review of D11599: [lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file.

Apr 9 2024, 5:35 PM

ginsu requested review of D11598: [native] handle successful connection from connect farcaster bottom sheet.

Apr 9 2024, 5:19 PM

ginsu updated the summary of D11567: [lib/native/web] introduce alert types.

Apr 9 2024, 5:16 PM

ginsu requested review of D11597: [native] flip farcaster prompt based on fid prop instead of context.

Apr 9 2024, 5:15 PM

Apr 8 2024

ginsu requested review of D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.

will make sure ci passes before landing

Apr 8 2024, 4:18 AM

ginsu requested review of D11568: [lib/native/web] refactor notif permission alert info reducer.

will make sure ci passes before landing

Apr 8 2024, 3:56 AM

ginsu requested review of D11567: [lib/native/web] introduce alert types.

will make sure ci passes before landing

Apr 8 2024, 3:26 AM

Apr 5 2024

ginsu accepted D11566: [native] Add auxUserStore to persist blacklist.

seems reasonable, but want to make sure @kamil can also review this

Apr 5 2024, 10:09 PM

ginsu closed D11561: [native] calculate snap points for connect farcaster bottom sheet.

Apr 5 2024, 3:06 AM

ginsu closed D11560: [native] implement connect farcaster bottom sheet ui.

Apr 5 2024, 3:06 AM

ginsu committed rCOMM9a7c9bac9bb4: [native] implement connect farcaster bottom sheet ui.

Apr 5 2024, 3:06 AM

ginsu committed rCOMM120db72b9482: [native] calculate snap points for connect farcaster bottom sheet.

Apr 5 2024, 3:06 AM

ginsu closed D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.

Apr 5 2024, 3:06 AM

ginsu committed rCOMMc813111a7acd: [native] introduce barebones connect farcaster bottom sheet to root navigator.

Apr 5 2024, 3:06 AM

ginsu updated the diff for D11561: [native] calculate snap points for connect farcaster bottom sheet.

address comments + rebase before landing

Apr 5 2024, 2:27 AM

ginsu updated the diff for D11560: [native] implement connect farcaster bottom sheet ui.

address comments + rebase before landing

Apr 5 2024, 2:24 AM

ginsu updated the diff for D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.

rebase before landing

Apr 5 2024, 2:22 AM

ginsu accepted D11558: [keyserver][lib][web] Update SIWE package.

Apr 5 2024, 1:41 AM

Apr 4 2024

ginsu accepted D11555: [web] Lift WagmiProvider higher up the component tree.

Apr 4 2024, 9:03 PM

ginsu accepted D11554: [lib][landing][web] Update Wagmi to 2.5.18.

Apr 4 2024, 9:03 PM

ginsu published D11561: [native] calculate snap points for connect farcaster bottom sheet for review.

will make sure ci passes before landing

Apr 4 2024, 7:22 PM

ginsu requested review of D11560: [native] implement connect farcaster bottom sheet ui.

will make sure ci passes before landing

Apr 4 2024, 7:22 PM

ginsu requested review of D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.

will make sure ci passes before landing

Apr 4 2024, 7:22 PM

ginsu accepted D11557: [landing][lib][web] Add buffer polyfill for webworkers.

Apr 4 2024, 6:59 PM

ginsu accepted D11529: [native][web] read aux user store on app startup.

seems reasonable

Apr 4 2024, 5:40 AM

ginsu resigned from D11528: [lib] Introduce aux user store reducer and action types.

Overall looks good, just a few comments inline. Going to resign as reviewer so other reviewers can also take a look too

Apr 4 2024, 5:37 AM

Apr 3 2024

ginsu closed D11513: [native] unauth from farcaster.

Apr 3 2024, 4:49 PM

ginsu committed rCOMM296be49bd4b4: [native] unauth from farcaster.

Apr 3 2024, 4:49 PM

ginsu closed D11512: [native] build out UI for farcaster account settings screen.

Apr 3 2024, 4:49 PM

ginsu closed D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Apr 3 2024, 4:49 PM

ginsu committed rCOMMb5530714c2a9: [native] update FarcasterPrompt based on if the fid is set or not.

Apr 3 2024, 4:49 PM

ginsu committed rCOMM00a8b91431f3: [native] build out UI for farcaster account settings screen.

Apr 3 2024, 4:49 PM

ginsu closed D11483: [native] introduce farcaster account settings profile row.

Apr 3 2024, 4:49 PM

ginsu committed rCOMMaf0bb9f6dfcf: [native] introduce farcaster account settings profile row.

Apr 3 2024, 4:49 PM

ginsu updated the diff for D11513: [native] unauth from farcaster.

rebase before landing + confirm keyserver ci build works

Apr 3 2024, 4:26 PM

ginsu updated the diff for D11512: [native] build out UI for farcaster account settings screen.

rebase before landing

Apr 3 2024, 4:25 PM

ginsu updated the diff for D11484: [native] update FarcasterPrompt based on if the fid is set or not.

rebase before landing + make sure keyserver build ci works

Apr 3 2024, 4:25 PM

ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

rebase before landing

Apr 3 2024, 4:24 PM

ginsu updated the diff for D11513: [native] unauth from farcaster.

rebase before landing

Apr 3 2024, 5:27 AM

ginsu updated the diff for D11484: [native] update FarcasterPrompt based on if the fid is set or not.

address comments

Apr 3 2024, 5:25 AM

Apr 2 2024

ginsu accepted D11527: [native] Patch react-native to avoid FlatList this.props error.

Apr 2 2024, 8:38 PM

Apr 1 2024

ginsu requested review of D11512: [native] build out UI for farcaster account settings screen.

Apr 1 2024, 7:52 PM

ginsu requested review of D11513: [native] unauth from farcaster.

Apr 1 2024, 7:47 PM

ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.

Apr 1 2024, 7:28 PM

ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

fix eslint ci issue

Apr 1 2024, 7:27 PM

ginsu requested review of D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Making @ashoat blocking reviewer since this diff does have copy changes

Apr 1 2024, 7:10 PM

ginsu attached a referenced file: F1452474: IMG_6793.PNG.

Apr 1 2024, 7:09 PM

ginsu attached a referenced file: F1452475: IMG_6792.PNG.

Apr 1 2024, 7:09 PM

ginsu attached a referenced file: F1452477: RPReplay_Final1711998516.MP4.

Apr 1 2024, 7:09 PM

ginsu updated the summary of D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Apr 1 2024, 7:09 PM

ginsu added a comment to D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Will this affect the experience when FarcasterPrompt is used from the registration flow?

Apr 1 2024, 7:01 PM

ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.

Apr 1 2024, 6:58 PM

ginsu updated the diff for D11483: [native] introduce farcaster account settings profile row.

update farcaster account gate logic

Apr 1 2024, 6:57 PM

ginsu added inline comments to D11483: [native] introduce farcaster account settings profile row.

Apr 1 2024, 6:56 PM

ginsu accepted D11494: [lib][native] Update useRegistrationServerCall to set FID in FIDContext.

Apr 1 2024, 6:38 PM

ginsu accepted D11492: [lib] Add Coinbase Wallet support.

Apr 1 2024, 4:28 PM

ginsu accepted D11491: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates.

Apr 1 2024, 4:26 PM

ginsu accepted D11490: [lib][web][landing] Don't include injectedWallet in mobile experience.

Apr 1 2024, 4:25 PM

ginsu accepted D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.

Apr 1 2024, 4:24 PM

ginsu accepted D11493: [buildkite] Update image used in Buildkite JS workflows to Node 20.

Apr 1 2024, 4:19 PM

ginsu accepted D11488: [native] Allow us to open a bunch of other wallets.

Apr 1 2024, 4:18 PM

ginsu accepted D11487: [lib] Allow getNamesForAddresses to be called without ReverseRecords smart contract.

Apr 1 2024, 4:17 PM

ginsu accepted D11486: [lib] Switch to Sepolia for ENSCache unit tests.

Apr 1 2024, 4:14 PM

ginsu accepted D11485: [lib][native][web][keyserver][landing] Update to Ethers.js 6.

Apr 1 2024, 4:13 PM

Mar 29 2024

ginsu planned changes to D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Mar 29 2024, 10:09 PM

ginsu requested review of D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Mar 29 2024, 9:52 PM

ginsu requested review of D11483: [native] introduce farcaster account settings profile row.

Mar 29 2024, 9:45 PM

ginsu closed D11463: [native] introduce already connected button to farcaster connect.

Mar 29 2024, 9:20 PM

ginsu committed rCOMMddfda1a8134d: [native] introduce already connected button to farcaster connect.

Mar 29 2024, 9:20 PM

ginsu closed D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.

Mar 29 2024, 9:20 PM

ginsu committed rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step.

Mar 29 2024, 9:20 PM

ginsu closed D11461: [native] add the connect farcaster step into the registration flow.

Mar 29 2024, 9:20 PM

ginsu committed rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow.

Mar 29 2024, 9:20 PM