Page MenuHomePhabricator
Feed Advanced Search

Aug 6 2024

varun closed D12931: [terraform] add WNS secrets config.
Aug 6 2024, 9:45 PM
varun committed rCOMM077424e70361: [terraform] add WNS secrets config (authored by varun).
[terraform] add WNS secrets config
Aug 6 2024, 9:45 PM
varun closed D13004: [windows] override C++20 and upgrade nan package.
Aug 6 2024, 9:30 PM
varun committed rCOMM1e1c695ca3dc: [windows] override C++20 and upgrade nan package (authored by varun).
[windows] override C++20 and upgrade nan package
Aug 6 2024, 9:30 PM
varun closed D12950: [desktop] add cross-env dependency and use it to set environment variables in desktop/package.json.
Aug 6 2024, 9:12 PM
varun committed rCOMM130a1bc44270: [desktop] add cross-env dependency and use it to set environment variables in… (authored by varun).
[desktop] add cross-env dependency and use it to set environment variables in…
Aug 6 2024, 9:12 PM
varun added a comment to D13004: [windows] override C++20 and upgrade nan package.

realized i forgot to add the lockfile. will update before landing

Aug 6 2024, 9:08 PM
varun published D12935: [Tunnelbroker] send push notifs to windows devices for review.
Aug 6 2024, 8:57 PM
varun requested review of D13004: [windows] override C++20 and upgrade nan package.
Aug 6 2024, 6:34 PM

Aug 1 2024

varun accepted D12928: [keyserver] Run webapp through comm services cluster.

setting @bartek as blocking since he left the original feedback

Aug 1 2024, 1:30 PM
varun accepted D12930: [terraform] deploy landing on comm services cluster.
Aug 1 2024, 12:07 PM

Jul 31 2024

varun added a reviewer for D12809: [lib] add new selector and function to get own user's keyserver device ID: tomek.
Jul 31 2024, 8:40 AM

Jul 30 2024

varun requested review of D12950: [desktop] add cross-env dependency and use it to set environment variables in desktop/package.json.
Jul 30 2024, 7:14 PM
varun published D12934: [Tunnelbroker] Implement client method to get WNS token for review.
Jul 30 2024, 12:04 AM
varun published D12933: [Tunnelbroker] implement WNS client for review.
Jul 30 2024, 12:04 AM
varun published D12932: [Tunnelbroker] implement WNS config for review.
Jul 30 2024, 12:03 AM
varun published D12931: [terraform] add WNS secrets config for review.
Jul 30 2024, 12:03 AM

Jul 29 2024

varun accepted D12925: [native_rust_library] Extend findUserIdentities response.
Jul 29 2024, 10:25 PM
varun accepted D12924: [identity] Query reserved usernames in FindUserIdentities RPC.
Jul 29 2024, 10:24 PM
varun accepted D12922: [protos][identity] Add reserved usernames to UserIdentitiesResponse.
Jul 29 2024, 10:18 PM
varun accepted D12890: [identity] Rewrite GetDeviceLists RPC to use batch functions.
Jul 29 2024, 10:16 PM
varun accepted D12889: [identity] Add function to batch-get platform details.
Jul 29 2024, 10:08 PM

Jul 28 2024

varun attached a referenced file: F2349070: Simulator Screenshot - iPhone 15 Pro Max - 2024-07-29 at 00.08.07.png.
Jul 28 2024, 9:08 PM
varun updated the test plan for D12907: [native] linked devices component.
Jul 28 2024, 9:08 PM
varun requested review of D12907: [native] linked devices component.
Jul 28 2024, 8:30 PM
varun accepted D12900: Prevent desktop devices from presenting themselves as web to identity.

now that we supply platform details as metadata, should we be sending the device type in the key upload at all? seems like we should just remove it? cc @bartek

Jul 28 2024, 1:47 PM
varun accepted D12899: Bump identity staging version to 0.34.
Jul 28 2024, 1:37 PM

Jul 26 2024

varun added inline comments to D12888: [identity] Add function to batch-get device lists.
Jul 26 2024, 12:30 PM
varun accepted D12888: [identity] Add function to batch-get device lists.
Jul 26 2024, 12:29 PM
varun added inline comments to D12884: [native] replace keyserver using qr code auth.
Jul 26 2024, 12:14 PM
varun abandoned D12885: [keyserver] script to output new db version.
Jul 26 2024, 12:12 PM
varun accepted D12886: [identity] Forbid duplicated devices in device lists.
Jul 26 2024, 8:14 AM

Jul 25 2024

varun requested review of D12885: [keyserver] script to output new db version.
Jul 25 2024, 9:09 PM
varun requested review of D12884: [native] replace keyserver using qr code auth.
Jul 25 2024, 8:53 PM
varun closed D12873: [terraform] bump prod identity to 0.33.
Jul 25 2024, 8:47 PM
varun committed rCOMMc82f82a0a1db: [terraform] bump prod identity to 0.33 (authored by varun).
[terraform] bump prod identity to 0.33
Jul 25 2024, 8:47 PM
varun updated the diff for D12805: [lib] introduce new device list function to replace keyserver device.

address feedback

Jul 25 2024, 8:37 PM
varun accepted D12880: [services] Replace deprecated aws_config::from_env().
Jul 25 2024, 1:03 PM
varun accepted D12879: [services] Update AWS Rust SDK.
Jul 25 2024, 12:55 PM
varun accepted D12883: [web] Fixes the emscripten CI build by allowing curl redirects.
Jul 25 2024, 10:55 AM
varun accepted D12878: Update Rust to 1.76.
Jul 25 2024, 8:30 AM

Jul 24 2024

varun requested review of D12873: [terraform] bump prod identity to 0.33.
Jul 24 2024, 12:06 PM
varun accepted D12868: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security group.
Jul 24 2024, 11:34 AM
varun accepted D12863: [terraform] move image config to aws_ecs and add custom image variable.
Jul 24 2024, 11:15 AM
varun accepted D12862: [terraform] update variables.tf self-host descriptions.
Jul 24 2024, 10:47 AM
varun accepted D12861: [terraform] Actually use db_instance_class for mariadb.
Jul 24 2024, 10:45 AM

Jul 23 2024

varun accepted D12864: [terraform] upgrade the disk image to 1.0.102.
Jul 23 2024, 6:20 PM

Jul 22 2024

varun closed D12845: [terraform] bump staging identity to 0.33-staging.
Jul 22 2024, 12:21 PM
varun committed rCOMM46def1591f85: [terraform] bump staging identity to 0.33-staging (authored by varun).
[terraform] bump staging identity to 0.33-staging
Jul 22 2024, 12:21 PM
varun requested review of D12845: [terraform] bump staging identity to 0.33-staging.
Jul 22 2024, 11:30 AM
varun abandoned D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Jul 22 2024, 11:05 AM
varun abandoned D11811: [web][native] mark keys as published before uploading to identity service.
Jul 22 2024, 11:04 AM
varun accepted D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Jul 22 2024, 10:57 AM
varun closed D12832: [identity] modify get_all_user_details to return wallet addresses too.
Jul 22 2024, 10:03 AM
varun closed D12830: [identity] check users table before reserved usernames table for user ID during wallet login.
Jul 22 2024, 10:03 AM
varun closed D12831: [identity] get all usernames and wallet addresses in get_all_usernames.
Jul 22 2024, 10:03 AM
varun committed rCOMM63e8e9dea808: [identity] check users table before reserved usernames table for user ID during… (authored by varun).
[identity] check users table before reserved usernames table for user ID during…
Jul 22 2024, 10:03 AM
varun committed rCOMM2f4606fcdba3: [identity] modify get_all_user_details to return wallet addresses too (authored by varun).
[identity] modify get_all_user_details to return wallet addresses too
Jul 22 2024, 10:03 AM
varun committed rCOMMa1e09026a6c1: [identity] get all usernames and wallet addresses in get_all_usernames (authored by varun).
[identity] get all usernames and wallet addresses in get_all_usernames
Jul 22 2024, 10:03 AM
varun added a comment to D12831: [identity] get all usernames and wallet addresses in get_all_usernames.

Accepting, but I noticed one more thing that needs to be considered.
Scan operation doesn't always return all items. It has response limit of 1MB. If it's exceeded, the response contains LastEvaluatedKey property, from which we should start a subsequent scan.

On the other hand, this table is relatively small (1k items, ~60kB) so it's far from the limit. And it's not expected to grow, so we could ignore the issue as well

AWS Docs: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Scan.html

Jul 22 2024, 9:56 AM
varun closed D12822: [terraform] bump staging identity to 0.32-staging.
Jul 22 2024, 7:40 AM
varun closed D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.
Jul 22 2024, 7:40 AM
varun committed rCOMM7c295141bbfc: [terraform] bump staging identity to 0.32-staging (authored by varun).
[terraform] bump staging identity to 0.32-staging
Jul 22 2024, 7:40 AM
varun committed rCOMMc5c4435b7b75: [identity] use redact_sensitive_data config to redact sensitive data in logs (authored by varun).
[identity] use redact_sensitive_data config to redact sensitive data in logs
Jul 22 2024, 7:40 AM
varun closed D12819: [identity] redact_sensitive_data config.
Jul 22 2024, 7:40 AM
varun committed rCOMMa7cfa610e0f3: [identity] redact_sensitive_data config (authored by varun).
[identity] redact_sensitive_data config
Jul 22 2024, 7:40 AM

Jul 21 2024

varun published D12832: [identity] modify get_all_user_details to return wallet addresses too for review.
Jul 21 2024, 8:54 PM
varun requested review of D12831: [identity] get all usernames and wallet addresses in get_all_usernames.
Jul 21 2024, 3:23 PM
varun requested review of D12830: [identity] check users table before reserved usernames table for user ID during wallet login.
Jul 21 2024, 1:38 PM

Jul 20 2024

varun published D12822: [terraform] bump staging identity to 0.32-staging for review.
Jul 20 2024, 12:03 AM
varun requested review of D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.
Jul 20 2024, 12:03 AM
varun updated the diff for D12819: [identity] redact_sensitive_data config.

env var should be string

Jul 20 2024, 12:01 AM

Jul 19 2024

varun requested review of D12819: [identity] redact_sensitive_data config.
Jul 19 2024, 11:55 PM
varun abandoned D12818: [identity] remove user ID from "no device list" log.

abandoning in favor of D12819 and D12820

Jul 19 2024, 11:41 PM
varun requested review of D12818: [identity] remove user ID from "no device list" log.
Jul 19 2024, 10:55 PM
varun requested review of D12809: [lib] add new selector and function to get own user's keyserver device ID.
Jul 19 2024, 2:34 PM
varun requested review of D12805: [lib] introduce new device list function to replace keyserver device.
Jul 19 2024, 1:09 PM

Jul 18 2024

varun added inline comments to D12734: [lib] add device type to qr code URL.
Jul 18 2024, 9:39 PM
varun accepted D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
Jul 18 2024, 4:06 PM
varun closed D12798: [terraform] bump staging identity to 0.31-staging.
Jul 18 2024, 3:49 PM
varun committed rCOMM2bfca588eb95: [terraform] bump staging identity to 0.31-staging (authored by varun).
[terraform] bump staging identity to 0.31-staging
Jul 18 2024, 3:49 PM
varun requested review of D12798: [terraform] bump staging identity to 0.31-staging.
Jul 18 2024, 2:21 PM
varun closed D12797: [identity] increase connect timeout to 60 seconds.
Jul 18 2024, 2:03 PM
varun committed rCOMMee487b75b248: [identity] increase connect timeout to 60 seconds (authored by varun).
[identity] increase connect timeout to 60 seconds
Jul 18 2024, 2:03 PM
varun requested review of D12797: [identity] increase connect timeout to 60 seconds.
Jul 18 2024, 1:49 PM
varun closed D12792: [terraform] Increase Identity memory to 2048.
Jul 18 2024, 12:04 PM
varun committed rCOMM2f2e98ec0869: [terraform] Increase Identity memory to 2048 (authored by bartek).
[terraform] Increase Identity memory to 2048
Jul 18 2024, 12:04 PM
varun updated the diff for D12792: [terraform] Increase Identity memory to 2048.

commandeer

Jul 18 2024, 11:15 AM
varun commandeered D12792: [terraform] Increase Identity memory to 2048.

bartek is afk so i'm going to commandeer and land

Jul 18 2024, 10:59 AM
varun accepted D12792: [terraform] Increase Identity memory to 2048.
Jul 18 2024, 7:41 AM

Jul 17 2024

varun accepted D12725: [terraform] add Tunnelbroker configuration variable to self-host.
Jul 17 2024, 2:17 PM
varun added inline comments to D12734: [lib] add device type to qr code URL.
Jul 17 2024, 11:09 AM

Jul 12 2024

varun closed D12732: [terraform] bump prod identity to 0.29.
Jul 12 2024, 2:08 PM
varun committed rCOMM05fa3c592f34: [terraform] bump prod identity to 0.29 (authored by varun).
[terraform] bump prod identity to 0.29
Jul 12 2024, 2:08 PM
varun requested review of D12734: [lib] add device type to qr code URL.
Jul 12 2024, 12:34 PM
varun closed D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 12:19 PM
varun committed rCOMM63899045a319: [native] modify SecondaryDeviceQRCodeScanner to support emulator (authored by varun).
[native] modify SecondaryDeviceQRCodeScanner to support emulator
Jul 12 2024, 12:19 PM
varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Jul 12 2024, 10:37 AM
varun closed D12619: [keyserver] display copyable url for qr code auth.
Jul 12 2024, 12:18 AM
varun closed D12618: [keyserver] don't display the QR code if keyserver is already logged in.
Jul 12 2024, 12:18 AM