Here is the task: https://linear.app/comm/issue/ENG-7428/discuss-how-to-set-csat-on-native

On web we handle register and login in a special reducer - D11238. This was done following the discussion in D11022. This diff should then remove handling identityRegisterActionTypes.success from reduceServicesAccessToken in web/redux/services-access-token-reducer.js
But I still don't know how we handle / plan to handle CSAT changes while the user is logged in (which I think are possible if identity invalidates the session? cc. @varun )

In the issue you said:

However, reduceServicesAccessToken does not have code to set the CSAT on identityRegisterActionTypes.success. The end result is that the CSAT is cleared on this action, after initially being set by AccessTokenHandler via setAccessTokenActionType (triggered by getCommServicesAuthMetadataEmitter that comes before identityRegisterActionTypes.success).

Great, thank you!

Rebase

Stop sending commServicesAccessToken from keyserver

Rebase

Rebase

Fix broken legacy logins

If running inside buildkite or github actions - exit.
I tested that if both are empty, the sqript continues, and if one of them or both are not empty, the script exits

Rename to getUserCredentials

Silence output

Add timeout

emscripten hangs because it waits for user input

Address review

Make the code more readable

Print instructions for nix only in dev mode

I created a task to update NODE_ENV usage: ENG-7195

Address review

LGTM, although I am not familiar with our Objective-C/java code

Don't create backup if db not present or empty

Rebase over D11283

In D11283#325663, @ginsu wrote:

Code LGTM, in ENG-6298 you mentioned,

The only hack is that if we don't have the user in our user store, we display a fake username. But the id is correct.

Probably would be good to create a followup task to address this new hack

Address review

In D11268#325681, @ashoat wrote:

But docker keyserver prints undefined as the value of process.env.NODE_ENV

Hmm... we shouild probably should avoid this ambiguous situation, and make sure we always specify NODE_ENV in the Docker environment. Can you create a task?

Would checking process.env.NODE_ENV !== 'production' make sense? Is the real production keyserver set up to have process.env.NODE_ENV == 'production'?

It doesn't look like I have anything specified in the .env file. If you're correct that the default keyserver is to have undefined, then I'm guessing my keyserver in production also has undefined. If it's helpful, I can do some additional testing on this.

Address review

Address revie

Should we only print this log in dev mode?

Use the real user id on native as well

Rebase

This is quite hacky, but I guess it's fine since it's temporary

Update text

Can you explain why we don't want to persist ops? Wouldn't it be a problem if redux store got updated, but the app was closed before ops had the time to update the db?

Use an export list

Address review

Unify around cookieInvalidated. I'm open to another approach, so @inka feel free to let me know if I should go the other way

Separately, something I'm wondering about... in some cases we check action.payload.sessionChange.cookieInvalidated, and in others we check action.payload.sessionChange.currentUserInfo?.anonymous. Is there any difference in these checks? Should we unify them? Wanted to ask @inka as they have touched this code recently and probably made the same observation.