Page MenuHomePhabricator
Feed Advanced Search

Mar 19 2024

bartek added inline comments to D11331: [web] Add QR auth handler logic.
Mar 19 2024, 5:57 AM
bartek closed D11291: [native][web] Expose Secondary device registration RPC to JS.
Mar 19 2024, 4:19 AM
bartek closed D11292: [lib] Expose isAuthorized property in Tunnelbroker context.
Mar 19 2024, 4:19 AM
bartek committed rCOMM8962994db2af: [native][web] Expose Secondary device registration RPC to JS (authored by bartek).
[native][web] Expose Secondary device registration RPC to JS
Mar 19 2024, 4:18 AM
bartek committed rCOMMadb2fa281ce5: [lib] Expose isAuthorized property in Tunnelbroker context (authored by bartek).
[lib] Expose isAuthorized property in Tunnelbroker context
Mar 19 2024, 4:18 AM
bartek closed D11290: [native][web] Expose Device List RPCs to JS.
Mar 19 2024, 4:18 AM
bartek committed rCOMM8105e6af9a3e: [native][web] Expose Device List RPCs to JS (authored by bartek).
[native][web] Expose Device List RPCs to JS
Mar 19 2024, 4:18 AM

Mar 18 2024

bartek updated the diff for D11292: [lib] Expose isAuthorized property in Tunnelbroker context.

Rebase before landing

Mar 18 2024, 6:57 AM
bartek updated the diff for D11332: [web][native] Encrypt QR auth messages with AES.

Rebase

Mar 18 2024, 5:34 AM
bartek updated the diff for D11331: [web] Add QR auth handler logic.

Rebase

Mar 18 2024, 5:33 AM
bartek updated the diff for D11330: [lib][native] Extract QR code to a spearate component.

Rebase

Mar 18 2024, 5:33 AM
bartek updated the diff for D11301: [native] Broadcast device list update and send backup key stub.

Add invariant

Mar 18 2024, 5:22 AM
bartek added inline comments to D11301: [native] Broadcast device list update and send backup key stub.
Mar 18 2024, 5:21 AM
bartek published D11346: [lib][native] Call backup restore protocol after QR auth for review.
Mar 18 2024, 5:10 AM
bartek published D11345: [native] Expose backup ct1 and ct2 functions to JS for review.
Mar 18 2024, 5:10 AM
bartek updated the diff for D11296: [native] Notify primary device on registration finish.

Address review feedback

Mar 18 2024, 5:09 AM
bartek added inline comments to D11296: [native] Notify primary device on registration finish.
Mar 18 2024, 5:09 AM
bartek updated the diff for D11295: [native] Upload secondary device keys when added to list.

Address review feedback

Mar 18 2024, 5:04 AM
bartek updated the diff for D11294: [native] Update device list on QR code scaned.

Address review feedback

Mar 18 2024, 4:57 AM
bartek added inline comments to D11294: [native] Update device list on QR code scaned.
Mar 18 2024, 4:55 AM
bartek updated the diff for D11293: [lib] Add Tunnelbroker message types for QR code auth.

Add backupLogDataKey to the backup message

Mar 18 2024, 4:53 AM
bartek published D11344: [native][rust] Split download_backup to separate ct1 and ct2 for review.
Mar 18 2024, 4:33 AM
bartek published D11332: [web][native] Encrypt QR auth messages with AES for review.
Mar 18 2024, 12:33 AM
bartek published D11331: [web] Add QR auth handler logic for review.
Mar 18 2024, 12:33 AM
bartek published D11330: [lib][native] Extract QR code to a spearate component for review.
Mar 18 2024, 12:33 AM
bartek accepted D11334: [native] add logOut to CommRustModule.
Mar 18 2024, 12:30 AM

Mar 14 2024

bartek accepted D11329: [identity] Update invalid username check on Identity service.
Mar 14 2024, 10:46 AM
bartek added inline comments to D11291: [native][web] Expose Secondary device registration RPC to JS.
Mar 14 2024, 6:14 AM
bartek updated the diff for D11291: [native][web] Expose Secondary device registration RPC to JS.

Address comments

Mar 14 2024, 6:12 AM
bartek added inline comments to D11291: [native][web] Expose Secondary device registration RPC to JS.
Mar 14 2024, 6:11 AM
bartek updated the diff for D11290: [native][web] Expose Device List RPCs to JS.

Added validator, added comment and fixed accidental newlines

Mar 14 2024, 6:03 AM
bartek added inline comments to D11293: [lib] Add Tunnelbroker message types for QR code auth.
Mar 14 2024, 2:07 AM
bartek added a comment to D11305: [terraform] use identity 0.12 on prod.

I wasn't following this convention in my services (on which I was working mostly alone), except for Identity where you introduced it. @varun's reasoning makes sense to me, so if it's helpful for you, I'm not opposed to keeping it. Especially since now there are three of us working on Identity so it's good to keep things clear

Mar 14 2024, 2:03 AM
bartek accepted D11320: [native] use findUserID RPC in UsernameSelection component.
Mar 14 2024, 1:51 AM

Mar 12 2024

bartek published D11301: [native] Broadcast device list update and send backup key stub for review.
Mar 12 2024, 2:20 AM
bartek published D11296: [native] Notify primary device on registration finish for review.
Mar 12 2024, 2:20 AM
bartek published D11295: [native] Upload secondary device keys when added to list for review.
Mar 12 2024, 2:19 AM
bartek published D11294: [native] Update device list on QR code scaned for review.
Mar 12 2024, 2:19 AM
bartek accepted D11278: [identity] add optional force param to password login RPC.
Mar 12 2024, 2:17 AM
bartek published D11293: [lib] Add Tunnelbroker message types for QR code auth for review.
Mar 12 2024, 1:37 AM

Mar 11 2024

bartek accepted D11305: [terraform] use identity 0.12 on prod.
Mar 11 2024, 10:40 PM
bartek published D11291: [native][web] Expose Secondary device registration RPC to JS for review.
Mar 11 2024, 7:27 AM
bartek published D11290: [native][web] Expose Device List RPCs to JS for review.
Mar 11 2024, 7:27 AM
bartek published D11292: [lib] Expose isAuthorized property in Tunnelbroker context for review.
Mar 11 2024, 7:27 AM
bartek added inline comments to D11278: [identity] add optional force param to password login RPC.
Mar 11 2024, 4:06 AM

Mar 7 2024

bartek accepted D11269: [keyserver] Immediately delete invite link blob.
Mar 7 2024, 4:30 AM

Mar 6 2024

bartek accepted D11250: [identity] validate origins provided through env var.
Mar 6 2024, 3:57 AM
bartek accepted D11251: [identity] let clap handle parsing env var to vec.
Mar 6 2024, 3:55 AM

Mar 4 2024

bartek accepted D11231: [identity] Replace elastic crate in identity.
Mar 4 2024, 9:57 PM
bartek accepted D11237: [lib] fix creating Tunnelbroker socket.
Mar 4 2024, 9:54 PM

Feb 16 2024

bartek closed D10862: [identity] Implement RPC for secondary device registration.
Feb 16 2024, 6:26 AM
bartek closed D10865: [native] Expose LogInSecondaryDevice RPC to JS.
Feb 16 2024, 6:26 AM
bartek closed D11073: [identity] Add types for Ed25519-signed nonce challenge.
Feb 16 2024, 6:26 AM
bartek committed rCOMMc89026bc3b6d: [native] Expose LogInSecondaryDevice RPC to JS (authored by bartek).
[native] Expose LogInSecondaryDevice RPC to JS
Feb 16 2024, 6:26 AM
bartek committed rCOMM12f4e8af8165: [identity] Implement RPC for secondary device registration (authored by bartek).
[identity] Implement RPC for secondary device registration
Feb 16 2024, 6:26 AM
bartek committed rCOMM56be0a1c5e98: [identity] Add types for Ed25519-signed nonce challenge (authored by bartek).
[identity] Add types for Ed25519-signed nonce challenge
Feb 16 2024, 6:26 AM
bartek closed D11072: [identity] Extract function to verify nonce.
Feb 16 2024, 6:26 AM
bartek committed rCOMM71e367ae06b1: [identity] Extract function to verify nonce (authored by bartek).
[identity] Extract function to verify nonce
Feb 16 2024, 6:26 AM
bartek closed D10861: [identity] Add RPC for secondary device login.
Feb 16 2024, 6:26 AM
bartek committed rCOMMecaaf648a29c: [identity] Add RPC for secondary device login (authored by bartek).
[identity] Add RPC for secondary device login
Feb 16 2024, 6:26 AM
bartek closed D11037: [native] Add Olm account sign function to commCoreModule.
Feb 16 2024, 6:26 AM
bartek committed rCOMM7c81d7e5dcda: [native] Add Olm account sign function to commCoreModule (authored by bartek).
[native] Add Olm account sign function to commCoreModule
Feb 16 2024, 6:26 AM
bartek added inline comments to D11073: [identity] Add types for Ed25519-signed nonce challenge.
Feb 16 2024, 6:23 AM
bartek updated the diff for D10865: [native] Expose LogInSecondaryDevice RPC to JS.

Rebase on AuthResponse

Feb 16 2024, 2:11 AM
bartek updated the diff for D10862: [identity] Implement RPC for secondary device registration.

Rebase. Remove unnecessary comments

Feb 16 2024, 2:11 AM
bartek updated the diff for D10861: [identity] Add RPC for secondary device login.

Rebase on AuthResponse

Feb 16 2024, 2:11 AM

Feb 15 2024

bartek updated the diff for D11037: [native] Add Olm account sign function to commCoreModule.

Address feedback

Feb 15 2024, 11:19 PM
bartek accepted D11101: [services] tidy up our identity service code.
Feb 15 2024, 10:31 PM
bartek accepted D11079: [lib][native] rename registerUser -> registerPasswordUser.
Feb 15 2024, 10:27 PM
bartek accepted D11078: [identity] introduce RegisterWalletUser RPC.
Feb 15 2024, 10:26 PM
bartek accepted D11098: [native] add findUserIDForWalletAddress to CommRustModule.

Makes sense to me. We can easily refactor this in the future when we find a better way of passing enums JS -> C++ -> Rust

Feb 15 2024, 10:23 PM
bartek accepted D11081: [native] add CommRustModule bindings for registerWalletUser.
Feb 15 2024, 10:11 PM
bartek accepted D11080: [native_rust_library] add register_wallet_user function.
Feb 15 2024, 10:10 PM
bartek added inline comments to D11073: [identity] Add types for Ed25519-signed nonce challenge.
Feb 15 2024, 10:08 PM
bartek requested review of D11073: [identity] Add types for Ed25519-signed nonce challenge.
Feb 15 2024, 9:53 PM

Feb 14 2024

bartek published D11073: [identity] Add types for Ed25519-signed nonce challenge for review.
Feb 14 2024, 4:56 AM
bartek published D11072: [identity] Extract function to verify nonce for review.
Feb 14 2024, 4:52 AM
bartek updated the diff for D10862: [identity] Implement RPC for secondary device registration.

Update on parent feedback, introduce nonce challenge

Feb 14 2024, 4:47 AM
bartek retitled D10862: [identity] Implement RPC for secondary device registration from [identity] Implement RPC for secondary device login to [identity] Implement RPC for secondary device registration.
Feb 14 2024, 4:44 AM
bartek added inline comments to D11037: [native] Add Olm account sign function to commCoreModule.
Feb 14 2024, 3:21 AM
bartek accepted D11062: [identity] rename LogInReservedWalletUser -> RegisterReservedWalletUser.
Feb 14 2024, 2:19 AM
bartek accepted D11061: [identity] Merge Identity auth response messages.

Thanks for doing this!

Feb 14 2024, 2:19 AM
bartek accepted D11052: [identity] move findUserID to unauth proto.
Feb 14 2024, 2:16 AM

Feb 13 2024

bartek accepted D11051: [services] Move reserved_usernames to `shared`.
Feb 13 2024, 8:42 AM
bartek accepted D10973: [lib] Check for previous auth message and websocket connection state in identity search context provider.
Feb 13 2024, 6:01 AM
bartek added inline comments to D11046: Introduce MMKV to Android app.
Feb 13 2024, 5:50 AM
bartek accepted D11015: [blob] Block reserved and offensive links from being created.
Feb 13 2024, 5:14 AM
bartek accepted D11039: [backup] Move authentication inside of the websocket.
Feb 13 2024, 5:14 AM

Feb 12 2024

bartek closed D11028: [terraform] Remove is-dev conditionals for DDB tables.
Feb 12 2024, 8:20 AM
bartek committed rCOMMe4c8ec1585a4: [terraform] Remove is-dev conditionals for DDB tables (authored by bartek).
[terraform] Remove is-dev conditionals for DDB tables
Feb 12 2024, 8:20 AM
bartek published D11037: [native] Add Olm account sign function to commCoreModule for review.
Feb 12 2024, 6:48 AM
bartek closed D10864: [native] Expose UpdateDeviceList RPC to JS.
Feb 12 2024, 1:26 AM
bartek closed D10863: [native] Expose GetDeviceListForUser RPC to JS.
Feb 12 2024, 1:26 AM
bartek committed rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS (authored by bartek).
[native] Expose UpdateDeviceList RPC to JS
Feb 12 2024, 1:26 AM
bartek closed D10800: [commtest] Add test for UpdateDeviceList RPC.
Feb 12 2024, 1:26 AM
bartek committed rCOMMcf34b3be50be: [native] Expose GetDeviceListForUser RPC to JS (authored by bartek).
[native] Expose GetDeviceListForUser RPC to JS
Feb 12 2024, 1:26 AM
bartek committed rCOMMee22cca2ef6c: [commtest] Add test for UpdateDeviceList RPC (authored by bartek).
[commtest] Add test for UpdateDeviceList RPC
Feb 12 2024, 1:26 AM
bartek closed D10799: [identity] Basic implementation of UpdateDeviceList RPC.
Feb 12 2024, 1:26 AM
bartek committed rCOMMa25f5283e44f: [identity] Basic implementation of UpdateDeviceList RPC (authored by bartek).
[identity] Basic implementation of UpdateDeviceList RPC
Feb 12 2024, 1:26 AM
bartek closed D10798: [identity] Make device list transactions more flexible.
Feb 12 2024, 1:26 AM