Page MenuHomePhabricator
Feed Advanced Search

Apr 21 2023

kamil added inline comments to D7486: [native][utils-module] Implement base64 encode.
Apr 21 2023, 1:09 AM

Apr 20 2023

kamil accepted D7486: [native][utils-module] Implement base64 encode.
Apr 20 2023, 1:30 AM

Apr 19 2023

kamil accepted D7485: [native][utils-module] Implement file r/w operations.
Apr 19 2023, 12:08 PM
kamil closed D7422: [native] generate operation for updating thread last navigated to.
Apr 19 2023, 11:48 AM
kamil committed rCOMM641db5f9dbb7: [native] generate operation for updating thread last navigated to (authored by kamil).
[native] generate operation for updating thread last navigated to
Apr 19 2023, 11:48 AM
kamil updated the diff for D7422: [native] generate operation for updating thread last navigated to.

rebase

Apr 19 2023, 11:25 AM
kamil closed D7421: [native] extract processing store operations to separate function.
Apr 19 2023, 11:05 AM
kamil committed rCOMM42addc2abaa8: [native] extract processing store operations to separate function (authored by kamil).
[native] extract processing store operations to separate function
Apr 19 2023, 11:05 AM
kamil added inline comments to D7421: [native] extract processing store operations to separate function.
Apr 19 2023, 10:46 AM
kamil updated the diff for D7421: [native] extract processing store operations to separate function.

fix typo

Apr 19 2023, 10:45 AM
kamil closed D7420: [lib] generate message store ops for threads after pruning messages.
Apr 19 2023, 10:29 AM
kamil closed D7419: [lib] generate message store ops for threads after creating local message.
Apr 19 2023, 10:29 AM
kamil closed D7418: [lib] generate message store ops for threads after sending message.
Apr 19 2023, 10:29 AM
kamil committed rCOMM404694cc17ab: [lib] generate message store ops for threads after creating local message (authored by kamil).
[lib] generate message store ops for threads after creating local message
Apr 19 2023, 10:29 AM
kamil committed rCOMMf0881e7ce160: [lib] generate message store ops for threads after sending message (authored by kamil).
[lib] generate message store ops for threads after sending message
Apr 19 2023, 10:29 AM
kamil committed rCOMM9b6134cc78e7: [lib] generate message store ops for threads after pruning messages (authored by kamil).
[lib] generate message store ops for threads after pruning messages
Apr 19 2023, 10:29 AM
kamil closed D7417: [lib] generate message store ops for threads while starting to send a message.
Apr 19 2023, 10:29 AM
kamil closed D7410: [lib] generate message store ops for threads while creating fresh store.
Apr 19 2023, 10:29 AM
kamil closed D7412: [lib] generate message store ops for threads on reaction failure.
Apr 19 2023, 10:29 AM
kamil committed rCOMM30191630a95d: [lib] generate message store ops for threads while creating fresh store (authored by kamil).
[lib] generate message store ops for threads while creating fresh store
Apr 19 2023, 10:28 AM
kamil committed rCOMMd656ac8e8e85: [lib] generate message store ops for threads on reaction failure (authored by kamil).
[lib] generate message store ops for threads on reaction failure
Apr 19 2023, 10:28 AM
kamil committed rCOMMd797d87dabcd: [lib] generate message store ops for threads while starting to send a message (authored by kamil).
[lib] generate message store ops for threads while starting to send a message
Apr 19 2023, 10:28 AM
kamil closed D7397: [lib] restore function for asserting store after performing ops.
Apr 19 2023, 10:28 AM
kamil closed D7398: [lib] generate message store ops for threads while merging messages.
Apr 19 2023, 10:28 AM
kamil committed rCOMM543ffeb69feb: [lib] restore function for asserting store after performing ops (authored by kamil).
[lib] restore function for asserting store after performing ops
Apr 19 2023, 10:28 AM
kamil committed rCOMM9a848cab0e86: [lib] generate message store ops for threads while merging messages (authored by kamil).
[lib] generate message store ops for threads while merging messages
Apr 19 2023, 10:28 AM
kamil closed D7396: [lib] add ops for message store threads.
Apr 19 2023, 10:28 AM
kamil committed rCOMM1bc50d14e8a2: [lib] add ops for message store threads (authored by kamil).
[lib] add ops for message store threads
Apr 19 2023, 10:28 AM
kamil updated the diff for D7420: [lib] generate message store ops for threads after pruning messages.

remove spreading

Apr 19 2023, 9:35 AM
kamil added inline comments to D7419: [lib] generate message store ops for threads after creating local message.
Apr 19 2023, 9:31 AM
kamil updated the diff for D7419: [lib] generate message store ops for threads after creating local message.

avoid creating additional variable

Apr 19 2023, 9:30 AM
kamil added inline comments to D7418: [lib] generate message store ops for threads after sending message.
Apr 19 2023, 9:26 AM
kamil updated the diff for D7418: [lib] generate message store ops for threads after sending message.

remove spread operator and rebase

Apr 19 2023, 9:26 AM
kamil added inline comments to D7417: [lib] generate message store ops for threads while starting to send a message.
Apr 19 2023, 9:17 AM
kamil updated the diff for D7417: [lib] generate message store ops for threads while starting to send a message.

extract shared code and rebase

Apr 19 2023, 9:16 AM
kamil updated the diff for D7412: [lib] generate message store ops for threads on reaction failure.

rebase before landing

Apr 19 2023, 9:11 AM
kamil added inline comments to D7410: [lib] generate message store ops for threads while creating fresh store.
Apr 19 2023, 9:10 AM
kamil updated the diff for D7410: [lib] generate message store ops for threads while creating fresh store.

change ops order

Apr 19 2023, 9:10 AM
kamil updated the diff for D7398: [lib] generate message store ops for threads while merging messages.

remove comment, create ops only when it makes sense and rebase

Apr 19 2023, 9:08 AM
kamil updated the diff for D7397: [lib] restore function for asserting store after performing ops.

rebase before landing

Apr 19 2023, 9:01 AM
kamil updated the diff for D7396: [lib] add ops for message store threads.

rebase before landing

Apr 19 2023, 9:01 AM

Apr 18 2023

kamil requested review of D7417: [lib] generate message store ops for threads while starting to send a message.

@tomek more context about this diff:

Apr 18 2023, 7:12 AM
kamil requested review of D7412: [lib] generate message store ops for threads on reaction failure.
Apr 18 2023, 5:52 AM
kamil requested review of D7398: [lib] generate message store ops for threads while merging messages.

Back to you with response to comments - I will update two nits (not creating op for empty array and removing comment) shortly

Apr 18 2023, 5:50 AM
kamil published D7473: [native] retrieve message store threads from SQLite and compare with `redux-persist` for review.
Apr 18 2023, 2:58 AM
kamil published D7472: [CommCoreModule] implement logic to get message store threads from SQLite for review.
Apr 18 2023, 2:57 AM
kamil published D7471: [native] migrate message store threads to SQLite for review.
Apr 18 2023, 2:56 AM
kamil published D7470: [native] enable performing message store threads ops for review.
Apr 18 2023, 2:55 AM
kamil published D7469: [CommCoreModule] implement ops for message store threads for review.
Apr 18 2023, 2:52 AM
kamil published D7468: [CommCoreModule] add table for message store threads for review.
Apr 18 2023, 2:50 AM

Apr 13 2023

kamil published D7422: [native] generate operation for updating thread last navigated to for review.
Apr 13 2023, 8:32 AM
kamil published D7421: [native] extract processing store operations to separate function for review.
Apr 13 2023, 8:31 AM
kamil published D7420: [lib] generate message store ops for threads after pruning messages for review.
Apr 13 2023, 8:31 AM
kamil published D7419: [lib] generate message store ops for threads after creating local message for review.
Apr 13 2023, 8:29 AM
kamil published D7418: [lib] generate message store ops for threads after sending message for review.
Apr 13 2023, 8:28 AM
kamil published D7417: [lib] generate message store ops for threads while starting to send a message for review.
Apr 13 2023, 8:27 AM
kamil published D7412: [lib] generate message store ops for threads on reaction failure for review.
Apr 13 2023, 8:26 AM
kamil published D7410: [lib] generate message store ops for threads while creating fresh store for review.
Apr 13 2023, 8:25 AM
kamil published D7398: [lib] generate message store ops for threads while merging messages for review.
Apr 13 2023, 8:24 AM
kamil published D7397: [lib] restore function for asserting store after performing ops for review.
Apr 13 2023, 8:18 AM
kamil published D7396: [lib] add ops for message store threads for review.
Apr 13 2023, 8:18 AM

Apr 11 2023

kamil accepted D7350: [keyserver] Add an arrow next to a link.

Can you share a screenshot of how it looks?

Apr 11 2023, 2:21 AM
kamil accepted D7348: [keyserver] Add background and logo images.
Apr 11 2023, 2:10 AM
kamil accepted D7330: [keyserver] Use correct font for Comm title.
Apr 11 2023, 2:04 AM
kamil accepted D7312: [keyserver] Create a page with invite link.
Apr 11 2023, 1:55 AM
kamil accepted D7329: [web] Check if notifications are supported.

LGTM but check @inka's comment

Apr 11 2023, 1:33 AM

Apr 6 2023

kamil closed D7288: [web-db] extract worker write requests to a separate condition.
Apr 6 2023, 3:59 AM
kamil committed rCOMM49c2a6e22823: [web-db] extract worker write requests to a separate condition (authored by kamil).
[web-db] extract worker write requests to a separate condition
Apr 6 2023, 3:59 AM
kamil updated the diff for D7288: [web-db] extract worker write requests to a separate condition.

early exit

Apr 6 2023, 3:36 AM
kamil closed D7190: [web-db] implement custom `redux-persist` storage.
Apr 6 2023, 3:31 AM
kamil committed rCOMM47a0e5eea8dd: [web-db] implement custom `redux-persist` storage (authored by kamil).
[web-db] implement custom `redux-persist` storage
Apr 6 2023, 3:31 AM
kamil closed D7189: [web-db] add database module provider.
Apr 6 2023, 3:31 AM
kamil committed rCOMM4ec416f4717d: [web-db] add database module provider (authored by kamil).
[web-db] add database module provider
Apr 6 2023, 3:31 AM
kamil updated the diff for D7189: [web-db] add database module provider.

simplify error function

Apr 6 2023, 3:09 AM
kamil closed D7188: [web-db] support SQLite for staff and non-mobile browsers.
Apr 6 2023, 3:06 AM
kamil committed rCOMM852d009eb408: [web-db] support SQLite for staff and non-mobile browsers (authored by kamil).
[web-db] support SQLite for staff and non-mobile browsers
Apr 6 2023, 3:06 AM
kamil added inline comments to D7188: [web-db] support SQLite for staff and non-mobile browsers.
Apr 6 2023, 2:42 AM
kamil updated the diff for D7188: [web-db] support SQLite for staff and non-mobile browsers.

change conditions

Apr 6 2023, 2:40 AM
kamil accepted D7314: [keyserver] Use the same font as on web.
Apr 6 2023, 2:26 AM
kamil accepted D7312: [keyserver] Create a page with invite link.

It looks like the design has changed but accepting as it will be updated in next iterations, according to summary

Apr 6 2023, 2:25 AM
kamil accepted D7311: [keyserver] Move deep link handling logic to a separate function.
Apr 6 2023, 1:45 AM

Apr 4 2023

kamil accepted D7286: [desktop] Extract showNewNotification function.
Apr 4 2023, 1:26 AM

Apr 3 2023

kamil published D7289: [web-db] improve persisting lifecycle for review.
Apr 3 2023, 5:59 AM
kamil added inline comments to D7188: [web-db] support SQLite for staff and non-mobile browsers.
Apr 3 2023, 5:58 AM
kamil published D7288: [web-db] extract worker write requests to a separate condition for review.
Apr 3 2023, 5:37 AM
kamil added inline comments to D7186: [web-db] start persisting SQLite content.
Apr 3 2023, 5:05 AM
kamil closed D7186: [web-db] start persisting SQLite content.
Apr 3 2023, 4:48 AM
kamil committed rCOMMc38e70c6d6ee: [web-db] start persisting SQLite content (authored by kamil).
[web-db] start persisting SQLite content
Apr 3 2023, 4:48 AM
kamil added inline comments to D7191: [web-db] implement clearing sensitive data.
Apr 3 2023, 3:02 AM
kamil updated the diff for D7191: [web-db] implement clearing sensitive data.

remove unused effect dependency

Apr 3 2023, 2:59 AM
kamil updated the diff for D7191: [web-db] implement clearing sensitive data.

refactor

Apr 3 2023, 2:57 AM
kamil added inline comments to D7190: [web-db] implement custom `redux-persist` storage.
Apr 3 2023, 2:52 AM
kamil updated the diff for D7190: [web-db] implement custom `redux-persist` storage.

use implicit promises

Apr 3 2023, 2:52 AM
kamil added a comment to D7189: [web-db] add database module provider.

@tomek I changed the logic a bit, so I will not respond directly to your questions but adding inline comments which should cover are your concerns

Apr 3 2023, 2:50 AM
kamil updated the diff for D7189: [web-db] add database module provider.

refactor code

Apr 3 2023, 2:43 AM
kamil updated the summary of D7188: [web-db] support SQLite for staff and non-mobile browsers.
Apr 3 2023, 2:31 AM
kamil added a comment to D7188: [web-db] support SQLite for staff and non-mobile browsers.

Thanks, @ashoat. You identified a severe issue with doing it on the keyserver. Moving logic to client-side

Apr 3 2023, 2:27 AM
kamil updated the diff for D7188: [web-db] support SQLite for staff and non-mobile browsers.

move logic to client-side

Apr 3 2023, 2:23 AM
kamil updated the diff for D7186: [web-db] start persisting SQLite content.

use _throttle instead of _debounce

Apr 3 2023, 2:11 AM
kamil accepted D7257: [native] Add `avatar` column to clientDB `threads` table.

LGTM!

Apr 3 2023, 12:33 AM