Added @ashoat as a blocking reviewer since he's able to reproduce invalid group specifier name error.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Oct 3 2023
Oct 2 2023
Expo has high expectations for issue reports... basically they want a minimally viable reproducible example for each report.
Would be great to get this landed soon as more of the team installs Xcode 15. I looked through Expo's GitHub issues and was surprised I couldn't find anybody else experiencing this, and that the file still had this "issue" on main.
Move logic to a hook. Had to add a hook, because navigation is native specific, and we want this behaviour to only be present on native
I have one question, maybe I am missing some context but I think after initializing and encrypting the initial message session should be persisted, otherwise this created session can not be used in the future. In notifications this is done via NotificationsCryptoModule::serializeAndFlushCryptoModule, because of some other limitations is done using file.
Here probably DatabaseManager::getQueryExecutor().storeOlmPersistData(); can be used.
Is it a different case and persistence is not needed?
Oct 1 2023
Accepting to unblock, but I have some questions and nits
Sep 30 2023
Whether or not this stack gets landed, was super helpful to understand how each solution alone/in combination with others would affect size of ThreadStore
Sep 29 2023
might make further sense to pull out to separate test data file?
looks good! Trusting test plan so skimmed through the test file
seems reasonable
Personally would prefer to inline these conditions but it doesn't matter a ton
rebase before landing
check if crypto module is initialized before calling initializeOutboundForSendingSession