Page MenuHomePhorge
Feed All Stories

Oct 3 2023

patryk added inline comments to D9344: [lib] Remove negative lookbehind assertions from chat mention regex.
Oct 3 2023, 7:50 AM
patryk added a comment to D9344: [lib] Remove negative lookbehind assertions from chat mention regex.

Added @ashoat as a blocking reviewer since he's able to reproduce invalid group specifier name error.

Oct 3 2023, 7:41 AM
patryk added 1 blocking reviewer(s) for D9344: [lib] Remove negative lookbehind assertions from chat mention regex: ashoat.
Oct 3 2023, 7:40 AM
patryk published D9344: [lib] Remove negative lookbehind assertions from chat mention regex for review.
Oct 3 2023, 7:40 AM
varun requested review of D9346: [native] implement getOutboundKeys method in CommRustModule.
Oct 3 2023, 3:24 AM
varun requested review of D9345: [keyserver] refactor olm session creator.
Oct 3 2023, 3:05 AM

Oct 2 2023

ashoat added inline comments to D9145: [web] Remove intial redux state from website responders.
Oct 2 2023, 11:47 PM
ashoat added inline comments to D9145: [web] Remove intial redux state from website responders.
Oct 2 2023, 11:45 PM
atul closed D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
Oct 2 2023, 8:07 PM
atul committed rCOMMd8d12a5c4ff8: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
Oct 2 2023, 8:07 PM
atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

https://linear.app/comm/issue/ENG-5157/investigate-xcode-15-foundation-import-issue

Oct 2 2023, 8:05 PM
atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

Expo has high expectations for issue reports... basically they want a minimally viable reproducible example for each report.

Oct 2 2023, 7:59 PM
ashoat added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

Would be great to get this landed soon as more of the team installs Xcode 15. I looked through Expo's GitHub issues and was surprised I couldn't find anybody else experiencing this, and that the file still had this "issue" on main.

Oct 2 2023, 5:02 PM
inka requested review of D9095: [native] Block editing messages on search and pinned messages screens, and of the first message in a thread.
Oct 2 2023, 2:57 PM
inka updated the diff for D9095: [native] Block editing messages on search and pinned messages screens, and of the first message in a thread.

Move logic to a hook. Had to add a hook, because navigation is native specific, and we want this behaviour to only be present on native

Oct 2 2023, 2:56 PM
bartek closed D9282: [reports-service] Obtain service-to-service token for anonymous requests.
Oct 2 2023, 1:53 PM
bartek committed rCOMMd720180112f1: [reports-service] Obtain service-to-service token for anonymous requests.
Oct 2 2023, 1:53 PM
michal accepted D9282: [reports-service] Obtain service-to-service token for anonymous requests.
Oct 2 2023, 1:44 PM
bartek closed D9281: [blob][reports] Provide identity service endpoint.
Oct 2 2023, 1:27 PM
bartek closed D9280: [services-lib] Introduce AuthService for token verification.
Oct 2 2023, 1:27 PM
bartek closed D9279: [services-lib] Add fn to verify services token.
Oct 2 2023, 1:27 PM
bartek committed rCOMM3eab259330b4: [blob][reports] Provide identity service endpoint.
Oct 2 2023, 1:27 PM
bartek committed rCOMM40f2fc828f2f: [services-lib] Introduce AuthService for token verification.
Oct 2 2023, 1:27 PM
bartek committed rCOMM8af116318d45: [services-lib] Add fn to verify services token.
Oct 2 2023, 1:27 PM
bartek closed D9277: [services-lib] Reorganize auth module.
Oct 2 2023, 1:27 PM
bartek closed D9276: [terraform] Add services token secret.
Oct 2 2023, 1:27 PM
bartek closed D9275: [services-lib] Let blob client use services token.
Oct 2 2023, 1:27 PM
bartek committed rCOMM756fa192986a: [services-lib] Reorganize auth module.
Oct 2 2023, 1:27 PM
bartek committed rCOMM8df72c372af7: [terraform] Add services token secret.
Oct 2 2023, 1:27 PM
bartek committed rCOMM6a1036d0b610: [services-lib] Let blob client use services token.
Oct 2 2023, 1:27 PM
bartek closed D9243: [services-lib] Support auth token in HTTP middleware.
Oct 2 2023, 1:27 PM
bartek closed D9242: [services-lib] Use constant-time-eq for token verification.
Oct 2 2023, 1:27 PM
bartek committed rCOMMd0a208d19dd8: [services-lib] Support auth token in HTTP middleware.
Oct 2 2023, 1:27 PM
bartek committed rCOMM863cdaaa62b7: [services-lib] Use constant-time-eq for token verification.
Oct 2 2023, 1:27 PM
bartek closed D9241: [services-lib] Add enum for authorization tokens.
Oct 2 2023, 1:27 PM
bartek committed rCOMMe5f09476d959: [services-lib] Add enum for authorization tokens.
Oct 2 2023, 1:27 PM
bartek added inline comments to D9282: [reports-service] Obtain service-to-service token for anonymous requests.
Oct 2 2023, 1:19 PM
kamil requested changes to D9334: [native] new method to initialize content olm session.

I have one question, maybe I am missing some context but I think after initializing and encrypting the initial message session should be persisted, otherwise this created session can not be used in the future. In notifications this is done via NotificationsCryptoModule::serializeAndFlushCryptoModule, because of some other limitations is done using file.
Here probably DatabaseManager::getQueryExecutor().storeOlmPersistData(); can be used.
Is it a different case and persistence is not needed?

Oct 2 2023, 9:37 AM

Oct 1 2023

ashoat accepted D9326: [lib] new/updated types for identity service olm auth responder.

Accepting to unblock, but I have some questions and nits

Oct 1 2023, 8:12 PM
ashoat closed D9343: [keyserver] Test impact of ThreadStore reductions on Atul's ThreadStore.
Oct 1 2023, 12:28 AM
ashoat closed D9341: [keyserver] Test combinations of approaches to reducing Ashoat's ThreadStore.
Oct 1 2023, 12:28 AM
ashoat closed D9342: [keyserver] Test results of ThreadStore reductions post-compression.
Oct 1 2023, 12:28 AM
ashoat committed rCOMMd2fdf5398d9e: [keyserver] Test impact of ThreadStore reductions on Atul's ThreadStore.
Oct 1 2023, 12:28 AM
ashoat committed rCOMM96cdc48f84a3: [keyserver] Test combinations of approaches to reducing Ashoat's ThreadStore.
Oct 1 2023, 12:28 AM
ashoat committed rCOMM0baf638a7209: [keyserver] Test results of ThreadStore reductions post-compression.
Oct 1 2023, 12:28 AM
ashoat closed D9340: [keyserver] Factor out logic for measuring / printing ThreadStore reduction results.
Oct 1 2023, 12:28 AM
ashoat closed D9339: [keyserver] Test impact of introducing ThreadRolePermissionsStore on Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat closed D9338: [keyserver] Test impact of introduction of isAdminRole on Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat committed rCOMMf07cf5c87230: [keyserver] Factor out logic for measuring / printing ThreadStore reduction….
Oct 1 2023, 12:27 AM
ashoat committed rCOMMe2c6070114b6: [keyserver] Test impact of introducing ThreadRolePermissionsStore on Ashoat's….
Oct 1 2023, 12:27 AM
ashoat committed rCOMMd0c13b4a2501: [keyserver] Test impact of introduction of isAdminRole on Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat closed D9336: [keyserver] Test impact of skipping old sidebars in Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat closed D9337: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat committed rCOMMea53718d4c7d: [keyserver] Test impact of skipping old sidebars in Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat committed rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore.
Oct 1 2023, 12:27 AM
ashoat closed D9335: [keyserver] Introduce script to test ThreadStore reductions.
Oct 1 2023, 12:27 AM
ashoat committed rCOMM0f869c6defbd: [keyserver] Introduce script to test ThreadStore reductions.
Oct 1 2023, 12:27 AM

Sep 30 2023

atul accepted D9343: [keyserver] Test impact of ThreadStore reductions on Atul's ThreadStore.

Whether or not this stack gets landed, was super helpful to understand how each solution alone/in combination with others would affect size of ThreadStore

Sep 30 2023, 2:39 AM
atul accepted D9342: [keyserver] Test results of ThreadStore reductions post-compression.
Sep 30 2023, 2:36 AM
atul accepted D9341: [keyserver] Test combinations of approaches to reducing Ashoat's ThreadStore.
Sep 30 2023, 2:36 AM
atul accepted D9340: [keyserver] Factor out logic for measuring / printing ThreadStore reduction results.
Sep 30 2023, 2:36 AM
atul accepted D9339: [keyserver] Test impact of introducing ThreadRolePermissionsStore on Ashoat's ThreadStore.
Sep 30 2023, 2:35 AM
atul accepted D9338: [keyserver] Test impact of introduction of isAdminRole on Ashoat's ThreadStore.
Sep 30 2023, 2:35 AM
atul accepted D9337: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore.
Sep 30 2023, 2:34 AM
atul accepted D9336: [keyserver] Test impact of skipping old sidebars in Ashoat's ThreadStore.
Sep 30 2023, 2:33 AM
atul accepted D9335: [keyserver] Introduce script to test ThreadStore reductions.
Sep 30 2023, 1:07 AM

Sep 29 2023

ashoat closed D9333: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo.
Sep 29 2023, 9:07 PM
ashoat committed rCOMM5bb5a97953f3: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo.
Sep 29 2023, 9:07 PM
ashoat closed D9332: [lib] Simplify threadIsGroupChat check.
Sep 29 2023, 9:07 PM
ashoat committed rCOMMb1240a3be09a: [lib] Simplify threadIsGroupChat check.
Sep 29 2023, 9:07 PM
ashoat requested review of D9343: [keyserver] Test impact of ThreadStore reductions on Atul's ThreadStore.
Sep 29 2023, 8:59 PM
ashoat requested review of D9342: [keyserver] Test results of ThreadStore reductions post-compression.
Sep 29 2023, 8:55 PM
ashoat requested review of D9340: [keyserver] Factor out logic for measuring / printing ThreadStore reduction results.
Sep 29 2023, 8:52 PM
ashoat requested review of D9341: [keyserver] Test combinations of approaches to reducing Ashoat's ThreadStore.
Sep 29 2023, 8:51 PM
ashoat requested review of D9339: [keyserver] Test impact of introducing ThreadRolePermissionsStore on Ashoat's ThreadStore.
Sep 29 2023, 8:51 PM
ashoat requested review of D9338: [keyserver] Test impact of introduction of isAdminRole on Ashoat's ThreadStore.
Sep 29 2023, 8:50 PM
ashoat requested review of D9337: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore.
Sep 29 2023, 8:49 PM
ashoat requested review of D9336: [keyserver] Test impact of skipping old sidebars in Ashoat's ThreadStore.
Sep 29 2023, 8:47 PM
ashoat requested review of D9335: [keyserver] Introduce script to test ThreadStore reductions.
Sep 29 2023, 8:45 PM
ginsu closed D9272: [native] introduce BottomSheetProvider.
Sep 29 2023, 8:27 PM
ginsu committed rCOMMb272611288b5: [native] introduce BottomSheetProvider.
Sep 29 2023, 8:27 PM
atul accepted D9331: [lib] Move test messages outside of the describe scope to reuse them.

might make further sense to pull out to separate test data file?

Sep 29 2023, 8:12 PM
atul accepted D9333: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo.
Sep 29 2023, 8:12 PM
ginsu accepted D9325: [lib] Introduce a canBeSidebarSource function in each message spec.
Sep 29 2023, 7:46 PM
ginsu added a comment to D9325: [lib] Introduce a canBeSidebarSource function in each message spec.

looks good! Trusting test plan so skimmed through the test file

Sep 29 2023, 7:46 PM
ginsu accepted D9324: [lib] Update types for SIDEBAR_SOURCE messages to reflect isInvalidSidebarSource.

seems reasonable

Sep 29 2023, 7:43 PM
ginsu abandoned D9273: [native] factor out UserProfileRelationshipButton condtionals.

Personally would prefer to inline these conditions but it doesn't matter a ton

Sep 29 2023, 7:36 PM
ashoat requested review of D9333: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo.
Sep 29 2023, 7:36 PM
ginsu updated the diff for D9272: [native] introduce BottomSheetProvider.

rebase before landing

Sep 29 2023, 7:33 PM
varun updated the diff for D9334: [native] new method to initialize content olm session.

check if crypto module is initialized before calling initializeOutboundForSendingSession

Sep 29 2023, 7:28 PM
atul accepted D9332: [lib] Simplify threadIsGroupChat check.
Sep 29 2023, 7:18 PM
ashoat updated the summary of D9332: [lib] Simplify threadIsGroupChat check.
Sep 29 2023, 7:17 PM
varun requested review of D9334: [native] new method to initialize content olm session.
Sep 29 2023, 7:15 PM
ginsu closed D9271: [native] improve organization of user profiles work.
Sep 29 2023, 7:10 PM
ginsu closed D9260: [native] improve BottomSheet component close function.
Sep 29 2023, 7:10 PM
ginsu committed rCOMM588581374141: [native] improve organization of user profiles work.
Sep 29 2023, 7:10 PM
ginsu closed D9258: [native] introduce UserProfileRelationshipButton.
Sep 29 2023, 7:10 PM
ginsu committed rCOMM647baa08494b: [native] improve BottomSheet component close function.
Sep 29 2023, 7:10 PM
ginsu closed D9252: [lib/native] introduce UserProfileMessageButton.
Sep 29 2023, 7:10 PM
ginsu committed rCOMMc4c8db828ad9: [native] introduce UserProfileRelationshipButton.
Sep 29 2023, 7:10 PM