Page MenuHomePhabricator

angelika (Angelika Serwa)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2024, 4:25 AM (23 w, 4 d)

Recent Activity

Yesterday

angelika closed D14481: [native] Remove ffmpeg dependency.
Thu, Mar 27, 12:21 PM
angelika closed D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.
Thu, Mar 27, 12:21 PM
angelika closed D14479: [ios] Implement transcodeVideo() function on iOS.
Thu, Mar 27, 12:21 PM
angelika committed rCOMM085ad9283c28: [native] Use transcodeVideo() from MediaModule instead of ffmpeg (authored by angelika).
[native] Use transcodeVideo() from MediaModule instead of ffmpeg
Thu, Mar 27, 12:21 PM
angelika committed rCOMM2fb795a199b7: [native] Remove ffmpeg dependency (authored by angelika).
[native] Remove ffmpeg dependency
Thu, Mar 27, 12:21 PM
angelika committed rCOMMf0d2a66750c1: [ios] Implement transcodeVideo() function on iOS (authored by angelika).
[ios] Implement transcodeVideo() function on iOS
Thu, Mar 27, 12:21 PM
angelika closed D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.
Thu, Mar 27, 12:21 PM
angelika closed D14478: [android] Implement transcodeVideo() function on Android.
Thu, Mar 27, 12:21 PM
angelika closed D14476: [ios] Implement generateThumbnail() function on iOS.
Thu, Mar 27, 12:21 PM
angelika committed rCOMM99354f3d9c3a: [android] Implement transcodeVideo() function on Android (authored by angelika).
[android] Implement transcodeVideo() function on Android
Thu, Mar 27, 12:21 PM
angelika committed rCOMMfb17f097913d: [ios] Implement generateThumbnail() function on iOS (authored by angelika).
[ios] Implement generateThumbnail() function on iOS
Thu, Mar 27, 12:21 PM
angelika committed rCOMM822d231b91d0: [native] Use generateThumbnail() from MediaModule instead of ffmpeg (authored by angelika).
[native] Use generateThumbnail() from MediaModule instead of ffmpeg
Thu, Mar 27, 12:21 PM
angelika closed D14475: [android] Implement generateThumbnail() function on Android.
Thu, Mar 27, 12:21 PM
angelika closed D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.
Thu, Mar 27, 12:21 PM
angelika closed D14473: [ios] Implement hasMultipleFrames() function on iOS.
Thu, Mar 27, 12:21 PM
angelika committed rCOMMa21fb87bf067: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg (authored by angelika).
[native] Use hasMultipleFrames() from MediaModule instead of ffmpeg
Thu, Mar 27, 12:21 PM
angelika committed rCOMMc7db39914da1: [android] Implement generateThumbnail() function on Android (authored by angelika).
[android] Implement generateThumbnail() function on Android
Thu, Mar 27, 12:21 PM
angelika committed rCOMMa6bdf5a306c7: [ios] Implement hasMultipleFrames() function on iOS (authored by angelika).
[ios] Implement hasMultipleFrames() function on iOS
Thu, Mar 27, 12:21 PM
angelika closed D14472: [android] Implement hasMultipleFrames() function on Android.
Thu, Mar 27, 12:21 PM
angelika closed D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.
Thu, Mar 27, 12:21 PM
angelika committed rCOMM7636a8a76a81: [android] Implement hasMultipleFrames() function on Android (authored by angelika).
[android] Implement hasMultipleFrames() function on Android
Thu, Mar 27, 12:21 PM
angelika committed rCOMMe75c93028829: [native] Use getVideoInfo from MediaModule instead of ffmpeg (authored by angelika).
[native] Use getVideoInfo from MediaModule instead of ffmpeg
Thu, Mar 27, 12:21 PM
angelika closed D14470: [ios] Implement getVideoInfo() function on iOS.
Thu, Mar 27, 12:21 PM
angelika closed D14469: [android] Implement getVideoInfo() function on Android.
Thu, Mar 27, 12:21 PM
angelika committed rCOMM1775e7d6d37f: [android] Implement getVideoInfo() function on Android (authored by angelika).
[android] Implement getVideoInfo() function on Android
Thu, Mar 27, 12:21 PM
angelika committed rCOMM7f1a59810cb8: [ios] Implement getVideoInfo() function on iOS (authored by angelika).
[ios] Implement getVideoInfo() function on iOS
Thu, Mar 27, 12:21 PM
angelika closed D14468: [native] Add MediaModule expo module.
Thu, Mar 27, 12:21 PM
angelika committed rCOMM7be92c55a5d9: [native] Add MediaModule expo module (authored by angelika).
[native] Add MediaModule expo module
Thu, Mar 27, 12:21 PM
angelika updated the diff for D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Set bitrate to 4000 kb/s

Thu, Mar 27, 9:08 AM
angelika updated the diff for D14479: [ios] Implement transcodeVideo() function on iOS.

Fix rotation issue on android video

Thu, Mar 27, 7:28 AM

Wed, Mar 26

angelika closed D14487: [ci] Update mac runner image in github workflows.
Wed, Mar 26, 5:52 AM
angelika committed rCOMM9828750c0be2: [ci] Update mac runner image in github workflows (authored by angelika).
[ci] Update mac runner image in github workflows
Wed, Mar 26, 5:52 AM

Tue, Mar 25

angelika added inline comments to D14481: [native] Remove ffmpeg dependency.
Tue, Mar 25, 10:21 PM
angelika added inline comments to D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.
Tue, Mar 25, 10:12 PM
angelika added inline comments to D14470: [ios] Implement getVideoInfo() function on iOS.
Tue, Mar 25, 10:10 PM
angelika updated the diff for D14481: [native] Remove ffmpeg dependency.

Rebase

Tue, Mar 25, 10:07 PM
angelika updated the diff for D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg.

Rebase

Tue, Mar 25, 10:06 PM
angelika updated the diff for D14479: [ios] Implement transcodeVideo() function on iOS.

Rebase & fix

Tue, Mar 25, 10:05 PM
angelika updated the diff for D14478: [android] Implement transcodeVideo() function on Android.

Rebase & review changes

Tue, Mar 25, 10:05 PM
angelika updated the diff for D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg.

Rebase

Tue, Mar 25, 10:04 PM
angelika updated the diff for D14476: [ios] Implement generateThumbnail() function on iOS.

Rebase

Tue, Mar 25, 10:04 PM
angelika updated the diff for D14475: [android] Implement generateThumbnail() function on Android.

Rebase & fix

Tue, Mar 25, 10:03 PM
angelika updated the diff for D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg.

Rebase

Tue, Mar 25, 10:03 PM
angelika updated the diff for D14473: [ios] Implement hasMultipleFrames() function on iOS.

Rebase

Tue, Mar 25, 10:02 PM
angelika updated the diff for D14472: [android] Implement hasMultipleFrames() function on Android.

Rebase

Tue, Mar 25, 10:02 PM
angelika updated the diff for D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg.

Rebase

Tue, Mar 25, 10:01 PM
angelika updated the diff for D14470: [ios] Implement getVideoInfo() function on iOS.

Rebase

Tue, Mar 25, 10:01 PM
angelika updated the diff for D14469: [android] Implement getVideoInfo() function on Android.

Rebase

Tue, Mar 25, 9:59 PM
angelika updated the diff for D14468: [native] Add MediaModule expo module.

Rebase

Tue, Mar 25, 9:59 PM

Fri, Mar 21

angelika requested review of D14487: [ci] Update mac runner image in github workflows.
Fri, Mar 21, 5:28 AM
angelika accepted D14486: [native] Script to bump native version.

LGTM, but:

  • don't we need to document it somewhere in some README?
  • as far as I understand to update the version you bump the version in version.mjs first, then run the script, can't we automate the first step too?
  • you can also automate making commits too later?
Fri, Mar 21, 12:32 AM

Thu, Mar 20

angelika published D14481: [native] Remove ffmpeg dependency for review.
Thu, Mar 20, 5:57 AM
angelika published D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:57 AM
angelika published D14479: [ios] Implement transcodeVideo() function on iOS for review.
Thu, Mar 20, 5:57 AM
angelika published D14478: [android] Implement transcodeVideo() function on Android for review.
Thu, Mar 20, 5:57 AM
angelika published D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:57 AM
angelika published D14476: [ios] Implement generateThumbnail() function on iOS for review.
Thu, Mar 20, 5:56 AM
angelika published D14475: [android] Implement generateThumbnail() function on Android for review.
Thu, Mar 20, 5:56 AM
angelika published D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:56 AM
angelika published D14473: [ios] Implement hasMultipleFrames() function on iOS for review.
Thu, Mar 20, 5:56 AM
angelika published D14472: [android] Implement hasMultipleFrames() function on Android for review.
Thu, Mar 20, 5:56 AM
angelika published D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:55 AM
angelika published D14470: [ios] Implement getVideoInfo() function on iOS for review.
Thu, Mar 20, 5:55 AM
angelika published D14469: [android] Implement getVideoInfo() function on Android for review.
Thu, Mar 20, 5:55 AM
angelika published D14468: [native] Add MediaModule expo module for review.
Thu, Mar 20, 5:55 AM

Mon, Mar 17

angelika closed D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.
Mon, Mar 17, 7:11 AM
angelika committed rCOMM14f44e8ce8a8: [native] Temporary fix for not opening FullScreenViewModal on Android (authored by angelika).
[native] Temporary fix for not opening FullScreenViewModal on Android
Mon, Mar 17, 7:11 AM

Thu, Mar 13

angelika accepted D14442: [native] update Podfile.lock.
Thu, Mar 13, 8:52 AM

Wed, Mar 12

angelika updated the diff for D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.

Rebase & fix outsideButtons on Android

Wed, Mar 12, 4:23 AM

Tue, Mar 11

angelika accepted D14434: [CI] update NDK to 23 and bump Corrosion.
Tue, Mar 11, 6:44 AM

Mon, Mar 10

angelika added inline comments to D14434: [CI] update NDK to 23 and bump Corrosion.
Mon, Mar 10, 8:27 AM
angelika added a comment to D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.

How does the app look like with a modal and the status bar visible?

Mon, Mar 10, 7:07 AM

Wed, Mar 5

angelika updated the summary of D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.
Wed, Mar 5, 2:36 AM
angelika published D14430: [native] Temporary fix for not opening FullScreenViewModal on Android for review.
Wed, Mar 5, 2:33 AM

Mon, Mar 3

angelika closed D14409: [native] Remove reanimated v1 code from animation-utils.js.
Mon, Mar 3, 5:58 AM
angelika closed D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.
Mon, Mar 3, 5:58 AM
angelika closed D14410: [native] Rename clampV2 to clamp.
Mon, Mar 3, 5:58 AM
angelika committed rCOMMe2e38d447227: [native] Remove tipHorizontalOffset from NUXTipsOverlay (authored by angelika).
[native] Remove tipHorizontalOffset from NUXTipsOverlay
Mon, Mar 3, 5:58 AM
angelika committed rCOMM510a19d15c0a: [native] Remove reanimated v1 code from animation-utils.js (authored by angelika).
[native] Remove reanimated v1 code from animation-utils.js
Mon, Mar 3, 5:58 AM
angelika committed rCOMM4e296f4ab640: [native] Rename clampV2 to clamp (authored by angelika).
[native] Rename clampV2 to clamp
Mon, Mar 3, 5:58 AM
angelika closed D14407: [native] Rename positionV2 to position in overlay navigator.
Mon, Mar 3, 5:58 AM
angelika closed D14408: [native] Rename progressV2 variables to progress.
Mon, Mar 3, 5:58 AM
angelika committed rCOMM0c8cb92c0d46: [native] Rename positionV2 to position in overlay navigator (authored by angelika).
[native] Rename positionV2 to position in overlay navigator
Mon, Mar 3, 5:58 AM
angelika committed rCOMMfcfc812c065a: [native] Rename progressV2 variables to progress (authored by angelika).
[native] Rename progressV2 variables to progress
Mon, Mar 3, 5:58 AM
angelika closed D14406: [native] Remove position from overlay navigator.
Mon, Mar 3, 5:57 AM
angelika committed rCOMMe99d6d2a3732: [native] Remove position from overlay navigator (authored by angelika).
[native] Remove position from overlay navigator
Mon, Mar 3, 5:57 AM

Feb 26 2025

angelika added a comment to D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.

Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase

Feb 26 2025, 3:09 AM

Feb 25 2025

angelika added a comment to D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.

Do we know what was the intention of this code and whether we have a corresponding logic in the Reanimated 2 code?

Feb 25 2025, 5:17 AM
angelika published D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay for review.
Feb 25 2025, 3:36 AM
angelika published D14410: [native] Rename clampV2 to clamp for review.
Feb 25 2025, 3:35 AM
angelika published D14409: [native] Remove reanimated v1 code from animation-utils.js for review.
Feb 25 2025, 3:35 AM
angelika published D14408: [native] Rename progressV2 variables to progress for review.
Feb 25 2025, 3:35 AM
angelika published D14407: [native] Rename positionV2 to position in overlay navigator for review.
Feb 25 2025, 3:35 AM
angelika published D14406: [native] Remove position from overlay navigator for review.
Feb 25 2025, 3:34 AM
angelika closed D14381: [web] Add colon in qr code login copy.
Feb 25 2025, 2:52 AM
angelika committed rCOMMb952e5ec7881: [web] Add colon in qr code login copy (authored by angelika).
[web] Add colon in qr code login copy
Feb 25 2025, 2:52 AM
angelika closed D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.
Feb 25 2025, 2:48 AM
angelika committed rCOMM5a00b30209f9: [native] Migrate render function and finish FullScreenViewModal migration to… (authored by angelika).
[native] Migrate render function and finish FullScreenViewModal migration to…
Feb 25 2025, 2:48 AM
angelika closed D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.
Feb 25 2025, 2:48 AM
angelika closed D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.
Feb 25 2025, 2:48 AM