Page MenuHomePhabricator
Differential D10425

[lib] Add function for filtering out calendar filters related to one keyserver
ClosedPublic
Actions

Authored by inka on Dec 21 2023, 4:11 AM.
Tags
None
Referenced Files
F3370435: D10425.diff
Tue, Nov 26, 2:39 AM
Unknown Object (File)
Sat, Nov 16, 12:13 PM
Unknown Object (File)
Fri, Nov 8, 1:06 AM
Unknown Object (File)
Oct 25 2024, 3:06 AM
Unknown Object (File)
Oct 18 2024, 2:36 PM
Unknown Object (File)
Oct 18 2024, 2:36 PM
Unknown Object (File)
Oct 18 2024, 2:36 PM
Unknown Object (File)
Oct 18 2024, 2:35 PM
View All 67 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM069305c192a8: [lib] Add function for filtering out calendar filters related to one keyserver
Summary

issue: ENG-5810
I added a helper function removeKeyserverThreadIDsFromFilterList, which removes thread ids of theads reladted to given keyservers from calendar filters.
This function is very similar to previously existing removeDeletedThreadIDsFromFilterList, so I extracted the common code

Test Plan

ran the provided tests. The tests for removeDeletedThreadIDsFromFilterList are not very exhaustive, but they check that the functinon didn't stop working as a result of my changes.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Dec 21 2023, 4:11 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 4:11 AM
inka added a parent revision: D10424: [lib] Add new olm auth action types and temporary identity login action types.Dec 21 2023, 4:12 AM
inka added a child revision: D10426: [lib] Reduce new login actions in reduceCalendarFilters.Dec 21 2023, 4:27 AM
Harbormaster completed remote builds in B25272: Diff 34906.Dec 21 2023, 5:03 AM
inka requested review of this revision.Dec 21 2023, 5:03 AM
michal accepted this revision.Jan 5 2024, 4:10 AM
michal added inline comments.
lib/reducers/calendar-filters-reducer.test.js
143–144

Nit: shouldn't this be like keyserverIDToRemove?

This revision is now accepted and ready to land.Jan 5 2024, 4:10 AM
inka updated this revision to Diff 35401.Jan 8 2024, 9:03 AM

Rename

Harbormaster failed remote builds in B25608: Diff 35401!Jan 8 2024, 9:31 AM
Harbormaster completed remote builds in B25608: Diff 35401.Jan 9 2024, 6:00 AM
Closed by commit rCOMM069305c192a8: [lib] Add function for filtering out calendar filters related to one keyserver (authored by inka). · Explain WhyJan 10 2024, 2:57 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM069305c192a8: [lib] Add function for filtering out calendar filters related to one keyserver.

Revision Contents
Changeset List

Diff 34906

View Options

lib/reducers/calendar-filters-reducer.js

Loading...
View Options

lib/reducers/calendar-filters-reducer.test.js

Loading...