Paths

Table of Contentst

Differential D12476

Move groupping device by platform details and notif info generation promise to utils in lib/push
ClosedPublic
Actions

Authored by marcin on Jun 19 2024, 1:17 PM.

Tags

None

Referenced Files

	F3347604: D12476.diff
	Fri, Nov 22, 12:41 PM

	Unknown Object (File)
	Fri, Nov 15, 9:00 PM

	Unknown Object (File)
	Fri, Nov 15, 8:24 PM

	Unknown Object (File)
	Fri, Nov 15, 8:05 PM

	Unknown Object (File)
	Fri, Nov 15, 9:27 AM

	Unknown Object (File)
	Fri, Nov 15, 6:36 AM

	Unknown Object (File)
	Fri, Nov 15, 1:30 AM

	Unknown Object (File)
	Wed, Nov 13, 3:41 AM

View All 90 Files

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to…

Summary

This differential moves a utility function that groups devices by platform details to lib since we will need it for client-sent notifs as well.

Test Plan

check that notifs work on the keyserver.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Jun 19 2024, 1:17 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 19 2024, 1:17 PM

marcin added a parent revision: D12464: Implement notification texts generation on the client.Jun 19 2024, 1:18 PM

marcin added a child revision: D12477: Implement building encrypted notifications on the client.Jun 19 2024, 1:23 PM

Harbormaster completed remote builds in B29772: Diff 41494.Jun 19 2024, 1:33 PM

marcin requested review of this revision.Jun 19 2024, 1:33 PM

Rebacr

This diff is pure copy paste. No additional logic.

Harbormaster completed remote builds in B29833: Diff 41568.Jun 20 2024, 5:45 AM

kamil accepted this revision.Jun 27 2024, 5:03 AM

kamil added inline comments.

lib/push/utils.js
2 ↗	(On Diff #41568)	add empty line here
5–6 ↗	(On Diff #41568)	can be merged
86–94 ↗	(On Diff #41568)	can you update this to be an object?

This revision is now accepted and ready to land.Jun 27 2024, 5:03 AM

ashoat added inline comments.Jul 1 2024, 12:09 PM

lib/push/utils.js
5–6 ↗	(On Diff #41568)	These are actually different files
86–94 ↗	(On Diff #41568)	+1, way too many functions with a huge number of parameters in this stack. We should max out around 4 params, unless multiple are `booleans` in which case it's more like 2-3

Extract parameters to object

Harbormaster completed remote builds in B30083: Diff 41947.Jul 3 2024, 4:02 AM

Rebase before landing

Harbormaster completed remote builds in B30142: Diff 42019.Jul 4 2024, 6:28 AM

Closed by commit rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to… (authored by marcin). · Explain WhyJul 4 2024, 7:19 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM5447dc6182ef: Move groupping device by platform details and notif info generation promise to….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

7 lines

push/

87 lines

lib/

push/

96 lines

183 lines

Diff 42033

keyserver/src/creators/message-creator.js

Loading...

keyserver/src/push/send.js

Loading...

lib/push/send-utils.js

Loading...

lib/push/utils.js

Loading...