Page MenuHomePhabricator
Differential D13936

[CommCoreModule] cleanup methods for creating backup
AcceptedPublic
Actions

Authored by kamil on Thu, Nov 14, 8:58 AM.
Tags
None
Referenced Files
F3327519: D13936.id45827.diff
Wed, Nov 20, 10:26 AM
F3323864: D13936.id45827.diff
Wed, Nov 20, 4:12 AM
F3323213: D13936.id.diff
Wed, Nov 20, 3:17 AM
Unknown Object (File)
Tue, Nov 19, 7:01 AM
Unknown Object (File)
Mon, Nov 18, 2:10 PM
Unknown Object (File)
Sun, Nov 17, 12:16 PM
Unknown Object (File)
Sat, Nov 16, 6:16 PM
Unknown Object (File)
Sat, Nov 16, 6:16 PM
View All 11 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

ENG-9656.

Cleaning old code to make it more straightforward, reducing code duplication.

Depends on D13935

Test Plan

Tested in D13937

Diff Detail

Repository
rCOMM Comm
Branch
publish-client-backup
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
backup/
30 lines
cpp/
CommonCpp/
NativeModules/
6 lines
84 lines
_generated/
profile/
13 lines
schema/
6 lines

Diff 45827

View Options

native/backup/use-client-backup.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/profile/backup-menu.react.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...