Page MenuHomePhabricator
Differential D13965

[native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`
ClosedPublic
Actions

Authored by kamil on Nov 19 2024, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 1:28 PM
Unknown Object (File)
Thu, Apr 3, 1:14 PM
Unknown Object (File)
Thu, Apr 3, 9:50 AM
Unknown Object (File)
Thu, Apr 3, 2:42 AM
Unknown Object (File)
Wed, Apr 2, 2:48 PM
Unknown Object (File)
Sun, Mar 23, 1:00 PM
Unknown Object (File)
Sun, Mar 23, 12:59 PM
Unknown Object (File)
Mar 3 2025, 6:26 AM
View All 60 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
varun
Commits
rCOMM4188d231937e: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`
Summary

ENG-9905.

This diff merges types and moves retrieving keys to a different step.

This change is not backward compatible but this Flow hasn't been launched yet so we not breaking anything.

NOTE: It's not that easy to slice this into diffs, so it's possible that in the middle of the stack protocol is not working, it needs to be reviewed as a whole.

Depends on D13964

Test Plan

Tested later in the stack - D13968

Diff Detail

Repository
rCOMM Comm
Branch
secondary-auth
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 19 2024, 3:06 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 19 2024, 3:06 AM
kamil edited the summary of this revision. (Show Details)Nov 19 2024, 3:08 AM
kamil added a child revision: D13966: [native][lib] remove `requestBackupKeys` from `SECONDARY_DEVICE_REGISTRATION_SUCCESS`.Nov 19 2024, 3:10 AM
kamil published this revision for review.Nov 19 2024, 4:12 AM
kamil added inline comments.
lib/types/tunnelbroker/qr-code-auth-message-types.js
8–13
kamil edited the test plan for this revision. (Show Details)Nov 19 2024, 4:26 AM
Harbormaster completed remote builds in B32708: Diff 45874.Nov 19 2024, 5:07 AM
bartek accepted this revision.Nov 20 2024, 6:40 AM
This revision is now accepted and ready to land.Nov 20 2024, 6:40 AM
kamil updated this revision to Diff 45988.Nov 25 2024, 2:25 AM

fix comment typo

Harbormaster completed remote builds in B32801: Diff 45988.Nov 25 2024, 2:46 AM
Closed by commit rCOMM4188d231937e: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess` (authored by kamil). · Explain WhyNov 25 2024, 4:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4188d231937e: [native][lib] merge `BackupDataKeyMessage` with `DeviceListUpdateSuccess`.

Revision Contents
Changeset List

PathSize
lib/
types/
tunnelbroker/
36 lines
native/
profile/
45 lines

Diff 45874

View Options

lib/types/tunnelbroker/qr-code-auth-message-types.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/profile/secondary-device-qr-code-scanner.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents