Page MenuHomePhabricator

[native] avoid showing SIWE backup message screen for non-primary devices
ClosedPublic

Authored by kamil on Nov 19 2024, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 8:46 AM
Unknown Object (File)
Fri, Mar 14, 6:10 AM
Unknown Object (File)
Fri, Mar 14, 6:00 AM
Unknown Object (File)
Fri, Mar 14, 5:20 AM
Unknown Object (File)
Fri, Mar 14, 4:04 AM
Unknown Object (File)
Fri, Mar 14, 4:02 AM
Unknown Object (File)
Mon, Mar 10, 9:03 AM
Unknown Object (File)
Mon, Mar 3, 2:39 PM
Subscribers

Details

Summary

ENG-9905.

This a fix for ENG-9917.

Depends on D13967

Test Plan

This is the final diff so testing this end-to-end.
I was scanning the QR code using my physical iOS device, secondary was the web and other iOS physical devices. I was testing this on both passwords and wallet users.
Things I checked:

  • Secondary logged in
  • Secondary received backup data (but ignored this for now)
  • On primary, the camera was dismissed and Secondary was added to the list
  • Tunnel broker connection (auth) created
  • Device list updates are sent

Things I didn't test (not sure if I should):

  • keyserver auth
  • scanning on Android (I don't have access to this device when creating this stack, I can do it later in the week)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Nov 19 2024, 4:28 AM
This revision is now accepted and ready to land.Nov 20 2024, 6:43 AM