native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp
58 ↗	(On Diff #48179)	When testing I discovered this call was missing
web/shared-worker/worker/shared-worker.js
65 ↗	(On Diff #48179)	I'll improve it as part of ENG-10607

kamil mentioned this in D14764: [native][web] add `plaintextDatabasePath` to `restoreFromMainCompaction`.May 26 2025, 3:48 PM

bartek accepted this revision.May 28 2025, 7:23 AM

bartek added inline comments.

web/types/worker-types.js
55 ↗	(On Diff #48179)	Or perhaps `BACKUP_DB`, up to you, but I'd clarify it some way

This revision is now accepted and ready to land.May 28 2025, 7:23 AM

MIGRATE_SCHEMA -> MIGRATE_BACKUP_SCHEMA

build .wasm

Harbormaster failed remote builds in B34290: Diff 48286!May 28 2025, 8:59 AM

Harbormaster completed remote builds in B34291: Diff 48287.May 28 2025, 9:09 AM

Closed by commit rCOMM5473c3820546: [web][native] add to `SQLiteAPI` methods to migrate schema and copy database…. · Explain WhyMay 28 2025, 9:49 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5473c3820546: [web][native] add to `SQLiteAPI` methods to migrate schema and copy database….

kamil mentioned this in rCOMM29e0617e7efe: [native][web] add `plaintextDatabasePath` to `restoreFromMainCompaction`.Jun 2 2025, 10:39 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

2 lines

utils/

__mocks__/

config.js

2 lines

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseManager.h

1 line

DatabaseManager.cpp

6 lines

SQLiteConnectionManager.cpp

1 line

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

47 lines

_generated/

commJSI-generated.cpp

commJSI.h

database/

sqlite-api.js

2 lines

schema/

CommCoreModuleSchema.js

2 lines

web/

database/

sqlite-api.js

14 lines

shared-worker/

_generated/

comm_query_executor.wasm

worker/

backup.js

37 lines

shared-worker.js

22 lines

types/

worker-types.js

16 lines

Diff 48287

View Options

lib/types/sqlite-types.js

View Options

lib/utils/mocks/config.js

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.h

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/database/sqlite-api.js

View Options

native/schema/CommCoreModuleSchema.js

View Options

web/database/sqlite-api.js

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/worker/backup.js

View Options

web/shared-worker/worker/shared-worker.js

View Options

[web][native] add to `SQLiteAPI` methods to migrate schema and copy database contentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48287

lib/types/sqlite-types.js

lib/utils/__mocks__/config.js

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.h

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/database/sqlite-api.js

native/schema/CommCoreModuleSchema.js

web/database/sqlite-api.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/worker/backup.js

web/shared-worker/worker/shared-worker.js

web/types/worker-types.js

[web][native] add to `SQLiteAPI` methods to migrate schema and copy database content
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js