services/backup/blob_client/src/put_client.rs
198–206 ↗	(On Diff #16170)	Is it possible to avoid taking and setting back the client? Can we use references to achieve the same result but in a simpler way?

This revision now requires changes to proceed.Sep 5 2022, 5:12 AM

• karol requested review of this revision.Sep 6 2022, 1:30 AM

• karol added inline comments.

services/backup/blob_client/src/put_client.rs
198–206 ↗	(On Diff #16170)	I'm not sure, I already spent some time trying to hack this and by far that's the only way I could make it work. This was raised across my diffs several times already. I don't see it that harmful at the end of the day, not sure what's the big deal here.

• karol added inline comments.Sep 6 2022, 1:35 AM

services/backup/blob_client/src/put_client.rs
198–206 ↗	(On Diff #16170)	https://linear.app/comm/issue/ENG-1736/try-to-avoid-reassigning-when-modifying-the-field-of-a-global-struct

tomek accepted this revision.Sep 6 2022, 7:14 AM

tomek added inline comments.

services/backup/blob_client/src/put_client.rs
198–206 ↗	(On Diff #16170)	Ok, let's treat this as a followup.
200 ↗	(On Diff #16170)	I've mentioned this in other places, but it would be great if we could return this value from async block instead of mutating a `response` variable.

This revision is now accepted and ready to land.Sep 6 2022, 7:14 AM

address comment

Harbormaster completed remote builds in B11978: Diff 16433.Sep 8 2022, 3:36 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM

Closed by commit rCOMMc915b14cca4a: [services] Backup - Blob Put Client - Add blocking read (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMc915b14cca4a: [services] Backup - Blob Put Client - Add blocking read.

Harbormaster completed remote builds in B11987: Diff 16442.Sep 8 2022, 4:12 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

put_client.rs

23 lines

Diff 16442

View Options

services/backup/blob_client/src/put_client.rs

Show All 34 Lines
#import <React/RCTJSIExecutorRuntimeInstaller.h>		#import <React/RCTJSIExecutorRuntimeInstaller.h>
#import <React/RCTLinkingManager.h>		#import <React/RCTLinkingManager.h>
#import <cxxreact/JSExecutor.h>		#import <cxxreact/JSExecutor.h>
#import <jsireact/JSIExecutor.h>		#import <jsireact/JSIExecutor.h>
#import <reacthermes/HermesExecutorFactory.h>		#import <reacthermes/HermesExecutorFactory.h>

#import "CommConstants.h"		#import "CommConstants.h"
#import "CommCoreModule.h"		#import "CommCoreModule.h"
		#import "CommRustModule.h"
#import "CommUtilsModule.h"		#import "CommUtilsModule.h"
#import "GlobalDBSingleton.h"		#import "GlobalDBSingleton.h"
#import "Logger.h"		#import "Logger.h"
#import "MessageOperationsUtilities.h"		#import "MessageOperationsUtilities.h"
#import "TemporaryMessageStorage.h"		#import "TemporaryMessageStorage.h"
#import "ThreadOperations.h"		#import "ThreadOperations.h"
#import "Tools.h"		#import "Tools.h"
#import <cstdio>		#import <cstdio>
▲ Show 20 Lines • Show All 223 Lines • ▼ Show 20 Lines	if (!bridge) {
return;		return;
}		}
__typeof(self) strongSelf = weakSelf;		__typeof(self) strongSelf = weakSelf;
if (strongSelf) {		if (strongSelf) {
std::shared_ptr<comm::CommCoreModule> coreNativeModule =		std::shared_ptr<comm::CommCoreModule> coreNativeModule =
std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker);		std::make_shared<comm::CommCoreModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommUtilsModule> utilsNativeModule =		std::shared_ptr<comm::CommUtilsModule> utilsNativeModule =
std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker);		std::make_shared<comm::CommUtilsModule>(bridge.jsCallInvoker);
		std::shared_ptr<comm::CommRustModule> rustNativeModule =
		std::make_shared<comm::CommRustModule>(bridge.jsCallInvoker);
std::shared_ptr<comm::CommConstants> nativeConstants =		std::shared_ptr<comm::CommConstants> nativeConstants =
std::make_shared<comm::CommConstants>();		std::make_shared<comm::CommConstants>();

rt.global().setProperty(		rt.global().setProperty(
rt,		rt,
facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"),		facebook::jsi::PropNameID::forAscii(rt, "CommCoreModule"),
facebook::jsi::Object::createFromHostObject(rt, coreNativeModule));		facebook::jsi::Object::createFromHostObject(rt, coreNativeModule));
rt.global().setProperty(		rt.global().setProperty(
rt,		rt,
facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"),		facebook::jsi::PropNameID::forAscii(rt, "CommUtilsModule"),
facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule));		facebook::jsi::Object::createFromHostObject(rt, utilsNativeModule));
rt.global().setProperty(		rt.global().setProperty(
rt,		rt,
		facebook::jsi::PropNameID::forAscii(rt, "CommRustModule"),
		facebook::jsi::Object::createFromHostObject(rt, rustNativeModule));
		rt.global().setProperty(
		rt,
facebook::jsi::PropNameID::forAscii(rt, "CommConstants"),		facebook::jsi::PropNameID::forAscii(rt, "CommConstants"),
facebook::jsi::Object::createFromHostObject(rt, nativeConstants));		facebook::jsi::Object::createFromHostObject(rt, nativeConstants));
}		}
};		};
const auto installer =		const auto installer =
reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller);		reanimated::REAJSIExecutorRuntimeInstaller(bridge, commRuntimeInstaller);

return std::make_unique<HermesExecutorFactory>(		return std::make_unique<HermesExecutorFactory>(
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines

[services] Backup - Blob Put Client - Add blocking readClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16442

services/backup/blob_client/src/put_client.rs

[services] Backup - Blob Put Client - Add blocking read
ClosedPublic
Actions

Revision Contents
Changeset List