Page MenuHomePhabricator
Differential D5016

[services] Backup - Blob Get Client - Add terminate
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 4:09 AM.
Tags
None
Referenced Files
F3365007: D5016.diff
Mon, Nov 25, 6:17 AM
Unknown Object (File)
Fri, Nov 22, 8:15 AM
Unknown Object (File)
Fri, Nov 22, 8:08 AM
Unknown Object (File)
Mon, Nov 18, 3:16 PM
Unknown Object (File)
Sun, Nov 10, 6:57 AM
Unknown Object (File)
Sun, Nov 3, 1:18 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
varun
• max
Commits
rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate
Summary

Depends on D5015

Adding terminate function to the blob get client.

Test Plan

backup builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 4:09 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 4:09 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 1 2022, 4:25 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun, • max.
• karol added a parent revision: D5015: [services] Backup - Blob Get Client - Add blocking read.
• karol added a child revision: D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
Harbormaster completed remote builds in B11773: Diff 16176.Sep 1 2022, 4:28 AM
• karol requested review of this revision.Sep 1 2022, 4:28 AM
• karol planned changes to this revision.Sep 2 2022, 7:16 AM
• karol updated this revision to Diff 16249.Sep 2 2022, 7:17 AM

update

Harbormaster completed remote builds in B11844: Diff 16249.Sep 2 2022, 7:27 AM
tomek accepted this revision.Sep 5 2022, 5:40 AM
This revision is now accepted and ready to land.Sep 5 2022, 5:40 AM
• karol updated this revision to Diff 16448.Sep 8 2022, 4:01 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
Closed by commit rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM440114cd315c: [services] Backup - Blob Get Client - Add terminate.
Harbormaster completed remote builds in B11993: Diff 16448.Sep 8 2022, 4:18 AM
ashoat added inline comments.Sep 15 2022, 6:39 AM
services/backup/blob_client/src/get_client.rs
151–163 ↗(On Diff #16475)

We could have reduced indentation here by simply reversing conditions. See here

• karol added inline comments.Sep 15 2022, 6:46 AM
services/backup/blob_client/src/get_client.rs
151–163 ↗(On Diff #16475)

Are you sure this is possible when dealing with if let? How exactly can we do this? We need the unpacked values inside of the condition.

ashoat added inline comments.Sep 16 2022, 7:14 AM
services/backup/blob_client/src/get_client.rs
151–163 ↗(On Diff #16475)

Ah, you may be right. Sorry, I'm not so familiar with Rust...

Revision Contents
Changeset List

PathSize
services/
backup/
blob_client/
src/
26 lines

Diff 16249

View Options

services/backup/blob_client/src/get_client.rs

Loading...